From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 6550C2BFA for ; Sat, 5 Mar 2016 23:11:30 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l68so30261543wml.1 for ; Sat, 05 Mar 2016 14:11:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Nkep6TUBQrwN9Lhvb84hWMckUD0u67u2Qa+XLU6I/KY=; b=RP0fWALcclu7KlOq8hSDv1DsZrsOhpmCQVY2dHebjLOjVPqQq/F6SP/M+w5QyoNqtp Icoa8hUK1ZPiMeVE5qG56PVKZOZ9yYA0GHoAYhm0bF7LoUYNVuwf32ZGmRyulPJvc5vY hNPV0ei8jdbqPUyoRca2FGJDitfVqchE8IlRzBnNrydKX/Uiy84AqgivincvjVacm9a+ b04DrGRRwNhgUlAz77sZ/Yiaoyo0MH8TLy/zrM6/19lr0wlXxtQvIPNf5cpx9eqBTPhD ta3zFoHGWrIat2H3DB+PIrAc9ghB9I2Yq//Kzmnj1ftoFsCnzhrhtOFWLquke9GCA3Xa gmTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=Nkep6TUBQrwN9Lhvb84hWMckUD0u67u2Qa+XLU6I/KY=; b=d2Ad9vt5Qx3dLVs1pqrp0yeHM6+1pGicU+FKjR22Oe0ByKWR3dold9nIrPQmkRNKN7 5ZtTBVqCJWClKszUWCnT1JHy18wnenwjYCpmBzyRt4YM47xej2AVwj0AF60K2F2aMSRo brjNZfc3j/hc4DtCNZVX77GegxYnhUnzLjgqALQcOgiUQARPNWpzN6zwj+qkuwsmv5Cv GhNMwFC4zxoDJYrXszkrBLnxE72/BxYcpfJ5bSOfeNsYn5abX0hY1u+tHjIYgkJYIBSa tdfL4SWJGZXN5qp8TsyuhgHdZ5aZeUkQEoqGqpm/71cO1dN7+WiGqXcc4ouXwYlfCh14 rpPQ== X-Gm-Message-State: AD7BkJJhfSKaCy0Qqe8GxGvIpKvA1QvBth6XJtq+bl/1jr8yFpqrZppkglkOLx9+dGZD95zJ X-Received: by 10.194.78.199 with SMTP id d7mr15362801wjx.106.1457215890268; Sat, 05 Mar 2016 14:11:30 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id h128sm5660342wmf.23.2016.03.05.14.11.28 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 05 Mar 2016 14:11:29 -0800 (PST) From: Thomas Monjalon To: Ming Zhao Date: Sat, 05 Mar 2016 23:09:52 +0100 Message-ID: <1495521.iYHtmlEZSL@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1456470671-18425-1-git-send-email-mzhao@luminatewireless.com> References: <1456470671-18425-1-git-send-email-mzhao@luminatewireless.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Fix buffer overflow issue in app/test/commands.c(we add 1 extra byte for trailing \0). X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Mar 2016 22:11:30 -0000 Hi, 2016-02-25 23:11, Ming Zhao: > Fix memleak of cmdline in app/test/test.c It looks to be two different fixes: - an overflow - a memleak Please send 2 patches, with Fixes lines (even if is there since the first commit), with Signed-off-by line. See http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line