From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 5395AC464 for ; Mon, 27 Apr 2015 19:29:23 +0200 (CEST) Received: by wgin8 with SMTP id n8so123749892wgi.0 for ; Mon, 27 Apr 2015 10:29:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=138dSmVnjOec1riy4bdevRxYyEWjAfYt8VtbcionLSM=; b=CGpYFT4JmZyQpr6pF45YW4DF5X1sBCOaJxtk+2LdLZpi4ob1QlUB/YLe6lL22Cp0KO RVQJZIaEcnbuTGSgrMZh8HbZcMBzWV0kSTLo57+cVsviXBJx31WKlf+KugWc0uDPa3qm pNH9LHFMf2hFYwu6REK1ZXCN6SPLEAL8p9aYIGmL1/CgFpNMl/dSV4gdxKkzM19yEycH SxPfk6uSBOsP6t6FlGhcg1PSdom4nQH+tQK7OGR4+xp7BkwU4DkSkLDdxdDmVUqw2ZJ0 dE6BdFDTbaeZyZH7i7BrfFC8ufAhsRrghPcBL2TYaPH0Dm/Hohp4kbsGfiLvYgomTqaA teEA== X-Gm-Message-State: ALoCoQlHspqFR9YtKXr2vDWrcSy1MxjGAeYkXCYO4EIYIq43H6e8S7w9Pk+ZqRrB04OX+G0LiN6b X-Received: by 10.195.17.232 with SMTP id gh8mr24008033wjd.145.1430155763201; Mon, 27 Apr 2015 10:29:23 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id um5sm16470847wjc.1.2015.04.27.10.29.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2015 10:29:22 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Mon, 27 Apr 2015 19:28:40 +0200 Message-ID: <1498171.E9UuRyUjTK@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1429518150-28098-14-git-send-email-helin.zhang@intel.com> References: <1429518150-28098-1-git-send-email-helin.zhang@intel.com> <1429518150-28098-14-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, steven.j.murray@intel.com, chiu-pi.shih@intel.com, monica.kenguva@intel.com Subject: Re: [dpdk-dev] [PATCH 13/18] i40e: replacement of 'i40e_debug_read_register()' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2015 17:29:23 -0000 2015-04-20 16:22, Helin Zhang: > As base driver provides 'i40e_aq_debug_read_register()', the same > functional interface of 'i40e_debug_read_register()' can be replaced. > > Signed-off-by: Helin Zhang > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 22 ++-------------------- > 1 file changed, 2 insertions(+), 20 deletions(-) It should be merged with the patch introducing the function in the base driver. So it will be easier to check what changed.