From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1.zte.com.cn (out1.zte.com.cn [202.103.147.172]) by dpdk.org (Postfix) with ESMTP id 07C6D2BF1 for ; Fri, 23 Jun 2017 13:07:13 +0200 (CEST) X-scanvirus: By SEG_CYREN AntiVirus Engine X-scanresult: CLEAN X-MAILFROM: X-RCPTTO: X-FROMIP: 10.30.3.20 X-SEG-Scaned: 1 X-Received: unknown,10.30.3.20,20170623185058 Received: from unknown (HELO mse01.zte.com.cn) (10.30.3.20) by localhost with (AES256-SHA encrypted) SMTP; 23 Jun 2017 10:50:58 -0000 Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v5NB6tmG049998; Fri, 23 Jun 2017 19:06:55 +0800 (GMT-8) (envelope-from wang.yong19@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.43.166.165]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017062319070148-2181959 ; Fri, 23 Jun 2017 19:07:01 +0800 From: Yong Wang To: jingjing.wu@intel.com Cc: dev@dpdk.org, Yong Wang Date: Fri, 23 Jun 2017 06:57:47 -0400 Message-Id: <1498215467-19681-1-git-send-email-wang.yong19@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-06-23 19:07:01, Serialize by Router on notes_smtp/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-06-23 19:06:39, Serialize complete at 2017-06-23 19:06:39 X-MAIL: mse01.zte.com.cn v5NB6tmG049998 X-HQIP: 127.0.0.1 Subject: [dpdk-dev] [PATCH v2] net/i40e: fix division by 0 error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 11:07:15 -0000 In function i40e_vsi_config_tc_queue_mapping(), if 'enabled_tcmap' is 0, 'total_tc' might be 0. Then 'total_tc' might be used in a division by 0 in "qpnum_per_tc = i40e_align_floor(vsi->nb_qps / total_tc)". Fix it by changing 'total_tc' from 0 to 1 just as func i40e_vsi_update_queue_mapping() does. Signed-off-by: Yong Wang --- drivers/net/i40e/i40e_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 4ee1113..0f54d09 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -4281,9 +4281,12 @@ enum i40e_status_code if (ret != I40E_SUCCESS) return ret; - for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) + for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) { if (enabled_tcmap & (1 << i)) total_tc++; + } + if (total_tc == 0) + total_tc = 1; vsi->enabled_tc = enabled_tcmap; /* Number of queues per enabled TC */ -- 1.8.3.1