* [dpdk-dev] [PATCH v2] net/i40e: fix division by 0 error
@ 2017-06-23 10:57 Yong Wang
2017-06-29 5:18 ` Wu, Jingjing
0 siblings, 1 reply; 3+ messages in thread
From: Yong Wang @ 2017-06-23 10:57 UTC (permalink / raw)
To: jingjing.wu; +Cc: dev, Yong Wang
In function i40e_vsi_config_tc_queue_mapping(), if 'enabled_tcmap' is
0, 'total_tc' might be 0. Then 'total_tc' might be used in a division
by 0 in "qpnum_per_tc = i40e_align_floor(vsi->nb_qps / total_tc)". Fix
it by changing 'total_tc' from 0 to 1 just as func
i40e_vsi_update_queue_mapping() does.
Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
drivers/net/i40e/i40e_ethdev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 4ee1113..0f54d09 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -4281,9 +4281,12 @@ enum i40e_status_code
if (ret != I40E_SUCCESS)
return ret;
- for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++)
+ for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {
if (enabled_tcmap & (1 << i))
total_tc++;
+ }
+ if (total_tc == 0)
+ total_tc = 1;
vsi->enabled_tc = enabled_tcmap;
/* Number of queues per enabled TC */
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/i40e: fix division by 0 error
2017-06-23 10:57 [dpdk-dev] [PATCH v2] net/i40e: fix division by 0 error Yong Wang
@ 2017-06-29 5:18 ` Wu, Jingjing
2017-06-29 11:14 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Wu, Jingjing @ 2017-06-29 5:18 UTC (permalink / raw)
To: Yong Wang; +Cc: dev
> -----Original Message-----
> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
> Sent: Friday, June 23, 2017 6:58 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>
> Subject: [PATCH v2] net/i40e: fix division by 0 error
>
> In function i40e_vsi_config_tc_queue_mapping(), if 'enabled_tcmap' is 0,
> 'total_tc' might be 0. Then 'total_tc' might be used in a division by 0 in
> "qpnum_per_tc = i40e_align_floor(vsi->nb_qps / total_tc)". Fix it by changing
> 'total_tc' from 0 to 1 just as func
> i40e_vsi_update_queue_mapping() does.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/i40e: fix division by 0 error
2017-06-29 5:18 ` Wu, Jingjing
@ 2017-06-29 11:14 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-06-29 11:14 UTC (permalink / raw)
To: Wu, Jingjing, Yong Wang; +Cc: dev
On 6/29/2017 6:18 AM, Wu, Jingjing wrote:
>
>
>> -----Original Message-----
>> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
>> Sent: Friday, June 23, 2017 6:58 PM
>> To: Wu, Jingjing <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>
>> Subject: [PATCH v2] net/i40e: fix division by 0 error
>>
>> In function i40e_vsi_config_tc_queue_mapping(), if 'enabled_tcmap' is 0,
>> 'total_tc' might be 0. Then 'total_tc' might be used in a division by 0 in
>> "qpnum_per_tc = i40e_align_floor(vsi->nb_qps / total_tc)". Fix it by changing
>> 'total_tc' from 0 to 1 just as func
>> i40e_vsi_update_queue_mapping() does.
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
>
>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
>
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Applied to dpdk-next-net/master, thanks.
(Adding braces to for loop not required and not related the patch,
removed from patch)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-29 11:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 10:57 [dpdk-dev] [PATCH v2] net/i40e: fix division by 0 error Yong Wang
2017-06-29 5:18 ` Wu, Jingjing
2017-06-29 11:14 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).