From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8C4345BA0; Tue, 22 Oct 2024 14:32:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F0DC4029A; Tue, 22 Oct 2024 14:32:04 +0200 (CEST) Received: from smtp-gw.pt.net (smtp-gw.pt.net [206.210.192.15]) by mails.dpdk.org (Postfix) with ESMTP id 1F67040273 for ; Tue, 22 Oct 2024 14:32:03 +0200 (CEST) X-ASG-Debug-ID: 1729600321-09411a490f2cafd0001-TfluYd Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by smtp-gw.pt.net with ESMTP id flCkw4eV0P8gFuSE (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Tue, 22 Oct 2024 07:32:02 -0500 (CDT) X-Barracuda-Envelope-From: lew@perftech.com X-Barracuda-Effective-Source-IP: mail.pt.net[206.210.194.11] X-Barracuda-Apparent-Source-IP: 206.210.194.11 Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id E06F4D0D74C for ; Tue, 22 Oct 2024 07:32:01 -0500 (CDT) Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10032) with ESMTP id VtfhTFVnImcq for ; Tue, 22 Oct 2024 07:32:01 -0500 (CDT) Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 7C0B0D0D745 for ; Tue, 22 Oct 2024 07:32:01 -0500 (CDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.pt.net 7C0B0D0D745 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perftech.com; s=B15A3A56-ABEA-11EE-9719-5F12F125680F; t=1729600321; bh=nEWyyU0Ez1rEt7VuejvsNUtqe9TjbOIKkMSgZYjBNHs=; h=Date:From:To:Message-ID:MIME-Version; b=KkraR8/uO5BeJsFEJSrcP1DoCqxX+7inLaKWuGaUnDCrrZe7BvGNyBHeux7NvcfEx UajUlnCxIg23/UNImnQj+tjbmXf2mqbYqAC+CR9Mo/lwTCo+lS+nJBoJKXiopdjBdt Yulng0DBOCuzar5CMOstK/3DE49qTGEmIQunE6p0ouRfpm0ECaUH3hSi+oA9j8krUd pT70LmQbg2roDOiWAhFsKLuH57aYHZQiMxg109JvSb2NlqAiYhJ7x52Q6dcvc1IUsA X9LcW7j3pr6by7avRnYuZ046mt8qf7sY+9i5Da6J+e5cEbamNrhd4em5Nd9F4gD8av 4ev7+QjQED6AA== X-Virus-Scanned: amavis at pt.net Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10026) with ESMTP id fYTnX3wm4wsc for ; Tue, 22 Oct 2024 07:32:01 -0500 (CDT) Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by mail.pt.net (Postfix) with ESMTP id 6D390D0D37F for ; Tue, 22 Oct 2024 07:32:01 -0500 (CDT) Date: Tue, 22 Oct 2024 07:32:01 -0500 (CDT) From: Lewis Donzis To: dev Message-ID: <1498261798.8960233.1729600321210.JavaMail.zimbra@donzis.com> In-Reply-To: <136318200.3114519.1727475831877.JavaMail.zimbra@donzis.com> References: <20240927180829.525350-1-sriharsha.basavapatna@broadcom.com> <20240927180829.525350-18-sriharsha.basavapatna@broadcom.com> <136318200.3114519.1727475831877.JavaMail.zimbra@donzis.com> Subject: Re: FreeBSD problem with ixgbe MIME-Version: 1.0 X-ASG-Orig-Subj: Re: FreeBSD problem with ixgbe Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: [206.210.194.11] X-Mailer: Zimbra 8.8.15_GA_4652 (ZimbraWebClient - GC130 (Mac)/8.8.15_GA_4652) Thread-Topic: FreeBSD problem with ixgbe Thread-Index: ABa/KCAx+Zs8B6+x0q4oPmp73XxhWGVFwpUO X-Barracuda-Connect: mail.pt.net[206.210.194.11] X-Barracuda-Start-Time: 1729600322 X-Barracuda-Encrypted: TLS_AES_256_GCM_SHA384 X-Barracuda-URL: https://smtp-gw.pt.net:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at pt.net X-Barracuda-Scan-Msg-Size: 1002 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.132141 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I've reported this several times over the last two years, but there's been no reply and no change to the ixgbe driver. Specifically, calling rte_eth_link_get_nowait() on FreeBSD does, in fact, wait for link-up which causes unexpected and long delays. I suggest removing the line from ixgbe_dev_link_update_share() that forces "wait" to be set on FreeBSD. Would someone be willing to commit this, please? Thanks, lew Here's the "git diff" from a modified version: diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index ab37c37469..008760e315 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4314,11 +4314,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0) wait = 0; -/* BSD has no interrupt mechanism, so force NIC status synchronization. */ -#ifdef RTE_EXEC_ENV_FREEBSD - wait = 1; -#endif -