DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: fix a link in contribution guide
@ 2017-01-06  1:22 Yongseok Koh
  2017-01-06 15:40 ` Mcnamara, John
  2017-01-06 22:40 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
  0 siblings, 2 replies; 5+ messages in thread
From: Yongseok Koh @ 2017-01-06  1:22 UTC (permalink / raw)
  To: john.mcnamara; +Cc: dev, Yongseok Koh

A referenced document in the Linux Kernel has been moved to a
sub-directory.

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
 doc/guides/contributing/patches.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index c7006c191..a6bae9172 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -7,7 +7,7 @@ This document outlines the guidelines for submitting code to DPDK.
 
 The DPDK development process is modelled (loosely) on the Linux Kernel development model so it is worth reading the
 Linux kernel guide on submitting patches:
-`How to Get Your Change Into the Linux Kernel <http://www.kernel.org/doc/Documentation/SubmittingPatches>`_.
+`How to Get Your Change Into the Linux Kernel <http://www.kernel.org/doc/Documentation/process/submitting-patches.rst>`_.
 The rationale for many of the DPDK guidelines is explained in greater detail in the kernel guidelines.
 
 
@@ -192,7 +192,7 @@ Here are some guidelines for the body of a commit message:
       git commit --signoff # or -s
 
   The purpose of the signoff is explained in the
-  `Developer's Certificate of Origin <http://www.kernel.org/doc/Documentation/SubmittingPatches>`_
+  `Developer's Certificate of Origin <http://www.kernel.org/doc/Documentation/process/submitting-patches.rst>`_
   section of the Linux kernel guidelines.
 
   .. Note::
-- 
2.11.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: fix a link in contribution guide
  2017-01-06  1:22 [dpdk-dev] [PATCH] doc: fix a link in contribution guide Yongseok Koh
@ 2017-01-06 15:40 ` Mcnamara, John
  2017-01-06 22:40 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
  1 sibling, 0 replies; 5+ messages in thread
From: Mcnamara, John @ 2017-01-06 15:40 UTC (permalink / raw)
  To: Yongseok Koh; +Cc: dev

> -----Original Message-----
> From: Yongseok Koh [mailto:yskoh@mellanox.com]
> Sent: Friday, January 6, 2017 1:23 AM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Yongseok Koh <yskoh@mellanox.com>
> Subject: [PATCH] doc: fix a link in contribution guide
> 
> A referenced document in the Linux Kernel has been moved to a sub-
> directory.
> 

Hi Yongseok,

Thanks for that. It is interesting to see kernel community move to RST/Sphinx.


> 
>  The DPDK development process is modelled (loosely) on the Linux Kernel
> development model so it is worth reading the  Linux kernel guide on
> submitting patches:
> -`How to Get Your Change Into the Linux Kernel 
> <http://www.kernel.org/doc/Documentation/SubmittingPatches>`_.
> +`How to Get Your Change Into the Linux Kernel
> <http://www.kernel.org/doc/Documentation/process/submitting-
> patches.rst>`_.


It would be better to use the Html rendered link here:

    https://www.kernel.org/doc/html/latest/process/submitting-patches.html


>  The rationale for many of the DPDK guidelines is explained in greater
> detail in the kernel guidelines.
> 
> 
> @@ -192,7 +192,7 @@ Here are some guidelines for the body of a commit
> message:
>        git commit --signoff # or -s
> 
>    The purpose of the signoff is explained in the
> -  `Developer's Certificate of Origin
> <http://www.kernel.org/doc/Documentation/SubmittingPatches>`_
> +  `Developer's Certificate of Origin
> + <http://www.kernel.org/doc/Documentation/process/submitting-patches.rs
> + t>`_

And here:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

John

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH v2] doc: fix a link in contribution guide
  2017-01-06  1:22 [dpdk-dev] [PATCH] doc: fix a link in contribution guide Yongseok Koh
  2017-01-06 15:40 ` Mcnamara, John
@ 2017-01-06 22:40 ` Yongseok Koh
  2017-01-09  8:33   ` Mcnamara, John
  1 sibling, 1 reply; 5+ messages in thread
From: Yongseok Koh @ 2017-01-06 22:40 UTC (permalink / raw)
  To: john.mcnamara; +Cc: dev, Yongseok Koh

A referenced document in the Linux Kernel has been moved to a
sub-directory. And kernel community has moved to RST/Sphinx. The links are
replaced with HTML rendered links.

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
 doc/guides/contributing/patches.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index c7006c191..193889a89 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -7,7 +7,7 @@ This document outlines the guidelines for submitting code to DPDK.
 
 The DPDK development process is modelled (loosely) on the Linux Kernel development model so it is worth reading the
 Linux kernel guide on submitting patches:
-`How to Get Your Change Into the Linux Kernel <http://www.kernel.org/doc/Documentation/SubmittingPatches>`_.
+`How to Get Your Change Into the Linux Kernel <https://www.kernel.org/doc/html/latest/process/submitting-patches.html>`_.
 The rationale for many of the DPDK guidelines is explained in greater detail in the kernel guidelines.
 
 
@@ -192,7 +192,7 @@ Here are some guidelines for the body of a commit message:
       git commit --signoff # or -s
 
   The purpose of the signoff is explained in the
-  `Developer's Certificate of Origin <http://www.kernel.org/doc/Documentation/SubmittingPatches>`_
+  `Developer's Certificate of Origin <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1>`_
   section of the Linux kernel guidelines.
 
   .. Note::
-- 
2.11.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: fix a link in contribution guide
  2017-01-06 22:40 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
@ 2017-01-09  8:33   ` Mcnamara, John
  2017-01-17 16:04     ` Thomas Monjalon
  0 siblings, 1 reply; 5+ messages in thread
From: Mcnamara, John @ 2017-01-09  8:33 UTC (permalink / raw)
  To: Yongseok Koh; +Cc: dev



> -----Original Message-----
> From: Yongseok Koh [mailto:yskoh@mellanox.com]
> Sent: Friday, January 6, 2017 10:40 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Yongseok Koh <yskoh@mellanox.com>
> Subject: [PATCH v2] doc: fix a link in contribution guide
> 
> A referenced document in the Linux Kernel has been moved to a sub-
> directory. And kernel community has moved to RST/Sphinx. The links are
> replaced with HTML rendered links.
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>

Acked-by: John McNamara <john.mcnamara@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: fix a link in contribution guide
  2017-01-09  8:33   ` Mcnamara, John
@ 2017-01-17 16:04     ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2017-01-17 16:04 UTC (permalink / raw)
  To: Yongseok Koh; +Cc: dev, Mcnamara, John

> > A referenced document in the Linux Kernel has been moved to a sub-
> > directory. And kernel community has moved to RST/Sphinx. The links are
> > replaced with HTML rendered links.
> > 
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-01-17 16:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-06  1:22 [dpdk-dev] [PATCH] doc: fix a link in contribution guide Yongseok Koh
2017-01-06 15:40 ` Mcnamara, John
2017-01-06 22:40 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
2017-01-09  8:33   ` Mcnamara, John
2017-01-17 16:04     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).