DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jiayu Hu <jiayu.hu@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, Jiayu Hu <jiayu.hu@intel.com>
Subject: [dpdk-dev] [PATCH] lib/gro: fix doxygen comment issue
Date: Tue, 11 Jul 2017 14:18:43 +0800	[thread overview]
Message-ID: <1499753923-112342-1-git-send-email-jiayu.hu@intel.com> (raw)

This patch updates GRO API comments to generate correct
API documentation by doxygen.

Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
---
 lib/librte_gro/rte_gro.h | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/lib/librte_gro/rte_gro.h b/lib/librte_gro/rte_gro.h
index 3b4fec0..c409270 100644
--- a/lib/librte_gro/rte_gro.h
+++ b/lib/librte_gro/rte_gro.h
@@ -33,36 +33,44 @@
 #ifndef _RTE_GRO_H_
 #define _RTE_GRO_H_
 
+/**
+ * @file
+ * Interface to GRO library
+ */
+
 #ifdef __cplusplus
 extern "C" {
 #endif
 
-/**< the max packets number that rte_gro_reassemble_burst()
+#define RTE_GRO_MAX_BURST_ITEM_NUM 128U
+/**< the max number of packets that rte_gro_reassemble_burst()
  * can process in each invocation.
  */
-#define RTE_GRO_MAX_BURST_ITEM_NUM 128U
-
-/**< max number of supported GRO types */
 #define RTE_GRO_TYPE_MAX_NUM 64
-/**< current supported GRO num */
+/**< the max number of supported GRO types */
 #define RTE_GRO_TYPE_SUPPORT_NUM 1
+/**< the number of currently supported GRO types */
 
-/**< TCP/IPv4 GRO flag */
 #define RTE_GRO_TCP_IPV4_INDEX 0
 #define RTE_GRO_TCP_IPV4 (1ULL << RTE_GRO_TCP_IPV4_INDEX)
+/**< TCP/IPv4 GRO flag */
 
+/**
+ * A structure which is used to create GRO context objects or tell
+ * rte_gro_reassemble_burst() what reassembly rules are demanded.
+ */
 struct rte_gro_param {
-	/**< desired GRO types */
 	uint64_t gro_types;
-	/**< max flow number */
+	/**< desired GRO types */
 	uint16_t max_flow_num;
-	/**< max packet number per flow */
+	/**< max flow number */
 	uint16_t max_item_per_flow;
+	/**< max packet number per flow */
+	uint16_t socket_id;
 	/**< socket index for allocating GRO related data structures,
 	 * like reassembly tables. When use rte_gro_reassemble_burst(),
 	 * applications don't need to set this value.
 	 */
-	uint16_t socket_id;
 };
 
 /**
@@ -105,7 +113,7 @@ void rte_gro_ctx_destroy(void *ctx);
  *
  * @param pkts
  *  a pointer array which points to the packets to reassemble. Besides,
- *  it keeps packet addresses for GROed packets.
+ *  it keeps mbuf addresses for the GROed packets.
  * @param nb_pkts
  *  the number of packets to reassemble.
  * @param param
-- 
2.7.4

             reply	other threads:[~2017-07-11  6:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11  6:18 Jiayu Hu [this message]
2017-07-21 15:05 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499753923-112342-1-git-send-email-jiayu.hu@intel.com \
    --to=jiayu.hu@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).