From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id DD26A2B96
 for <dev@dpdk.org>; Wed,  5 Oct 2016 15:30:21 +0200 (CEST)
Received: from lfbn-1-5996-232.w90-110.abo.wanadoo.fr ([90.110.195.232]
 helo=[192.168.1.13])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1brmJz-0001Vu-Tw; Wed, 05 Oct 2016 15:33:20 +0200
To: Maxime Coquelin <maxime.coquelin@redhat.com>, dev@dpdk.org,
 yuanhan.liu@linux.intel.com
References: <1469088510-7552-1-git-send-email-olivier.matz@6wind.com>
 <1475485223-30566-1-git-send-email-olivier.matz@6wind.com>
 <1475485223-30566-10-git-send-email-olivier.matz@6wind.com>
 <1da0b2c2-931b-3164-d211-4ceee7fd6864@redhat.com>
 <98db7fbb-42bd-512f-1d40-a1f3304a895e@6wind.com>
 <e96537d6-b99a-2668-e8bf-3a64529f0d55@redhat.com>
Cc: konstantin.ananyev@intel.com, sugesh.chandran@intel.com,
 bruce.richardson@intel.com, jianfeng.tan@intel.com, helin.zhang@intel.com,
 adrien.mazarguil@6wind.com, stephen@networkplumber.org, dprovan@bivio.net,
 xiao.w.wang@intel.com
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <149c32d2-a4ab-05fb-179f-5d6cd221e4f4@6wind.com>
Date: Wed, 5 Oct 2016 15:30:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <e96537d6-b99a-2668-e8bf-3a64529f0d55@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 09/12] virtio: add Rx checksum offload
 support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Oct 2016 13:30:22 -0000



On 10/05/2016 03:27 PM, Maxime Coquelin wrote:
>> @@ -903,7 +905,8 @@ virtio_recv_pkts(void *rx_queue, struct rte_mbuf
>> **rx_pkts, uint16_t nb_pkts)
>>                         rte_vlan_strip(rxm);
>>
>>                 /* Update offload features */
>> -               if (virtio_rx_offload(rxm, hdr) < 0) {
>> +               if ((features & VIRTIO_NET_F_GUEST_CSUM) &&
> s/VIRTIO_NET_F_GUEST_CSUM/(1u << VIRTIO_NET_F_GUEST_CSUM)/

oooh good catch :)

> And don't forget to update the test for LRO patch.

yep

> Except this, it sounds good.

Thanks, I'll send a v3 soon.

Olivier