From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0047.outbound.protection.outlook.com [104.47.41.47]) by dpdk.org (Postfix) with ESMTP id 56BF039EA for ; Thu, 27 Oct 2016 13:09:07 +0200 (CEST) Received: from BN6PR03CA0061.namprd03.prod.outlook.com (10.173.137.23) by BLUPR0301MB1617.namprd03.prod.outlook.com (10.162.214.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12; Thu, 27 Oct 2016 11:09:05 +0000 Received: from BL2FFO11FD029.protection.gbl (2a01:111:f400:7c09::196) by BN6PR03CA0061.outlook.office365.com (2603:10b6:404:4c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12 via Frontend Transport; Thu, 27 Oct 2016 11:09:04 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD029.mail.protection.outlook.com (10.173.160.69) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.679.5 via Frontend Transport; Thu, 27 Oct 2016 11:09:04 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u9RB916d009009; Thu, 27 Oct 2016 04:09:02 -0700 To: Thomas Monjalon References: <1477486817-1284-1-git-send-email-shreyansh.jain@nxp.com> <1477552109-18624-1-git-send-email-shreyansh.jain@nxp.com> <6056365.vs23AthqBz@xps13> From: Shreyansh Jain Message-ID: <14b3e839-adaa-24c2-e132-6c2c1fee8956@nxp.com> Date: Thu, 27 Oct 2016 16:40:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <6056365.vs23AthqBz@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131220401448395113; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(24454002)(189002)(377424004)(377454003)(50466002)(104016004)(15395725005)(305945005)(97736004)(356003)(230700001)(4001350100001)(189998001)(54356999)(77096005)(2950100002)(76176999)(110136003)(8936002)(6916009)(87936001)(7846002)(4326007)(85426001)(4001150100001)(11100500001)(83506001)(106466001)(81166006)(105606002)(81156014)(8676002)(86362001)(31686004)(31696002)(92566002)(6666003)(19580395003)(5890100001)(23746002)(65806001)(68736007)(2906002)(36756003)(65826007)(5660300001)(626004)(15975445007)(64126003)(50986999)(65956001)(33646002)(47776003)(586003)(19580405001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0301MB1617; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD029; 1:8rGSWwpHy1FGUOanxvPD6vPS4LrBX+wrW1KaERrX0tCYySMu4Hm9G5fDx2PZlZ/iYeQtrXDE2endgzAzwUsvF4Zzjp8ilIalnZ/xkfKsw31Oi4tYB5pyo06K6dvRFdp107QdIzBZvH+Tmrx+GdBrhPNTZ2YWpYad0QPn0vtK8f81SmBxUyVMEIkAM60Opw1lDFzOcWSJxNW/pm3/GvlfenKMkfSrzN3zs8KJ82RTwlTTYlKtqMS+sSGijB/WYGSVG7WXTZcVQqmsNF+E/Uz8GxtkCTHMPjmrRzKSRyn6TcurTzzwga8137qOSLl0mKSdQmbuka/z4nwWeiCDAvMxs01ithc0mPiTg11DCtNxzEjfL5wGxNVOnBF7h3qr7zRBhUeV9U+C26XxIo7PMHv2TB3j5wZNy7gO4rhLpK7roVhYSeSwOQa+qt2zrivd7UW7s5JoQhqDoH+qyFCK1Nk+cUNAXgMCP0T0/6OCyY0arRgqMN/wzlYZxt/Pl0HRXT+CiqyyyKYHertXwofsV1ZFkxwSvOafAk3coitYt0dBxnmONAlGeSAVx2NMMJdGr+S66+BeAU470CSCO0htwuJX/3yHneV9Vdk6nyHhMizXvCi5Kxl+6RkjIYrkRi0qY6c/Ye5HBpv+BAZ9Kv5wjfU3PQ== X-MS-Office365-Filtering-Correlation-Id: 769dc614-a812-4040-4008-08d3fe59aa12 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1617; 2:h/9w5hsmynTwPjakRIF+qGfTj5YPWWxj4dfSumKRAy67+hZYatHHO3vg2vbEA6ZhegtNO1ygmMFtDwKrMZ8AsH1yZp2n3Ff6IjRjj/WiWKdYAO2+GvnpyfeOrg4sWaE01L7HztmesXP4zGugfPCOS+hWheh5WJYzll1PMVXpozWxkPa71mLHjABdANSsU6DPLQaut6lVhUaz5CuCyYw+wg==; 3:ipgIkVqQLLacHDtp8UDFNSTQXt7EAfyREVeYI57m0cl8rOVd1zPgBCt2/zeYK2o4b+EWztX8L5WDMy/2lycxmPLeQyiuKvhCDNRE7dj0tOeDAguqQnczw57ijQYZ/4BsbvhuVt22gGKQIdiN/YiBQrLs41ccK12kfdlUN/LBkR6r9HPC+2G3Q/T6rY3xX3ImQmSdZBKjd7UMXZacDuTI4ICSeggeD0sriEhI6wXDNNcZTCc0D2hq9aJEbEMylItZ; 25:EMmqK003NW+ZA+JS6E8RZKdS15OQe5A1KDCBDX8a6ocjHZ9942GhYUeOZEtRVWjayTCz5RHZMWSeA2iEoiPQ7+todJT8Z0845dCgSrL+b8qx7gkSU42mlKKL+IDRCjf6MZDzEqfvKakNZRmvJfXgdFdIL23hCSbiKaRSxDiOsCCyudMewxUawkL2W4ydbaqgWBbi4zplqmaR95opHjMPYJvCdTLGlFaHLgMZdCRLXQCJk62HuzFHAlrEL9ONkGvEXZgG4uFaHpgSrEaWdNBosWhSMQTtwsDIB8drQKqS/myq6yj00OSJhta0eRqF0OKC21ThYpXLVz6GElqRwPXNbx/nl/bkmk4c8i0Qjxx4cdCD0YCywz8GNllN9BCBDuJI1rMaYfEWDEIjFdpBRyYwmVOWps/VGAXHAd68JxVFAXHtVZqFX3dZHjrGaWMLjwbkYGLHRf1XwsUCvWUiQ4/wqw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB1617; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1617; 31:HxSSnhiCvRFtBZyHu1MK/IA6P9lCGxKnn8axPOAJGttpAwTS2+oQdU/1Ww1PT1cdSNB/0ofAJCj/OppSape8O1LF4Pv5bjnY6bVD60GWjvEnnUXXbOUbMV/mun6u/w/ZrmUZrtADKVyB64NSAkwClM1E1uimUQJJQoTx4+JEOLhvVP/vB0ofUI2wLRczzTU/Fmc2V42vH/hTcaqsZdRSN7Wniy0M9Zqu5qHnGvuPLgjjGLu33uPEZIc1TpvNpgCTbz/QASirPoH3gekCmJwvoM4lGsE/39ufiAQ9lPxGrdI=; 4:6nzX5O4adNHl6k7x1cboFNTzpMsjzbbms3ba2r+NWvM94yhaAtMTHESXb58/xYhbj0c5TMYJFdSCfKL2wBb2FL3DaepZ98oMEY2HuFjCfeJgqAi/iQUg+lj6RXSVLQsHX2GgEj10ygv0ROizviKnY/ChHqm9Ts7Jml2N5B4LFH0+T2Er8m/CrA6OAutdrZkPY1xEqfUJzO5qBNXtmfqJ2PZ9HNGq/bIjIqPu4P85Npj+uE7k16Gec4sqyU5iZfw/IV7z2skTe800tg4JVDUhonkkxoOZayRJuDRRlHymF1WlXl6ffIZHqKbD2RzXT719p59C6movxjBPYWluOAr8+QALTR851UfUM9QEwahDN24Oe8tDxei6wEJ4pXvAzsKOqH4kuYPgesxoWevanonMc8/8Iw8AkFhWwaz3uspooj5AUDxW4LA9BaD2oQ7HA67IARY3CVxlBz/BLcDG4XZ0yvqn/UyaMEP5VVikP/JNE9A/pmXxOp1lYoJGfJaoaubYRKU1I3cosua9MkAyByjZfdO0GM1B14aqG9fdKYOSA+KDA4fx9Sdoxvn4mDesnDv4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13018025)(13024025)(13015025)(13017025)(13023025)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:BLUPR0301MB1617; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR0301MB1617; X-Forefront-PRVS: 0108A997B2 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR0301MB1617; 23:lGDipXrkNQhgcCnmfU5Pf/DdrW9PTpky3bE?= =?Windows-1252?Q?XeaQ1FwSDazSyOhdcwybh6TpsvKSfsNJy07cFQB66fp/YqJj1mzHpq1e?= =?Windows-1252?Q?F2Yg03VfySnX9JMu70XquLXiksTqxb6B8/Z4JCCt8J42ZeVUTKCynbLL?= =?Windows-1252?Q?BiBWezly9f1WDW8Nm4iWOVlclnmlEfhikIjGRzCw+xvkbyQBD0nT8JT7?= =?Windows-1252?Q?wm+9itBersGOOerbAbjUMjFL+WwwojXeru2HF+5lDZYkZPuwIM0dTaQN?= =?Windows-1252?Q?NsUrpI2Egs87fpxcH3w6d+mobWwq3X5hIeyKoRdU3Ah5Tf0lLsNIK83s?= =?Windows-1252?Q?j97LFeLJmCttkUNf9i6VIBrDJQ8b1QY0kR2ChUn93W88kqp1XG80heBm?= =?Windows-1252?Q?w67koBX0nHVrGoVyEDWbiu4BwgFKB6rh9u57/qVBIvnTPWs4drFu65s/?= =?Windows-1252?Q?VvIQenKvsIlL+hLyiE+4G/y+AiXyF8sf+97ZwXUdyJ/sqKnLytEyRUdC?= =?Windows-1252?Q?K3mezUjAkc0oayV4rEqdSGgOt4EJS8GbmIvOKtRfGjub5wWXfWhZljk9?= =?Windows-1252?Q?Fo45E9bmdY1FJ869lR/rouJTJcMqV8WtOxgSq8yp+4YaPhdgmvsRwHsw?= =?Windows-1252?Q?sLf2Jadc/XVdAKgkYeB/fWGrlxraf/O40+R3qgqy5ggoNel+Vu3OaWjC?= =?Windows-1252?Q?r9XGi7Mi2sh1EbrSxmCbiBfos90fE0+6YR5RIsNcqc5n1n5NWaZmMSVn?= =?Windows-1252?Q?fIoM2z/hxMc6xlM7kxM5UaweDYJNlSHrFoczkuIWpreJDWVTlpUPaTU7?= =?Windows-1252?Q?zCu5jZqleaRN2Pj2mhV8K2J0+GTf4MV2lVbDKuAsrz0pCf04BZKqpLIC?= =?Windows-1252?Q?DSHEfeRDnDp/1b0xUGu1d8ZQINLXsT2MPuYTjzElFmMXMwN/Wi2G2Mlt?= =?Windows-1252?Q?IdxL3vRKyhMy8FcAh5w0vmsUHCIVHugTjcU2dYdE8xGe80ZIFd3dn7RA?= =?Windows-1252?Q?YMqMC0Wgqwrb24j6VMuDDcfiMT/eOXr1KnL6tb5zZj1EqpcgqSsHUn1m?= =?Windows-1252?Q?M0zVTAmhrfQ4jN6lHR1jgHc/41O6ReYkj+bBoHKuzOW6EjAWGVJn02+T?= =?Windows-1252?Q?Td6rG0kvrWgumDFF6oVFEjZhvSGAiKN4kcR7gG7LCz34CTjHSHtKyEeR?= =?Windows-1252?Q?ADlrM7tBd2N4gRVifxMxxi/333NOKx4xfdY4vDhson+ZfrHzKL+5EgK/?= =?Windows-1252?Q?Hx045FIjDW2YNqeUZZmtnIvygTqzv4N9dKwkIgW7rz0/rjEOI9voquFA?= =?Windows-1252?Q?Ckz0CjIlaIDn7ph088NrwwT4kRtSbIh6T9qxPF2xKW9IBd8ZGcktMTbA?= =?Windows-1252?Q?WgtIV2D5wWcvkbmaceVys0ucbIGBS4rgdE+tAwKFIKXwoHcAz35Z+okN?= =?Windows-1252?Q?CoQrPvCA/PmCSxed2Dd8ZgUyWJfPpIbqKnV2jPpBcbDdenJDebvPc5Ti?= =?Windows-1252?Q?IQfoMpMcmPGEt9V/Qwt9HZx9iGXwWarwblEJc0/ju+bpTEqAouNmuYkx?= =?Windows-1252?Q?+OsTrdUKAf8MA4p1SixZn/Zj+3nuR1GBqU0PXmk44r5YarmTW2C2/SWd?= =?Windows-1252?Q?rzlxUAkZ4xscDs6P8SK/MomYGeAvlqHa8BCjYwUTxOcGDJAqtCqRKz4g?= =?Windows-1252?Q?3tgZIgAO9o9bhhM64/HkGbLQg9qKwtt5eJAF+N+6riaect4pBIvmY?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1617; 6:LXLT89QgKTBY6rDK1TSE31VppsXESVGDfvuwp/7L6rt0YCaEdvA8KZDqYHWc8l3FLjHnXPGhfI8OGlWacAVkpwnmfxoia3WkdpAGCxZ7pUXZKCQxw8C6FiNvRhudnMcCo0aIz3AVGkVLW5W3SgwNOu9kzeBJrfSFRok1jkhArSY0K/wEWgwPhhCBvvpYqTjB24TFtkFoGvjk2GW5OcdfP+HXv8doskqC1aRVSUKR9ChPPctrt8Pc0wY/JxuJHZGlJHCcSiA6zgP8vxdvZU1a4RCbEXZlClhlEg/LnVaUd1ENiArVP47EU9dLq/F7Ru/L; 5:RwX32jC17QGIp+bK56MrubiYo4q6Q72gclEBKou8SP+qSHu3jzYmWv/Ta8L4flDN+bYDDoa1pelbTGjiyYFq8vNohYZFTid64xk44rfb7GwOdLOypDt9MIuxPJsHI1Qph+Cfni7vIoWlnzGkIfK/1GbGJEu4a8EFF2KiHQwEXw4A7RX556RktKsf6T8Qxau7; 24:tXeSAaZd//wnpbSQXtx6AaFfYOd+T7Ov7leyQqowRSVB7f9a+2rUNdHccwECrXh+FG1c9jJE7HYLW4zALcOb19aBdsRYwswaCx/yE3YnUUg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1617; 7:OsBzfTkohBRRHfvuA32KuzdRAOy+9cUYZT0dfSGoSoJLr3GRqJaRA4fksgdAVSfYrO/ZVMTToaTG3IN+SdYgReo44ipfkVZqXjTw/GMuEyP455AL3LU/I5T8WPQa0CQDn6b45mmNntT0421ZB3mPvz1ItTI+xhGQrI7rJe/y7mX1zbwDG6ViG17Dj86PYdnkiVVIRxRypoP/jW7a2AY0RouCp0LZU9pR94ETd5nye55YY4lrKRxUrSHFhleBKjiVqpYa18hP4FrTDhxeXKrwl1br2XQcmv+d2+/83sWNzAejJNQzK0bs+xC1UNIcbsAEqun9Y6O0bPGR1SaYl+hFsOKGZCQSs/WVR3bxgX1mTxk= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2016 11:09:04.6523 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB1617 Cc: dev@dpdk.org, ferruh.yigit@intel.com Subject: Re: [dpdk-dev] [PATCH v3] eal: fix libabi macro for device generalization patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 11:09:07 -0000 Hello Thomas, On Thursday 27 October 2016 03:45 PM, Thomas Monjalon wrote: > 2016-10-27 12:38, Shreyansh Jain: >> rte_device/driver generalization patches [1] were merged without a change >> in the LIBABIVER macro. This patches bumps the macro of affected libs. > > It is not a macro but a Makefile variable. Yes, I will change that. > >> (librte_eal was already bumped; libcryptodev and libetherdev have been >> bumped). > > Please provide the commit id where EAL was bumped. Ok. Will do. > >> Details of ABI/API changes: >> - EAL (version not bumped) > > not bumped -> already bumped Ok. > >> |- type field was removed from rte_driver >> |- rte_pci_device now embeds rte_device >> |- rte_pci_resource renamed to rte_mem_resource >> |- numa_node and devargs of rte_pci_driver is moved to rte_driver >> |- APIs for device hotplug (attach/detach) moved into EAL >> |- API rte_eal_pci_device_name added for PCI device naming >> |- vdev registration API introduced (rte_eal_vdrv_register, >> | rte_eal_vdrv_unregister >> >> - librte_crypto (v 1=>2) >> |- removed rte_cryptodev_create_unique_device_name API >> |- moved device naming to EAL >> >> - librte_ethdev (v 4=>5) >> |- rte_eth_dev_type is removed >> |- removed dev_type from rte_eth_dev_allocate API >> |- removed API rte_eth_dev_get_device_type >> |- removed API rte_eth_dev_get_addr_by_port >> |- removed API rte_eth_dev_get_port_by_addr >> |- removed rte_cryptodev_create_unique_device_name API >> |- moved device naming to EAL >> >> Also, deprecation notice from 16.07 has been removed and release notes for >> 16.11 added. >> >> [1] http://dpdk.org/ml/archives/dev/2016-September/047087.html >> >> Signed-off-by: Shreyansh Jain > [...] >> --- a/doc/guides/rel_notes/release_16_11.rst >> +++ b/doc/guides/rel_notes/release_16_11.rst >> @@ -149,6 +149,32 @@ Resolved Issues > > It is the "Resolved Issues" section. > Please move in the "API Changes" section. Ok. > >> EAL >> ~~~ >> >> +* **Improved device/driver heirarchy and generalized hotplugging** > > typo: hierarchy Yes. > >> + Device and driver relationship has been restructured by introducing generic >> + classes. This paves way for having PCI, VDEV and other device types as >> + just instantiated objects rather than classes in themselves. Hotplugging too >> + has been generalized into EAL so that ethernet or crypto devices can use the >> + common infrastructure. >> + >> + * removed ``pmd_type`` as way of segragation of devices >> + * moved ``numa_node`` and ``devargs`` into ``rte_driver`` from >> + ``rte_pci_driver``. These can now be used by any instantiated object of >> + ``rte_driver``. >> + * added ``rte_device`` class and all PCI and VDEV devices inherit from it >> + * renamed devinit/devuninit handlers to probe/remove to make it more >> + semantically correct with respect to device<=>driver relationship >> + * moved hotplugging support to EAL. Hereafter, PCI and vdev can use the >> + APIs ``rte_eal_dev_attach`` and ``rte_eal_dev_detach``. >> + * helpers and support macros have been renamed to make them more synonymous >> + with their device types >> + (e.g. ``PMD_REGISTER_DRIVER`` => ``DRIVER_REGISTER_PCI``) > > It is RTE_PMD_REGISTER_PCI It seems my Friday is earlier than usual :( I was the one who changed it and I completely forgot about it. > >> + * Device naming functions have been generalized from ethdev and cryptodev >> + to EAL. ``rte_eal_pci_device_name`` has been introduced for obtaining >> + unique device name from PCI Domain-BDF description. >> + * Virtual device registration APIs have been added: ``rte_eal_vdrv_register`` >> + and ``rte_eal_vdrv_unregister``. > > Thanks > I am sending v4 soon. - Shreyansh