From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 185FFA0C46; Tue, 14 Sep 2021 13:07:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02A5F4068F; Tue, 14 Sep 2021 13:07:54 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 2D6BB4003C for <dev@dpdk.org>; Tue, 14 Sep 2021 13:07:52 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10106"; a="218783118" X-IronPort-AV: E=Sophos;i="5.85,292,1624345200"; d="scan'208";a="218783118" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2021 04:07:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,292,1624345200"; d="scan'208";a="699440937" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga005.fm.intel.com with ESMTP; 14 Sep 2021 04:07:50 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 14 Sep 2021 04:07:49 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 14 Sep 2021 04:07:49 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 14 Sep 2021 04:07:49 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 14 Sep 2021 04:07:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k4erfQWoiFsk5ZIcM5HVOBSzMhiaKjKF6SpZ+rIqWHgfd5QjiVhO6Ucs5LBcCG7GDb+Coi/IF40yzKReIMy8RSPwurtI/XpDkChHHmwSnDkyfxO/LAiuH3QXYsW7WdKptYMrl03IBvkasiSgAe0ifPqdvwASPlvK/QwT7KG8QD/ufMYaBX+C5NFntknbZZpj/kqqFMa42r3/jIrtfQThV44R2UFSQwBa6Pb4gH2q5hd64GztO+vgUde1VmS3n62PmwNt5BmUxxlrq5mE5E6bBhb1FtcXPx1xMheyTysPD2/10M1nl4lkx9tYciJi0J+/gq++s3Jygaxom7owkkHlzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HVOJJxh9D1fEwpOHd9LlQW+/iA/au8JXcwP3/FxAb2Q=; b=TPFaQNFjCea8UiMWnegDE8dkyJ2AwWAMmeiJbOEUBWLIjyh7vxD6Q5N41bmyLWXpDdiBT8msXzO1fNEFf9a3mhqfDxbrJRFMAxWG9DOOH0QTrqivd+c/z8SuUZH4N5m0JiYusAaVYekcRd5LpelQKwNiPf14uAZsUcVqMWSrHKFKo4LTf6vQLZYEx/4QqD4Vp0z7F73DPtsSV6q3ADuvGCizelGogqWSVDLil/1el2YlqNg61PEvC4GsWz33Wh3KF5QaTctlUsvUEhlmLKwmXUmZjauDUVyqL70r/egBLt6/A3KGIrKcL2BnZ5PGZ++E2CyWZ5r24AzppfN/m9sXRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HVOJJxh9D1fEwpOHd9LlQW+/iA/au8JXcwP3/FxAb2Q=; b=qz9sNiePC2Qe5lk/BAROr7gdSFSWFEL1yWplpb1bnrBGPXyWi/FdsrdsOQAtzWipjklQ6gfQtVvsL9c80nCm66G/BhRLPtHbapFTnrEpWQoW3GhZbjg8k3T4QUSr89XrKyDTl9R1Olwo0YnFnWrgB6IfdpfaZs5dsFJqo+XWWhU= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) by PH0PR11MB4822.namprd11.prod.outlook.com (2603:10b6:510:39::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 14 Sep 2021 11:07:40 +0000 Received: from PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::513:57f8:360:23fc]) by PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::513:57f8:360:23fc%8]) with mapi id 15.20.4500.018; Tue, 14 Sep 2021 11:07:40 +0000 To: David Marchand <david.marchand@redhat.com> CC: Thomas Monjalon <thomas@monjalon.net>, Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org> References: <20210909134511.18871-1-david.hunt@intel.com> <YTsPP8k65UQEqxrk@bricha3-MOBL.ger.corp.intel.com> <CAJFAV8wTCpp907i3=-ZLjJJbcvE4_Rk0KPcMfL1JrhC1qL-T_Q@mail.gmail.com> <5148108.61zlV0aQVf@thomas> <c3dcde16-bc4f-206b-2fda-8caf606c8d24@intel.com> <CAJFAV8zk6DKFMmPZo0QbzngFfhDGvpVMJjz2vyKi_XyrgK-zMw@mail.gmail.com> From: David Hunt <david.hunt@intel.com> Message-ID: <14b789de-9279-c2bb-6140-595606462970@intel.com> Date: Tue, 14 Sep 2021 12:07:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <CAJFAV8zk6DKFMmPZo0QbzngFfhDGvpVMJjz2vyKi_XyrgK-zMw@mail.gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: DB6PR0202CA0034.eurprd02.prod.outlook.com (2603:10a6:4:a5::20) To PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) MIME-Version: 1.0 Received: from [10.4.11.161] (95.45.23.115) by DB6PR0202CA0034.eurprd02.prod.outlook.com (2603:10a6:4:a5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 14 Sep 2021 11:07:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 350486bf-1664-45f3-c086-08d9776fddfd X-MS-TrafficTypeDiagnostic: PH0PR11MB4822: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <PH0PR11MB48225FA2CD132A1387D6BFF898DA9@PH0PR11MB4822.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aSTqsPMFv6O8z7SHXybv7+LMBWxXdGHN1cRVpWaLDuU8Qk3Z0eLtsR8gi23e9gC+77UgxJ+XdgS5l9YhmGj94urczBb5DBsZ4x3w7PLqN0HfKdoUQ3UKSaBznSU/8JZ90CjBmxVHYCW84GJjINHTM5ryZmbDDgxVTr9KFApbzBFHR/ccYOZOAwLToyN3sgIn2//0eMtKLHbctU9fF/RDv2eXqyZW2dDeRoyA05tVIf0veHifbPW5JaEVFgY5I3YV/zb0Be3+z6ppYcQKA9l1JT/h7KebWdZxk0P8cOZe06NQGkU4HROQGeXc6KbpfFI6lEgkLaYNeQZe0dcTroPco1fVSG0ybWT5bDYzRbtMgc6zwNlhMlj2SS8JPf5aC7u4NnhkuhIlEdJTr4Fu+lQwYL2c2V8cydsSuIbT6qZBvDBbsJcAH64nAlX9aIwXmOYCFNQboLtt29bHOSDW36S8OZTFAcMAFg7W7xgPvX7E+e+RuBjUlIwZU8bdse4ykkMjZiUoeBYQUiYiT73i3p/PC5OI8RkGNhRLSA7/ZBvsJ0rbQ27Y+vZIjRGcVLVvLAMJsh73jaBt4ra6DPky/C/hDjsn1xmBhermmQiAJduVrkKIJ30PknNnLdB5Cpqgt+sZa1XceFQvmAwrpoYgsuFo3TgB25eIGNNYHo3g74jRvbAvcQMFBzvdjIXB3kar6wNd4pcHTaFJg2fi+OfM8YSQdMWK4GfrZNc3b21JuGEgek9C+w2Xr8yv0kC8TWVt/AZs X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5047.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(39860400002)(376002)(366004)(136003)(31696002)(54906003)(44832011)(38100700002)(316002)(86362001)(186003)(83380400001)(6666004)(5660300002)(478600001)(36756003)(53546011)(31686004)(26005)(8676002)(6486002)(956004)(66476007)(66556008)(66946007)(6916009)(16576012)(2616005)(8936002)(2906002)(4326008)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3JGQ2VjVG5CdjFYczR2Wk0wTjFlVm1sQTRyeDhJRCs4WWxmaVBOY08vL0xy?= =?utf-8?B?MUI1OVRvNlM5emR2am1obHZTL0xCZndwaGoyQXp3QXd5TzJrZnBIRi91ZVNG?= =?utf-8?B?Q284Z0VzdDZUd3k2OXdURkp6a3A5VFMvNWJia0lIeFhUTU95TTU0ZTlIcTJW?= =?utf-8?B?K0lITjZrU3I1ekE2ZWpNeFc4VndPUkV3VmgybEFQdmRBQmdQUWE4NFkxQ0cv?= =?utf-8?B?WTZobExOZUYvSW5QVUlDdWNOTHlIYzZTT1RNZjN3dVZXRlZOak4vSW5iN0VP?= =?utf-8?B?a3p0MGVYaWRYUmowRHF4YThodHFaYWxPWHVHa05uRlg5YzI2dDJXcTFvTGNS?= =?utf-8?B?citZYXZUOTBCTVprMmFsN2hHWHhpdHh5cHpuazNqYllrSTlpc0NzZ3NVUkRY?= =?utf-8?B?dDlpRW5sWjRuc3FHU3M2OFRSeDZ3eWhLUG42ZnlTd1JLUi9PNHFDNW95RXlU?= =?utf-8?B?cU1YQU1QSVBpNWRlbFpLSWlLOXJpc3NPVlRvVW5GM2ZUc0U2RFJDYnhHdTJ1?= =?utf-8?B?U1JZYm1lZEl1Nkcwdjhzc2JiWmh4MXlidHFGMlFHRHlmVitSUHhaVngrZW5w?= =?utf-8?B?REJSaEVGSzl1cjFXTU5pRE9oNFhxTVpsSzlBdCtHaFBnV3hqN2o1V3Q0MWpZ?= =?utf-8?B?RHU2WjUwK1NFcTFyUWFhS1pVYTQxN1RjNSs4NkxJTC9ZQ0FnZFpDVjM3L01W?= =?utf-8?B?Y0E0dVE2SytKTnRXVkdkbk1aNzUxTHRaR1E0WHpybkxneE1sWmRRQWlyelFG?= =?utf-8?B?aUNaVUdkWGErNWl0em9XY3JObnZZQnpQZWR5L3duMzhJWWdSMGZHUUl1SmNx?= =?utf-8?B?OGd5VFQvcEJKalpkNXhYcEx6U2d5UFN4ZGQ2OXVqQTBRNi82bjdTL1pneU4w?= =?utf-8?B?dHI4QnNId2hDbUorU1VhYUNXaHoxcjlhOEtWSE9WRWw3K0Rpb0JaSWhjTThH?= =?utf-8?B?U1lyMjErSmFsV0ZPd3VIWFB5ZG9VdFBoNFZ5U01iRFNIeVkvb0NzM213ak5G?= =?utf-8?B?NlNnekpDTjNXU0tqSU1uaVA1cWJKY2tRVjVxbkZTU1lGaWoxMDJ1TnJXWmc1?= =?utf-8?B?ejBnVUQ5VGplOXl6ZitsRkJjNXlPRTg5c1RwMW1BQ01pbDQ1ZnMwdUs5cHk3?= =?utf-8?B?RUNxcktUR1FaekZqN3NKNmt3ck5vekI1WGZUL2RsYlZxOUZCS1pUSm1BbDg2?= =?utf-8?B?bUk5YjdxZGZQcUlpVHNIbzE4RFlEZmUzTTdMMFByLzg1S0Y5R3A5ODBWcnM1?= =?utf-8?B?UTdTWXBTZ3pQUHNrR3RUd2sxSGRzc1Y5RFNRTHFSQ09VYzRhZzh4SWJQelg4?= =?utf-8?B?YXk5dGw4Sys1Qm9qNzRzd1p0MkFwMDZGWUx0SHNPNXRLRHhUc1RoL3l0L2N0?= =?utf-8?B?d1ZCZExvODlqNlBFQk5yVW1vZDFOdFFYak9uT3FCWGFmNWVxMEd6cGFEcWR5?= =?utf-8?B?eDBRdklHejJ2bTZpQk4yQW5GRnJKWDZKbFk3c0tKMlVPbmlSdGJVZGNPcXhW?= =?utf-8?B?aEJ6ODJPZU5YY1hFSEZxdFR1cEYxdXRNZExpcEV5emxBOWZaVHFFaVdLdW9T?= =?utf-8?B?N2luditKN3krNTJ4bFRKamovYjBZOHdqVlVwMlRIeXEzVXZicDN2N0JaYzU3?= =?utf-8?B?RG1SRXhpbGZTVlZDaXlNZXQrZTFnRUFObDc3K0E5U1VOdVJWRDg0WEtDakNG?= =?utf-8?B?RTdPL1V4UUpkWDZYcWFvVlE5ZzJTYmR0bFZKV3loT1drNzdMeFMzTGFjeVFP?= =?utf-8?Q?kPvWDTeXQrkQu29JsS0hLE2GMoqukA5O/xB+DJP?= X-MS-Exchange-CrossTenant-Network-Message-Id: 350486bf-1664-45f3-c086-08d9776fddfd X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2021 11:07:40.0260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B6wHZBralZtj7kE5rNuIwK/R8UNvds/N6y/3Yxi3eEdGmj7SeAbBVNzbxi8O8+QJKAzdTY1OMDXdA89hMtSwfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4822 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 14/9/2021 11:00 AM, David Marchand wrote: > On Tue, Sep 14, 2021 at 11:34 AM David Hunt <david.hunt@intel.com> wrote: >> >> On 10/9/2021 9:24 AM, Thomas Monjalon wrote: >>> 10/09/2021 10:06, David Marchand: >>>> On Fri, Sep 10, 2021 at 9:54 AM Bruce Richardson >>>> <bruce.richardson@intel.com> wrote: >>>>> On Fri, Sep 10, 2021 at 08:51:04AM +0200, David Marchand wrote: >>>>>> On Thu, Sep 9, 2021 at 4:38 PM Bruce Richardson >>>>>> <bruce.richardson@intel.com> wrote: >>>>>>> On Thu, Sep 09, 2021 at 02:45:06PM +0100, David Hunt wrote: >>>>>>>> Modern processors are coming with an ever increasing number of cores, >>>>>>>> and 128 does not seem like a sensible max limit any more, especially >>>>>>>> when you consider multi-socket systems with Hyper-Threading enabled. >>>>>>>> >>>>>>>> This patch increases max_lcores default from 128 to 512. >>>>>>>> >>>>>>>> Signed-off-by: David Hunt <david.hunt@intel.com> >>>>>> Why should we need this? >>>>>> >>>>>> --lcores makes it possible to pin 128 lcores to any physical core on >>>>>> your system. >>>>>> And for applications that have their own thread management, they can >>>>>> pin thread, then use rte_thread_register. >>>>>> >>>>>> Do you have applications that require more than 128 lcores? >>>>>> >>>>> The trouble is that using the --lcores syntax for mapping high core numbers >>>>> to low lcore ids is much more awkward to use. Every case of DPDK use I've >>>>> seen uses -c with a coremask, or -l with just giving a few core numbers on >>>>> it. This simple scheme won't work with core numbers greater than 128, and >>>>> there are already systems available with more than that number of cores. >>>>> >>>>> Apart from the memory footprint issues - which this patch is already making >>>>> a good start in addressing, why would we not increase the default >>>>> max_lcores to that seen on real systems? >>>> The memory footprint is a major issue to me, and reserving all those >>>> lcores won't be needed in any system. >>>> We will also have to decide on a "640k ought to be enough" value to >>>> avoid ABI issue with the next processor that comes out and has more >>>> than 512 cores. >>>> >>>> Could we wire the -c / -l options to --lcores behavior ? >>>> It breaks the 1:1 lcore/physical core assumption, but it solves your >>>> usability issue. >>> Why would we change existing options while we already have an option >>> (--lcores) which solves the issue above? >>> I think the only issue is to educate users. >>> Is there something to improve in the documentation? >>> >> Hi all, >> I agree that it’s a good idea to switch to using the “--lcrores” option > Let's avoid typo in the error message you'll add :-). > > >> for cores above the default, that’s already future proofed. >> However, I’m still a little concerned about usability, if our users are >> accustomed to the “-c” and “-l” options, I suggest that we add a warning >> to suggest using the “--lcores” option if any of the cores provided on >> the command line are above RTE_MAX_LCORE. That would help them with the >> solution to using physical cores above 128 (or whatever the compiled >> default is). >> >> Example: >> >> “ERROR: logical core 212 is above the maximum lcore number permitted. >> Please use the --lcores option to map lcores onto physical cores, e.g. >> --lcores="(0-3)@(212-215).” > If you could directly provide the right --lcores syntax based on what > user provided with -c or -l, it would be even better. > This should be not that difficult. Agreed. I now have something working that when given "-l 12-16,130,132", will output the following: EAL: One of the 7 cores provided exceeds RTE_MAX_LCORE (128) EAL: Please use --lcores instead, e.g. --lcores "(0-6)@(12-16,130,132)" So you can just cut-and-paste that option into your command line. Makes it very easy for users to migrate. > >> I’ll replace the first patch in the set with a patch that adds the >> additional information in the error message. > >