From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 989A2DE3 for ; Fri, 27 Jan 2017 16:35:41 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id r126so122352502wmr.0 for ; Fri, 27 Jan 2017 07:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=Clu8+xn/7GVSq7CSRpJO59MJFUPJDXpEV9Yst5BI4aU=; b=VAFw6LTuZrCZ7+TUnUSCeZhPOiB2CKKrgliikTGvjL/HJSsJhHB+PEBKnqygcrRbVW z8ziVWOT92uRKvP8dCgkNDcs0zC3gLw51tcsaoqcx5+6p0V/c/ZRIkeTZZbr92FwyfSQ S8sp7LTmU2X65eJnHWWQfxe9en8ypKm12qml/rGib/bJZd+sHMS1TyF4EjjZVcABWRzi cLK0jWoSq/tkQR+72gdr6X/v6Cb53M+rc5YuNgNTgX2iDmKJC3cz5Zf7eV67hfbwcv9o BNuFL23Utk0L/80vZkA4lTA2DWb5v/yZIWvcYUsmJbvnUCRJv0f/IB/grOteRyZQphf1 HpQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Clu8+xn/7GVSq7CSRpJO59MJFUPJDXpEV9Yst5BI4aU=; b=q4fS1e/NsqZ89cxJnaBCIfI6pRzJZQtiLb3dsIxn/Nt0ItRk5zm/AVPGUgWrU+nwye SYu98bvEmhrj6WAX26AKHTCeQHaMN/egCJmsNMmigi2sk89oeuIxVwp7iRRVG2unGi5S nBybpy60U4/R1LIcJiewSxx3Dwykue5IJA4CoarCFYttlV2wEXUJb/suV4745vNXO+39 L++0wIBByicaBCngwk6P9gpBSitR3PO+pxy8TicKWHvbaHM4ymvN4U+UvqRLl+cjJqof VunEw1OOi2X5+dwVP2Gfn+aJCnIXotFb2J8DfRwEQRwR+TLL56kYAfco+5gjdQJDvdKX 9lEw== X-Gm-Message-State: AIkVDXJQ4uqJhmuTPxp1sAgau0p8/YmAp2RwzO52AVQ43CYaDqXZ0sYND5LzzV7+YnC1KN8j X-Received: by 10.28.94.8 with SMTP id s8mr3416507wmb.117.1485531340936; Fri, 27 Jan 2017 07:35:40 -0800 (PST) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 1sm4454502wmz.2.2017.01.27.07.35.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 Jan 2017 07:35:40 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org Cc: adrien.mazarguil@6wind.com Date: Fri, 27 Jan 2017 16:35:19 +0100 Message-Id: <14d8b56747b084c62ed4ff8b525165282803fd95.1485531240.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: fix VLAN validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 15:35:41 -0000 TCI field is read from the wrong place due to an invalid cast. Moreover there is no need to limit matching to VID since PCP and DEI bits can be matched as well. Fixes: 12475fb203ad ("net/mlx5: support VLAN flow item") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 7b97a61..d805c0a 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -410,17 +410,6 @@ priv_flow_validate(struct priv *priv, if (items->type == RTE_FLOW_ITEM_TYPE_VOID) continue; - /* Handle special situation for VLAN. */ - if (items->type == RTE_FLOW_ITEM_TYPE_VLAN) { - if (((const struct rte_flow_item_vlan *)items)->tci > - ETHER_MAX_VLAN_ID) { - rte_flow_error_set(error, ENOTSUP, - RTE_FLOW_ERROR_TYPE_ITEM, - items, - "wrong VLAN id value"); - return -rte_errno; - } - } for (i = 0; cur_item->items && cur_item->items[i] != RTE_FLOW_ITEM_TYPE_END; -- 2.1.4