From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 022912BA9 for ; Mon, 4 Jul 2016 15:24:11 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 04 Jul 2016 06:24:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,574,1459839600"; d="scan'208";a="1010668701" Received: from kbinias-mobl1.ger.corp.intel.com (HELO [10.252.12.118]) ([10.252.12.118]) by orsmga002.jf.intel.com with ESMTP; 04 Jul 2016 06:24:08 -0700 To: Zyta Szpak , thomas.monjalon@6wind.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, jerin.jacob@caviumnetworks.com, rahul.lakkireddy@chelsio.com References: <1466688410-13826-1-git-send-email-zr@semihalf.com> <1467632207-13809-1-git-send-email-zr@semihalf.com> Cc: dev@dpdk.org From: Remy Horton Organization: Intel Shannon Limited Message-ID: <14eca081-0333-53f8-eb7c-1aa89c44df56@intel.com> Date: Mon, 4 Jul 2016 14:24:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1467632207-13809-1-git-send-email-zr@semihalf.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 1/2] ethdev: remove get_reg_length callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2016 13:24:12 -0000 On 04/07/2016 12:36, Zyta Szpak wrote: > From: Zyta Szpak > > Removes hard-coded assumption that device registers > are always 32 bits wide. The rte_eth_dev_get_reg_length > and rte_eth_dev_get_reg_info callbacks did not > provide register size to the app in any way while is > needed to allocate correct number of bytes before > retrieving registers using rte_eth_dev_get_reg. > > This commit changes rte_eth_dev_get_reg_info so that > it can be used to retrieve both the number of registers > and their width, and removes the now-redundant > rte_eth_dev_get_reg_length. > > Signed-off-by: Zyta Szpak Acked-by: Remy Horton