From: Jiayu Hu <jiayu.hu@intel.com>
To: dev@dpdk.org
Cc: yliu@fridaylinux.org, jianfeng.tan@intel.com,
lei.a.yao@intel.com, Jiayu Hu <jiayu.hu@intel.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] net/virtio: fix fail to configure rxq interrupt
Date: Mon, 31 Jul 2017 15:56:44 +0800 [thread overview]
Message-ID: <1501487804-50970-1-git-send-email-jiayu.hu@intel.com> (raw)
In-Reply-To: <1500434303-12975-1-git-send-email-jiayu.hu@intel.com>
When use rte_eth_dev_configure() to enable rx queue interrupt for virtio
devices, virtio_init_device() isn't called to set up the interrupt
environment, which causes rx queue interrupt setup failed. This patch is
to fix this issue.
Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts")
Cc: stable@dpdk.org
Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
---
changes in v2:
- fix QEMU crash issue.
drivers/net/virtio/virtio_ethdev.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 00a3122..e320811 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1659,9 +1659,16 @@ virtio_dev_configure(struct rte_eth_dev *dev)
{
const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
struct virtio_hw *hw = dev->data->dev_private;
+ int ret;
PMD_INIT_LOG(DEBUG, "configure");
+ if (dev->data->dev_conf.intr_conf.rxq) {
+ ret = virtio_init_device(dev, hw->req_guest_features);
+ if (ret < 0)
+ return ret;
+ }
+
/* Virtio does L4 checksum but not L3! */
if (rxmode->hw_ip_checksum) {
PMD_DRV_LOG(NOTICE,
--
2.7.4
next prev parent reply other threads:[~2017-07-31 7:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 3:18 [dpdk-dev] [PATCH] " Jiayu Hu
2017-07-19 3:23 ` Yang, Zhiyong
2017-07-19 11:08 ` Yuanhan Liu
2017-07-19 16:03 ` Tan, Jianfeng
2017-07-31 2:30 ` Yuanhan Liu
[not found] ` <ED946F0BEFE0A141B63BABBD629A2A9B38787115@shsmsx102.ccr.corp.intel.com>
2017-07-31 3:47 ` Yuanhan Liu
2017-07-31 7:28 ` Hu, Jiayu
2017-07-31 7:56 ` Jiayu Hu [this message]
2017-07-31 17:01 ` [dpdk-dev] [PATCH v2] " Maxime Coquelin
2017-07-31 17:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501487804-50970-1-git-send-email-jiayu.hu@intel.com \
--to=jiayu.hu@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=lei.a.yao@intel.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).