From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0379C42352; Wed, 11 Oct 2023 17:59:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9B5B40279; Wed, 11 Oct 2023 17:59:16 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 6703F400D7 for ; Wed, 11 Oct 2023 17:59:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0C4835C03DC; Wed, 11 Oct 2023 11:59:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 11 Oct 2023 11:59:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1697039955; x=1697126355; bh=xRDRyvVxmR9MEdIO0gCkw8RmqhOIdJ9MaSs Arx7FHdk=; b=NoHmY9x7junTj3F8OpUT5lK3kM/vm3X8nyBodDTyldauTLWWd49 oERuJNCSbyU9O8HNwOiOds/FObbNXY/RqGQjxSoR2yiCDrkpFe7o0+lqFEAHZK7d XKQmffBb4Xm74oh/zPo+whxB5quEhZWuCI2nCUEw0OIW2mBOynYTnYqIyKQTfnMK smm9zdfmg1Nz263WI0ZtpG+2o0/ULl5xFQpjcsFXnxQDqn8EId4k/eh9ao4K6ldq PyahIpAf8/K4rG6mxzli6ySCLz5Q0hibMR5TJjTPAPSqwFhMK1zcmqgXsKv2skZi xcUlUWedDzwlSSqD7njghdiySp2RrEX8HTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1697039955; x=1697126355; bh=xRDRyvVxmR9MEdIO0gCkw8RmqhOIdJ9MaSs Arx7FHdk=; b=G00VyV62wSTfbIbVUBHmUWYMnL0Gxtmu8Lb4r3ueuFTNmJcMmLr NSzRoza1wrflvxOPmY1hJnmYg1LMJtVQXU+baUOnR9a3ft/F/eMVKXN4PlU2AYVG T3gDKJgCx5mY5YFMUOieBtVVWwrf1k8/f9yWfzsUQjPCcOj0zB4pdSaQUEirhGJf 3y5aa4v7BG2DW4UPwQZbm6AwhHCYrgykuKeipiPub6VnAMxbXQ2AorMHaq0Si8h8 SZBNbvcF6k4yDHTtk55pv25Xs4z8Ajiy6XxOQNxB+e49BgoNcD3HS6AusHqgsPSd WzObv5UKkFgesTsZCVgeEFqE+K86PhGYYog== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrheekgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgeejiedvleehudfhuefgfeevgfehieetgeeigffggfffffeiuefg ueektdeffeevnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 Oct 2023 11:59:13 -0400 (EDT) From: Thomas Monjalon To: Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, david.marchand@redhat.com, honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru, mattias.ronnblom@ericsson.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, Bruce Richardson Subject: Re: [PATCH] clarify purpose of empty cache lines Date: Wed, 11 Oct 2023 17:59:12 +0200 Message-ID: <15019809.tv2OnDr8pf@thomas> In-Reply-To: References: <20230904084349.12044-1-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/09/2023 11:12, Bruce Richardson: > On Mon, Sep 04, 2023 at 10:43:49AM +0200, Morten Br=F8rup wrote: > > This patch introduces the generic RTE_CACHE_GUARD macro into the EAL, a= nd > > replaces vaguely described empty cache lines in the rte_ring structure > > with this macro. > >=20 > > Although the implementation of the rte_ring structure assumes that the > > hardware speculatively prefetches 1 cache line, this number can be chan= ged > > at build time by modifying RTE_CACHE_GUARD_LINES in rte_config.h. > >=20 > > The background and the RFC was discussed in this thread: > > http://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35D87B39@smarts= erver.smartshare.dk/ > >=20 > > Signed-off-by: Morten Br=F8rup > > --- > Seems fine to me. >=20 > Acked-by: Bruce Richardson Applied, thanks.