From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
 [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 8F2BDC630
 for <dev@dpdk.org>; Thu, 30 Jul 2015 15:44:36 +0200 (CEST)
Received: by wibxm9 with SMTP id xm9so69515811wib.1
 for <dev@dpdk.org>; Thu, 30 Jul 2015 06:44:36 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=r4e13VBVIM80jYwTQ8w6inH6OiAlHSSGxwegXDztE+k=;
 b=J1KGTpN7ARCNlXRxorYqOwyQl/QcX2R5dEmzZKZSnJjEYghtznuPIXbdpMwMpzCseo
 3eorztERyrqJn1LMU3BqdGmfwBD2xNddL89NumkjrLjnLWEjQaH+rQidzMsN0Vuedyjf
 XK0or0bXNlXwNp9a9WVDtiRC2SxI9tch0Yu17QbTP7/p7yEckjL/cMlD93D40f23LYsy
 VoWKbEViO9ouB4ULuFyH4La5FJeWbTKBu0xInaHSdd1bMFN6mnhBtLVkhjaRP3/Zeahk
 rqoDGEuM/prJeWp6uPokgFFnwPR4lZk9/FpsojREWk58KMrC3bFx5Ndfks0KYU+0mIcR
 63+w==
X-Gm-Message-State: ALoCoQmUgtmXkgMQ1EHfM2QbGkyF2jptuVlhHq2eNluQXgDis+iGrpmfbzGR9c7UgZKPu/60zSRI
X-Received: by 10.194.103.130 with SMTP id fw2mr94017604wjb.121.1438263876469; 
 Thu, 30 Jul 2015 06:44:36 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210])
 by smtp.gmail.com with ESMTPSA id v20sm1962254wjw.17.2015.07.30.06.44.35
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 30 Jul 2015 06:44:35 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Date: Thu, 30 Jul 2015 15:43:21 +0200
Message-ID: <1502678.UGGgkMtiuc@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <55B9DC6F.7040506@6wind.com>
References: <1437852868-6031-1-git-send-email-rkerur@gmail.com>
 <3055506.vZLM2IGfDr@xps13> <55B9DC6F.7040506@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v10 0/3] deduplicate EAL common functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2015 13:44:36 -0000

2015-07-30 10:12, Olivier MATZ:
> Hi Thomas & Ravi,
> 
> On 07/27/2015 02:59 AM, Thomas Monjalon wrote:
> > 2015-07-27 02:56, Thomas Monjalon:
> >> v9 was a subset of previous deduplications by Ravi Kerur.
> >> This v10 address the comments I've done on v9.
> >>
> >> Ravi Kerur (3):
> >>    eal: deduplicate lcore initialization
> >>    eal: deduplicate timer functions
> >>    eal: deduplicate memory initialization
> >
> > Applied shortly to integrate this old pending cleanup in RC2.
> >
> 
> When I try to compile the dpdk for x86_x32-native-linuxapp-gcc , I
> get the following compilation error:
> 
>    CC eal_common_timer.o
> In file included from /usr/include/sys/sysctl.h:63:0,
>                   from 
> /home/matz/dpdk-pkg-cron/dpdk.org/lib/librte_eal/common/eal_common_timer.c:39:
> /usr/include/bits/sysctl.h:19:3: error: #error "sysctl system call is 
> unsupported in x32 kernel"
>   # error "sysctl system call is unsupported in x32 kernel"
>     ^
> 
> Removing the "#include <sys/sysctl.h>" line fixes the issue without
> impacting the compilation. I think this include is not needed and
> could be removed.
> I can provide a patch if it's ok for you.

After fixing another build issue on FreeBSD (patch sent), it builds well
without sys/sysctl.h.
So it seems to be an useless inclusion.