From: Matan Azrad <matan@mellanox.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] net/failsafe: fix tx sub device deactivating
Date: Tue, 15 Aug 2017 09:59:19 +0300 [thread overview]
Message-ID: <1502780359-60553-1-git-send-email-matan@mellanox.com> (raw)
The corrupted code couldn't recognize that all sub devices
were not ready for tx traffic when failsafe PMD was trying
to switch device because of an unreachable condition using.
Hence, the current tx sub device variable was not updated
correctly.
The fix removed the unreachable condition and adds condition
in the right place to handle non tx device ready scenario.
Fixes: ebea83f899d8 ("net/failsafe: add plug-in support")
Fixes: 598fb8aec6f6 ("net/failsafe: support device removal")
Signed-off-by: Matan Azrad <matan@mellanox.com>
Cc: stable@dpdk.org
---
drivers/net/failsafe/failsafe_private.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
Hi Gaetan
I didn't find any real scenario which cause to problematic
behavior because of the previous code.
But it may be.
diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h
index 0361cf4..dc97aec 100644
--- a/drivers/net/failsafe/failsafe_private.h
+++ b/drivers/net/failsafe/failsafe_private.h
@@ -346,9 +346,10 @@ fs_switch_dev(struct rte_eth_dev *dev,
PRIV(dev)->subs_tx = i;
break;
}
- } else if (txd && txd->state < req_state) {
- DEBUG("No device ready, deactivating tx_dev");
- PRIV(dev)->subs_tx = PRIV(dev)->subs_tail;
+ if (i >= PRIV(dev)->subs_tail || !sdev) {
+ DEBUG("No device ready, deactivating tx_dev");
+ PRIV(dev)->subs_tx = PRIV(dev)->subs_tail;
+ }
} else {
return;
}
--
2.7.4
next reply other threads:[~2017-08-15 6:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 6:59 Matan Azrad [this message]
2017-08-16 8:46 ` Gaëtan Rivet
2017-08-16 9:02 ` Matan Azrad
2017-08-16 12:51 ` Gaëtan Rivet
2017-08-16 14:19 ` [dpdk-dev] [PATCH v2] " Matan Azrad
2017-08-16 14:39 ` Gaëtan Rivet
2017-08-16 14:53 ` Matan Azrad
2017-08-21 12:56 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502780359-60553-1-git-send-email-matan@mellanox.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).