From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 82ABF7D47 for ; Fri, 18 Aug 2017 11:33:02 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id z91so9524292wrc.4 for ; Fri, 18 Aug 2017 02:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:mime-version; bh=jZL8wD/zOqjJMdw0RGGmsTsJ8oW62r7JnagutBx9Oi4=; b=JDI+GnJHK6ugS5pbq570yR5QZF4vdBMR5Ddoyy6gPTxn4Ruv/wA4KYJKNBz8vG5nCy UfZiQoUY1BgohJsbP67obxoO5VC3xkCwb7K92qwGz3x+YtAdeo1viBrQjpXdm00+vfBA C6SiVGxGm4IXzpiwBV3pwBsajh3IE4txuT+xbks+SloOW4lzyNiU+MuzxbOxo2yqsMHi pdJyTUMrnXdUrrJvtHGeX+aGfGbqN+s3emM88F3EXZLFMigV2azM9lGFcDtI4vL48Tji MAzspdzFHXK0+wB+w+iyRRz3QknQaSK7h35EiAFYXOPVPBMRoO6pbubY/ELQFXJ0QCHC Baew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=jZL8wD/zOqjJMdw0RGGmsTsJ8oW62r7JnagutBx9Oi4=; b=m3TWEFUhSF8/BNgFMeSI5eO2MedI65sb+bWIYjgDfmp56XyvmTpKXhRHJoTuSsA8KW qCjKpRdCCAGov930ycKLQHoxrufZCl79A0EKYDfcr8ukhg+8Gb2QZbw5rGHOGq0eh2VH mTUshzQh7fzy0KUMDDQSJQ+0hTNN5/Hxo4uXf4lEQeBwo7Aw2V9rbGwE30WbdVmZ1vCw JhB6f8uLnHL66y4tlfrynzi3L3SwNggQDt+tEUvmtSY6qdRFV7BAHyl+E1RmvsgOfjAt f3rdhricALDegylK6o+u7v3iVltRXs9gA2xmLULzoQx7+yIqz1fVVYnPh1PqcnVMrZ6X mNIA== X-Gm-Message-State: AHYfb5jcrebudeIapVVUM/w03mATuExbTRFiG/3Qqf66YZgzfYJdrOrT LSDeZvFvBf9pBQ== X-Received: by 10.28.58.19 with SMTP id h19mr967228wma.85.1503048781989; Fri, 18 Aug 2017 02:33:01 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id x4sm5278615wrd.66.2017.08.18.02.33.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Aug 2017 02:33:01 -0700 (PDT) Message-ID: <1503048780.14701.3.camel@gmail.com> From: Luca Boccassi To: Bruce Richardson Cc: Marco Varlese , dev@dpdk.org, thomas@monjalon.net Date: Fri, 18 Aug 2017 10:33:00 +0100 In-Reply-To: <20170818083544.GA22884@bricha3-MOBL3.ger.corp.intel.com> References: <20170814095208.166496-1-bruce.richardson@intel.com> <1502979024.15962.10.camel@suse.com> <1502983536.31476.4.camel@gmail.com> <20170818083544.GA22884@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [RFCv2 00/40] Building DPDK with meson and ninja X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Aug 2017 09:33:02 -0000 On Fri, 2017-08-18 at 09:35 +0100, Bruce Richardson wrote: > On Thu, Aug 17, 2017 at 04:25:36PM +0100, Luca Boccassi wrote: > > On Thu, 2017-08-17 at 16:10 +0200, Marco Varlese wrote: > > > Hi Bruce, > > >=20 > > > On Mon, 2017-08-14 at 10:51 +0100, Bruce Richardson wrote: > > > > Following on from previous RFC [http://dpdk.org/dev/patchwork/p > > > > atch > > > > /25104/] > > > > here is a second draft implementation for building DPDK with > > > > meson > > > > and > > > > ninja. While still not building all of DPDK, and needing patch > > > > cleanup so > > > > that patches don't overwrite previous work, it is more complete > > > > in > > > > many > > > > ways than the previous version and includes: > > > >=20 > > > > * dynamic build configuration e.g. building pcap driver only if > > > > pcap is > > > > =C2=A0 found, only build af_packet if the target is linux, and only > > > > building QAT > > > > =C2=A0 and openssl crypto drivers if libcrypto is found > > > > * support for pmdinfo inside the PMDs(for shared builds) and > > > > binaries (for > > > > =C2=A0 static builds) > > > > * generalized/standardized way of building libs and drivers, > > > > though > > > > the > > > > =C2=A0 drivers code still needs generalization at the driver, rathe= r > > > > than > > > > =C2=A0 driver-class level. > > > > * support for having a pkgconfig file for DPDK on install, and > > > > helloworld > > > > =C2=A0 and l2fwd can be built using the pkgconfig info (via make, > > > > not > > > > ninja) > > > > * support for library versions > > > > * an implementation for FreeBSD as well as Linux > > > > * all libraries are included in the build, as well as a number > > > > of > > > > NIC, > > > > =C2=A0 crypto, and mempool drivers > > > > * the igb_uio kernel module is build via the kernel Kbuild > > > > system > > > > as part > > > > =C2=A0 of a meson/ninja DPDK build > > >=20 > > > This is really great to see. I do have one suggestion. > > > Would it be possible to version the libraries built by the build- > > > system > > > following the same version of the DPDK release? > > >=20 > > > For instance, in DPDK 17.08 we currently have: > > > # objdump -p librte_pmd_ixgbe.so.1 |grep SONAME > > > =C2=A0 SONAME=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0librte_pmd_ixgbe.so.1 > > >=20 > > > Would it make sense to instead have librte_pmd_ixgbe.so.17.08 > > >=20 > > > I think it would help to facilitate the installation of multiple > > > DPDK > > > library > > > versions on the same system.=C2=A0 > > >=20 > > > For example, we could have the following scenario: > > >=20 > > > 1) OpenVSwithc linked with version 17.02 of DPDK > > > 2) VPP linked with version 17.08 of DPDK > > > 3) DPDK 18.xx installed in the system for any cutting-edge > > > application > > > prototyping. > > >=20 > > > Is this something which could be incorporated as part of this > > > work? > >=20 > > Christian sent a patch a while ago, which was merged, to enable > > this in > > the current build system, it's the CONFIG_RTE_MAJOR_ABI option, we > > use > > it in Debian and Ubuntu for the reasons you mentioned. > >=20 > > And if it's not been translated yet, I agree it's an important one. > >=20 >=20 > No, it's not translated yet - mainly for the reasons that I had > forgotten > it existed, and that there is a lot yet unported. >=20 > General question: should this be the default or not? It looks to me > that > it should probably be, but what do others think? >=20 > /Bruce Well, to maintain backward compatibility, you might not want to have it on by default - it's the equivalent of declaring all ABIs compatibility broken on all releases, some users might not like that. For us distro maintainers it's very easy to enable. But I don't have a strong opinion either way - just thinking about consequences for others. --=20 Kind regards, Luca Boccassi