From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.217.80.70]) by dpdk.org (Postfix) with ESMTP id 2331A7D3A for ; Thu, 24 Aug 2017 09:13:38 +0200 (CEST) X-scanvirus: By SEG_CYREN AntiVirus Engine X-scanresult: CLEAN X-MAILFROM: X-RCPTTO: X-FROMIP: 10.30.3.20 X-SEG-Scaned: 1 X-Received: unknown,10.30.3.20,20170824151319 Received: from unknown (HELO mse01.zte.com.cn) (10.30.3.20) by localhost with (AES256-SHA encrypted) SMTP; 24 Aug 2017 07:13:19 -0000 Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v7O7DHAi025079; Thu, 24 Aug 2017 15:13:17 +0800 (GMT-8) (envelope-from xie.rongqiang@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.43.166.171]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017082415132224-682326 ; Thu, 24 Aug 2017 15:13:22 +0800 From: Rongqiang XIE To: rasesh.mody@cavium.com Cc: dev@dpdk.org, Rongqiang XIE Date: Thu, 24 Aug 2017 15:12:33 +0800 Message-Id: <1503558753-8545-1-git-send-email-xie.rongqiang@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-08-24 15:13:22, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2017-08-24 15:13:05, Serialize complete at 2017-08-24 15:13:05 X-MAIL: mse01.zte.com.cn v7O7DHAi025079 X-HQIP: 127.0.0.1 Subject: [dpdk-dev] [PATCH] net/qede:fix the bug about pointer params may NULL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 07:13:39 -0000 In function qede_rss_reta_update(),the pointer params returned from call to function rte_zmalloc() may be NULL and will be dereferenced. So, should judge the params is NULL or not. Signed-off-by: Rongqiang XIE --- drivers/net/qede/qede_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 0e05989..4e9e89f 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -2012,6 +2012,10 @@ int qede_rss_reta_update(struct rte_eth_dev *eth_dev, memset(&vport_update_params, 0, sizeof(vport_update_params)); params = rte_zmalloc("qede_rss", sizeof(*params) * edev->num_hwfns, RTE_CACHE_LINE_SIZE); + if (params == NULL) { + DP_ERR(edev, "failed to allocate memory\n"); + return -ENOMEM; + } for (i = 0; i < reta_size; i++) { idx = i / RTE_RETA_GROUP_SIZE; -- 1.8.3.1