From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id A185A2E81 for ; Thu, 27 Nov 2014 19:09:44 +0100 (CET) Received: by mail-wg0-f50.google.com with SMTP id k14so7009232wgh.23 for ; Thu, 27 Nov 2014 10:09:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=KEsG9+LEyzKwF5La+RWwWhJtioeyCiX17quqq4RE+/Y=; b=DYMfrTAMjC4WZhzxAetjE8OpNwRathMdMb73/JsZsfTydwLgiQrioUtAECDrx9dQr+ pCK1xMOMGxkJMTl30UNigU/WlpSItCVUtftbL5QaDq+MzWObdD76OxT5R69RmxJjAZQB cNmwo96SgVaSY2j07tePpMsp7/I2iNqIfCN2lY5ni6uwIKPlnCsGx4k91Ea6ZILiBnUS nEHbY1UFsUuNWXpFC/xwXkPhddN3PkOWo4vJMcv0/zE2kpXysJaOTH1wb87le2m5O6kI rn1/qXz71TG8ZxOEwZtnCxc8GnCILYfXh0nuzq35/mfmk13o9pHEmL8TKteWMjQwOE8z aWOg== X-Gm-Message-State: ALoCoQnVld3C2jXoK6JLmU9m97XOfJKNlVd6rXvEP4NQBEEfrUZMIZ02zoV8PSpZlluqXiWDkPSi X-Received: by 10.194.120.164 with SMTP id ld4mr61757988wjb.67.1417111784516; Thu, 27 Nov 2014 10:09:44 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id bo1sm11718276wjc.18.2014.11.27.10.09.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Nov 2014 10:09:43 -0800 (PST) From: Thomas Monjalon To: Michal Jastrzebski Date: Thu, 27 Nov 2014 19:09:20 +0100 Message-ID: <1503684.yXJvT1DJi7@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1417111270-12792-2-git-send-email-michalx.k.jastrzebski@intel.com> References: <1417111270-12792-1-git-send-email-michalx.k.jastrzebski@intel.com> <1417111270-12792-2-git-send-email-michalx.k.jastrzebski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 1/1] bond: add mode 4 support v7 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 18:09:44 -0000 2014-11-27 18:01, Michal Jastrzebski: > From: Pawel Wodkowski > > This patch set add support for dynamic link aggregation (mode 4) to the > librte_pmd_bond library. This mode provides auto negotiation/configuration > of peers and well as link status changes monitoring using out of band > LACP (link aggregation control protocol) messages. For further details of > LACP specification see the IEEE 802.3ad/802.1AX standards. It is also > described here > https://www.kernel.org/doc/Documentation/networking/bonding.txt. > > In this implementation we have an array of mode 4 settings for each slave. > There is also assumption that for every port is one aggregator (it might > be unused if better is found). > > Difference in this implementation vs Linux implementation: > - this implementation it is not directly based on state machines but current > state is calculated from actor and partner states (and other things too). > > Some implementation details: > - during rx burst every packet Is checked if this is LACP or marker packet. > If it is LACP frame it is passed to mode 4 logic using slaves rx ring and > removed from rx buffer before it is returned > - in tx burst, packets from mode 4 (if any) are injected into each slave. > - there is a timer running in background to process/produce mode 4 > frames form rx/to tx functions. > > Some requirements for this mode: > - for LACP mode to work rx and tx burst functions must be invoked > at least in 100ms intervals (testpmd modified to satisfy this requirement) > - provided buffer to rx burst should be at least 2x slave count size. This is > not needed but might increase performance especially during initial > handshake. > > Signed-off-by: Pawel Wodkowski I guess it is acked by Declan? -- Thomas