DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: thomas@monjalon.net, gaetan.rivet@6wind.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] net/failsafe: fix failsafe bus uninit return value
Date: Tue, 29 Aug 2017 10:51:29 +0300	[thread overview]
Message-ID: <1503993089-55121-1-git-send-email-rasland@mellanox.com> (raw)

fs_bus_uninit is always returning 0 no matter what was the status
of each sub device bus_uninit value.

Will now return the first sub device fail value in case it fails.

Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD")

Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
 drivers/net/failsafe/failsafe_eal.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c
index c8f4318..4295347 100644
--- a/drivers/net/failsafe/failsafe_eal.c
+++ b/drivers/net/failsafe/failsafe_eal.c
@@ -90,19 +90,20 @@ fs_bus_uninit(struct rte_eth_dev *dev)
 {
 	struct sub_device *sdev = NULL;
 	uint8_t i;
-	int ret;
+	int ret = 0, sdev_ret;
 
 	FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) {
-		ret = rte_eal_hotplug_remove(sdev->bus->name,
+		sdev_ret = rte_eal_hotplug_remove(sdev->bus->name,
 					     sdev->dev->name);
-		if (ret) {
+		if (sdev_ret) {
 			ERROR("Failed to remove requested device %s",
 			      sdev->dev->name);
+			ret = (ret ? ret : sdev_ret);
 			continue;
 		}
 		sdev->state = DEV_PROBED - 1;
 	}
-	return 0;
+	return ret;
 }
 
 int
-- 
2.7.4

             reply	other threads:[~2017-08-29  7:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29  7:51 Raslan Darawsheh [this message]
2017-08-29  8:18 ` Gaëtan Rivet
2017-08-29  8:55   ` [dpdk-dev] [PATCH v2] " Raslan Darawsheh
2017-08-29  9:02     ` Gaëtan Rivet
2017-08-29  9:08     ` [dpdk-dev] [PATCH v3] " Raslan Darawsheh
2017-08-29  9:28       ` Gaëtan Rivet
2017-08-30  9:09         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503993089-55121-1-git-send-email-rasland@mellanox.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).