From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id A2BAC374F for ; Fri, 1 Sep 2017 15:41:40 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id a47so130332wra.2 for ; Fri, 01 Sep 2017 06:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=YslxnDq0b1UqRjS/YhgPL5vuhVWz11RKzHtzc6IOURI=; b=uC3XgfJoNu0C4l9jChxhyB1/DMigVB4mDgjgenM0uFMn6ksE7lQdMaXKe0cqH2c4ad b6vHvvKHeKOs3i214czwGXjvxMn3TP264ahY+A770hYc8Ic16CbJI1ZGMAyjvViz2TBt iFlUiUztSUBZl+eeEUi0Ur9AP14wpDRmv3xC8Tfqlyd+uMf2awyPWyk5zUthyOqVSpRP ZefWC+BHKqPcetbMAV2pV4k10W/A3KtqyIm3dDaJeWCMM+tOFh6grS3F4ap94B9Pkbcd 31ZLiYxMFZkZcKgkmM49GdBXVLDY6UUY+9VQbvoT+EFjCvZw//v0zUn9f/4VEcP73646 T+5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YslxnDq0b1UqRjS/YhgPL5vuhVWz11RKzHtzc6IOURI=; b=EfIPYpEYlWXtwL6nvdqWGUyX/LxPHUZDS6L10vZKMo2SF83F3Of6rrNyikbXgvc/RF sBAoM674K12mrUSnkxilYWTT4w/15kYR/4UWCwiZV1duQKgcUDepXjf1nmeILfN6JkAt L2kQ+7hGSAbPvtVoC7OOl0lDOj+TKfbebnkirHBHGGH9iBRrcp5lsoGTahOGV4l70ngQ Hs6st7zclyYMPhzk4gBughhlcQYe8wVBtQGvZiyCa7hp3OwSrA9lb0V/qXeWDLDBapkt sL7ogInaPM1DSNa7xwtoB/Ikx+Ys/zy2CSOcgTWCrQU8CCCvK4iTVv/jdtmOHgWxPfz7 CEGg== X-Gm-Message-State: AHPjjUhFcg0JPk5/2jOpDJ/g5k4irAT35j/CfJOcQfXmJoB+3gbvSNJ4 WiMFJK074LTkn1HZBxM= X-Google-Smtp-Source: ADKCNb7SDl1zVB/Y9xXYrRyHLuhcH2AnxsAsh/66BjAqBNzvjrxF2s8fcKMEIMzjBvJqLZt3YlkFow== X-Received: by 10.223.130.229 with SMTP id 92mr1193693wrc.78.1504273300167; Fri, 01 Sep 2017 06:41:40 -0700 (PDT) Received: from bra-l27t7p12.brocade.com ([144.49.71.22]) by smtp.gmail.com with ESMTPSA id r14sm103783wra.80.2017.09.01.06.41.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Sep 2017 06:41:39 -0700 (PDT) From: alangordondewar@gmail.com X-Google-Original-From: alan.dewar@att.com To: tomasz.kantecki@intel.com Cc: dev@dpdk.org, Alan Dewar Date: Fri, 1 Sep 2017 14:41:30 +0100 Message-Id: <1504273290-5429-1-git-send-email-alan.dewar@att.com> X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH] sched: make RED scaling configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 13:41:40 -0000 From: Alan Dewar The RED code stores the maximum threshold is a 32-bit integer as a pseudo fixed-point floating number with 10 fractional bits. Twelve other bits are used to encode the filter weight, leaving just 10 bits for the queue length. This limits the maximum queue length supported by RED queues as 1024 packets. Move the "hard" definitions from red.h into config/common_base so that RED scaling can be configured during build. Signed-off-by: Alan Dewar --- config/common_base | 2 ++ lib/librte_sched/rte_red.h | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/config/common_base b/config/common_base index 5e97a08..5501dfe 100644 --- a/config/common_base +++ b/config/common_base @@ -666,6 +666,8 @@ CONFIG_RTE_SCHED_COLLECT_STATS=n CONFIG_RTE_SCHED_SUBPORT_TC_OV=n CONFIG_RTE_SCHED_PORT_N_GRINDERS=8 CONFIG_RTE_SCHED_VECTOR=n +CONFIG_RTE_RED_SCALING=10 +CONFIG_RTE_RED_MAX_TH_MAX=1023 # # Compile the distributor library diff --git a/lib/librte_sched/rte_red.h b/lib/librte_sched/rte_red.h index ca12227..49d3379 100644 --- a/lib/librte_sched/rte_red.h +++ b/lib/librte_sched/rte_red.h @@ -51,10 +51,9 @@ extern "C" { #include #include #include +#include -#define RTE_RED_SCALING 10 /**< Fraction size for fixed-point */ #define RTE_RED_S (1 << 22) /**< Packet size multiplied by number of leaf queues */ -#define RTE_RED_MAX_TH_MAX 1023 /**< Max threshold limit in fixed point format */ #define RTE_RED_WQ_LOG2_MIN 1 /**< Min inverse filter weight value */ #define RTE_RED_WQ_LOG2_MAX 12 /**< Max inverse filter weight value */ #define RTE_RED_MAXP_INV_MIN 1 /**< Min inverse mark probability value */ -- 2.1.4