From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 47CB43B5
 for <dev@dpdk.org>; Wed, 17 Dec 2014 00:53:46 +0100 (CET)
Received: by mail-wi0-f180.google.com with SMTP id n3so14290753wiv.1
 for <dev@dpdk.org>; Tue, 16 Dec 2014 15:53:46 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=qVeHO0gvpM5+2TloclsSBLVI4qL8lDAU+ObDEryiFPY=;
 b=UTpH0nmZjPVhAExjC61VgEcSnec2cEtx+heIVrt9VR8yHEfZ0Ifo3t+4uNZcabP8BU
 5IPrq8TG9CvrcqTDiU65SdeIhxLs1Dfx2qpbCwVP1Bgjo7/bqUbqPKfAXLh4tbP9VrAu
 2rdW1wjgabRPh1HhjTxrJtLffwhvKNpLQ5N4VT4uhMZWb9UMDTsczm5SIqiXIlhqWP9v
 5htOwq2lsqyOVnBI/NPgiXOlqen6S/LKXAo8fNybKVirHDMXKNwjZKeTGTl1zd6j1tLg
 WkLFI+UOKDVeavmaeai2j9XxEL954YAu9AdtgvPNml8qYjQSErMbCiD3OC7/J1vRG+RS
 Zk9Q==
X-Gm-Message-State: ALoCoQnhXq2uuEduFJS0fEMGwPg67bg9O5v5DKfJt2hvndeRkPP85JiXDlU9VK16gcoAGEFtmIUH
X-Received: by 10.180.210.228 with SMTP id mx4mr4265317wic.57.1418774026191;
 Tue, 16 Dec 2014 15:53:46 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id iz19sm18765591wic.8.2014.12.16.15.53.44
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 16 Dec 2014 15:53:45 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Date: Wed, 17 Dec 2014 00:42:45 +0100
Message-ID: <1505130.0FLpEfacGg@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <5049551.Sg4yn1HA6q@xps13>
References: <1414078550-692-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1414511329-3948-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <5049551.Sg4yn1HA6q@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: link combined shared lib using CC
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Dec 2014 23:53:46 -0000

2014-12-16 19:48, Thomas Monjalon:
> 2014-10-28 15:48, Sergio Gonzalez Monroy:
> > If we set EXTRA_CFLAGS=-O0, build fails with following error:
> > 
> > /usr/bin/ld: test: hidden symbol `mknod' in /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO
> > 
> > Fix: link combined shared lib using CC if LINK_USING_CC is enabled.
> > 
> > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> > ---
> >  mk/rte.lib.mk      |  1 -
> >  mk/rte.sharelib.mk | 12 +++++++++++-
> [...]
> > --- a/mk/rte.lib.mk
> > +++ b/mk/rte.lib.mk
> > @@ -63,7 +63,6 @@ ifeq ($(LINK_USING_CC),1)
> >  # Override the definition of LD here, since we're linking with CC
> >  LD := $(CC)
> >  LD_MULDEFS := $(call linkerprefix,-z$(comma)muldefs)
> > -CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))
> >  endif
> 
> Why are you removing this line?

If it's really needed, it could be another patch.
 
> > --- a/mk/rte.sharelib.mk
> > +++ b/mk/rte.sharelib.mk
> [...]

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied without the change to rte.lib.mk.

Thanks
-- 
Thomas