* [dpdk-dev] [PATCH] net/nfp: write PF MAC to config BAR
@ 2017-09-13 20:55 Alejandro Lucero
2017-09-18 19:14 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Lucero @ 2017-09-13 20:55 UTC (permalink / raw)
To: dev
VFs rely on config BAR for getting the MAC address, although a
random one is created a valid address is not found.
A PF port has a fixed MAC which is currently acquired using the NSPU
interface. Some NFP firmwares require the MAC being writing back
to the config BAR for doing proper MAC filtering.
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 000d339..fe41e61 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2810,10 +2810,12 @@ uint32_t nfp_net_txq_full(struct nfp_net_txq *txq)
return -ENOMEM;
}
- if (hw->is_pf)
+ if (hw->is_pf) {
nfp_net_pf_read_mac(hwport0, port);
- else
+ nfp_net_write_mac(hw, (uint8_t *)&hw->mac_addr);
+ } else {
nfp_net_vf_read_mac(hw);
+ }
if (!is_valid_assigned_ether_addr((struct ether_addr *)&hw->mac_addr)) {
/* Using random mac addresses for VFs */
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/nfp: write PF MAC to config BAR
2017-09-13 20:55 [dpdk-dev] [PATCH] net/nfp: write PF MAC to config BAR Alejandro Lucero
@ 2017-09-18 19:14 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-09-18 19:14 UTC (permalink / raw)
To: Alejandro Lucero, dev
On 9/13/2017 9:55 PM, Alejandro Lucero wrote:
> VFs rely on config BAR for getting the MAC address, although a
> random one is created a valid address is not found.
>
> A PF port has a fixed MAC which is currently acquired using the NSPU
> interface. Some NFP firmwares require the MAC being writing back
> to the config BAR for doing proper MAC filtering.
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-18 19:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-13 20:55 [dpdk-dev] [PATCH] net/nfp: write PF MAC to config BAR Alejandro Lucero
2017-09-18 19:14 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).