* [dpdk-dev] [PATCH] buildtools: add null point check for calloc
@ 2017-09-15 11:33 Yong Wang
2017-11-07 22:26 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Yong Wang @ 2017-09-15 11:33 UTC (permalink / raw)
To: thomas; +Cc: dev, Yong Wang
In func locate_pmd_entries(), pointer 'new' returned from call to func
'calloc' may be NULL. It is dereferenced without null point check.
Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
buildtools/pmdinfogen/pmdinfogen.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
index e73fc76..96ccbf3 100644
--- a/buildtools/pmdinfogen/pmdinfogen.c
+++ b/buildtools/pmdinfogen/pmdinfogen.c
@@ -327,6 +327,10 @@ static int locate_pmd_entries(struct elf_info *info)
do {
new = calloc(sizeof(struct pmd_driver), 1);
+ if (new == NULL) {
+ fprintf(stderr, "Failed to calloc memory\n");
+ return -1;
+ }
new->name_sym = find_sym_in_symtab(info, "this_pmd_name", last);
last = new->name_sym;
if (!new->name_sym)
@@ -408,7 +412,8 @@ int main(int argc, char **argv)
}
parse_elf(&info, argv[1]);
- locate_pmd_entries(&info);
+ if (locate_pmd_entries(&info) < 0)
+ exit(1);
if (info.drivers) {
output_pmd_info_string(&info, argv[2]);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] buildtools: add null point check for calloc
2017-09-15 11:33 [dpdk-dev] [PATCH] buildtools: add null point check for calloc Yong Wang
@ 2017-11-07 22:26 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-11-07 22:26 UTC (permalink / raw)
To: Yong Wang; +Cc: dev
15/09/2017 13:33, Yong Wang:
> In func locate_pmd_entries(), pointer 'new' returned from call to func
> 'calloc' may be NULL. It is dereferenced without null point check.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-07 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-15 11:33 [dpdk-dev] [PATCH] buildtools: add null point check for calloc Yong Wang
2017-11-07 22:26 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).