From: Yong Wang <wang.yong19@zte.com.cn>
To: shijith.thotton@cavium.com
Cc: dev@dpdk.org, Yong Wang <wang.yong19@zte.com.cn>
Subject: [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable
Date: Fri, 15 Sep 2017 07:48:28 -0400 [thread overview]
Message-ID: <1505476108-11005-1-git-send-email-wang.yong19@zte.com.cn> (raw)
In func lio_dev_link_update(), "link.link_autoneg" is used in func call
lio_dev_atomic_write_link_status(), but is uninitialized.
v2:
* Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
to 'ETH_LINK_AUTONEG'.
Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
drivers/net/liquidio/lio_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
index 479936a..30119d2 100644
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off {
link.link_status = ETH_LINK_DOWN;
link.link_speed = ETH_SPEED_NUM_NONE;
link.link_duplex = ETH_LINK_HALF_DUPLEX;
+ link.link_autoneg = ETH_LINK_AUTONEG;
memset(&old, 0, sizeof(old));
/* Return what we found */
--
1.8.3.1
next reply other threads:[~2017-09-15 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 11:48 Yong Wang [this message]
2017-09-18 6:27 ` Shijith Thotton
2017-09-19 6:45 ` Shijith Thotton
2017-09-19 7:27 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505476108-11005-1-git-send-email-wang.yong19@zte.com.cn \
--to=wang.yong19@zte.com.cn \
--cc=dev@dpdk.org \
--cc=shijith.thotton@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).