* [dpdk-dev] [PATCH] app/testpmd: fix stats period can't quit normally in container
@ 2017-09-18 3:00 Phil Yang
0 siblings, 0 replies; 4+ messages in thread
From: Phil Yang @ 2017-09-18 3:00 UTC (permalink / raw)
To: dev; +Cc: nd
While running testpmd in container with stats-period option, it can't
quit normally after received SIGINT.
Signed-off-by: Phil Yang <phil.yang@arm.com>
---
app/test-pmd/testpmd.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index e097ee0..a4da9ea 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -183,6 +183,7 @@ uint16_t mbuf_data_size = DEFAULT_MBUF_DATA_SIZE; /**< Mbuf data space size. */
uint32_t param_total_num_mbufs = 0; /**< number of mbufs in all pools - if
* specified on command-line. */
uint16_t stats_period; /**< Period to show statistics (disabled by default) */
+uint8_t f_quit = 0; /* Receive LSC INTERRUPTION to stop show statistics periodically */
/*
* Configuration of packet segments used by the "txonly" processing engine.
*/
@@ -2285,6 +2286,8 @@ init_port(void)
static void
force_quit(void)
{
+ f_quit = 1;
+
pmd_test_exit();
prompt_exit();
}
@@ -2444,7 +2447,7 @@ main(int argc, char** argv)
/* Convert to number of cycles */
timer_period = stats_period * rte_get_timer_hz();
- while (1) {
+ while (!f_quit) {
cur_time = rte_get_timer_cycles();
diff_time += cur_time - prev_time;
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix stats period can't quit normally in container
2017-09-18 3:40 Phil Yang
@ 2017-09-21 8:32 ` Jianbo Liu
0 siblings, 0 replies; 4+ messages in thread
From: Jianbo Liu @ 2017-09-21 8:32 UTC (permalink / raw)
To: Phil Yang; +Cc: dev, nd
On 18 September 2017 at 11:40, Phil Yang <phil.yang@arm.com> wrote:
> While running testpmd in container with stats-period option, it can't
> quit normally after received SIGINT.
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> ---
> app/test-pmd/testpmd.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index e097ee0..d94c63b 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -183,6 +183,7 @@ uint16_t mbuf_data_size = DEFAULT_MBUF_DATA_SIZE; /**< Mbuf data space size. */
> uint32_t param_total_num_mbufs = 0; /**< number of mbufs in all pools - if
> * specified on command-line. */
> uint16_t stats_period; /**< Period to show statistics (disabled by default) */
> +uint8_t f_quit; /* Receive LSC INTERRUPTION to stop show statistics periodically */
The comment seems wrong, as it's not related to LSC.
> /*
> * Configuration of packet segments used by the "txonly" processing engine.
> */
> @@ -2285,6 +2286,8 @@ init_port(void)
> static void
> force_quit(void)
> {
> + f_quit = 1;
I suggest moving this line to the bottom of this function.
> +
> pmd_test_exit();
> prompt_exit();
> }
> @@ -2441,10 +2444,13 @@ main(int argc, char** argv)
> uint64_t prev_time = 0, cur_time, diff_time = 0;
> uint64_t timer_period;
>
> + /* Receive LSC interrupt to stop showing statistics period */
> + f_quit = 0;
> +
> /* Convert to number of cycles */
> timer_period = stats_period * rte_get_timer_hz();
>
> - while (1) {
> + while (!f_quit) {
> cur_time = rte_get_timer_cycles();
> diff_time += cur_time - prev_time;
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] app/testpmd: fix stats period can't quit normally in container
@ 2017-09-18 3:40 Phil Yang
2017-09-21 8:32 ` Jianbo Liu
0 siblings, 1 reply; 4+ messages in thread
From: Phil Yang @ 2017-09-18 3:40 UTC (permalink / raw)
To: dev; +Cc: nd
While running testpmd in container with stats-period option, it can't
quit normally after received SIGINT.
Signed-off-by: Phil Yang <phil.yang@arm.com>
---
app/test-pmd/testpmd.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index e097ee0..d94c63b 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -183,6 +183,7 @@ uint16_t mbuf_data_size = DEFAULT_MBUF_DATA_SIZE; /**< Mbuf data space size. */
uint32_t param_total_num_mbufs = 0; /**< number of mbufs in all pools - if
* specified on command-line. */
uint16_t stats_period; /**< Period to show statistics (disabled by default) */
+uint8_t f_quit; /* Receive LSC INTERRUPTION to stop show statistics periodically */
/*
* Configuration of packet segments used by the "txonly" processing engine.
*/
@@ -2285,6 +2286,8 @@ init_port(void)
static void
force_quit(void)
{
+ f_quit = 1;
+
pmd_test_exit();
prompt_exit();
}
@@ -2441,10 +2444,13 @@ main(int argc, char** argv)
uint64_t prev_time = 0, cur_time, diff_time = 0;
uint64_t timer_period;
+ /* Receive LSC interrupt to stop showing statistics period */
+ f_quit = 0;
+
/* Convert to number of cycles */
timer_period = stats_period * rte_get_timer_hz();
- while (1) {
+ while (!f_quit) {
cur_time = rte_get_timer_cycles();
diff_time += cur_time - prev_time;
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] app/testpmd: fix stats period can't quit normally in container
@ 2017-09-18 3:35 Phil Yang
0 siblings, 0 replies; 4+ messages in thread
From: Phil Yang @ 2017-09-18 3:35 UTC (permalink / raw)
To: dev; +Cc: nd
While running testpmd in container with stats-period option, it can't
quit normally after received SIGINT.
Signed-off-by: Phil Yang <phil.yang@arm.com>
---
app/test-pmd/testpmd.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index e097ee0..77de8b8 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -183,6 +183,7 @@ uint16_t mbuf_data_size = DEFAULT_MBUF_DATA_SIZE; /**< Mbuf data space size. */
uint32_t param_total_num_mbufs = 0; /**< number of mbufs in all pools - if
* specified on command-line. */
uint16_t stats_period; /**< Period to show statistics (disabled by default) */
+uint8_t f_quit; /* Receive LSC INTERRUPTION to stop show statistics periodically */
/*
* Configuration of packet segments used by the "txonly" processing engine.
*/
@@ -2285,6 +2286,8 @@ init_port(void)
static void
force_quit(void)
{
+ f_quit = 1;
+
pmd_test_exit();
prompt_exit();
}
@@ -2441,10 +2444,13 @@ main(int argc, char** argv)
uint64_t prev_time = 0, cur_time, diff_time = 0;
uint64_t timer_period;
+ /* Receive LSC INTERRUPTION to stop showing statistics periodically */
+ f_quit = 0;
+
/* Convert to number of cycles */
timer_period = stats_period * rte_get_timer_hz();
- while (1) {
+ while (!f_quit) {
cur_time = rte_get_timer_cycles();
diff_time += cur_time - prev_time;
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-21 8:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-18 3:00 [dpdk-dev] [PATCH] app/testpmd: fix stats period can't quit normally in container Phil Yang
2017-09-18 3:35 Phil Yang
2017-09-18 3:40 Phil Yang
2017-09-21 8:32 ` Jianbo Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).