From: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
To: john.mcnamara@intel.com
Cc: dev@dpdk.org, Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>,
ian.betts@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] examples/performance-thread: fix out-of-bounds read
Date: Wed, 20 Sep 2017 10:21:10 +0200 [thread overview]
Message-ID: <1505895670-25808-1-git-send-email-slawomirx.mrozowicz@intel.com> (raw)
Overrunning array per_lcore_this_sched->current_lthread->tls->data of
1024 8-byte elements at element index 1024 using index k.
Fixed by correct check k condition.
Coverity issue: 143463
Fixes: 116819b9ed0d ("examples/performance-thread: add lthread subsystem")
Cc: ian.betts@intel.com
Cc: stable@dpdk.org
Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
---
examples/performance-thread/common/lthread_tls.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/examples/performance-thread/common/lthread_tls.c b/examples/performance-thread/common/lthread_tls.c
index 47505f2d4..4ae3c6c03 100644
--- a/examples/performance-thread/common/lthread_tls.c
+++ b/examples/performance-thread/common/lthread_tls.c
@@ -198,11 +198,12 @@ void _lthread_tls_destroy(struct lthread *lt)
void
*lthread_getspecific(unsigned int k)
{
+ void *res = NULL;
- if (k > LTHREAD_MAX_KEYS)
- return NULL;
+ if (k < LTHREAD_MAX_KEYS)
+ res = THIS_LTHREAD->tls->data[k];
- return THIS_LTHREAD->tls->data[k];
+ return res;
}
/*
--
2.11.0
next reply other threads:[~2017-09-20 8:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:21 Slawomir Mrozowicz [this message]
2017-10-11 13:56 ` Jastrzebski, MichalX K
2017-10-13 23:23 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2017-09-20 8:20 Slawomir Mrozowicz
2017-10-11 13:56 ` Jastrzebski, MichalX K
2017-09-20 8:05 Slawomir Mrozowicz
2017-10-11 13:55 ` Jastrzebski, MichalX K
2017-10-13 23:19 ` Thomas Monjalon
2017-09-20 7:47 Slawomir Mrozowicz
2017-10-02 14:07 ` Jastrzebski, MichalX K
2017-10-11 13:55 ` Jastrzebski, MichalX K
2017-10-13 23:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505895670-25808-1-git-send-email-slawomirx.mrozowicz@intel.com \
--to=slawomirx.mrozowicz@intel.com \
--cc=dev@dpdk.org \
--cc=ian.betts@intel.com \
--cc=john.mcnamara@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).