From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 564841B194; Thu, 21 Sep 2017 12:00:33 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id x17so4714724wmd.5; Thu, 21 Sep 2017 03:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:mime-version; bh=jOg4A6bdzAo7L2Gn/KwJwqhr1cFK6sI3DTgQH+GttQQ=; b=rKhGFzUls+L37TcyDwkuH69KcZoid/Czb/fwzru7PtfQSr+YpTSm5pk2F0tE2Ocg+C lk2z331VVOxQujoYhXDwWdvpbm5KVarQPzGMtnIuF4BOcnZL4XiHSrSZqY/itt3qrK2X FzxnY8VN1DO//JajCuKTWZ773aPw5WfVrA4fqQqEvk9Atdndpz1DFxzUdqllCzjOfggV vMklFdtsNMhHcCtCc+ytTyQXlpTUr/uJYNDAnqkEmz5L0vBC/Dtnzfsz4dxdqD3pkb3F DXdGukNVNfgn9ZPl3ZXdzM4GCeeYYDYaGa6UExsbYSF80A3krlzLNDKfIdEx8a4y1odA G7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=jOg4A6bdzAo7L2Gn/KwJwqhr1cFK6sI3DTgQH+GttQQ=; b=gbuUt2dARA0JEw7gPSNBJx1LNAtERl5gFJwm2wW30GjnYFF2jke9xNB2g0N4Ovh4xl mDqhdsjRRcE/uH6ig14XygIJ2o9YTfgehc6Iwwb+drfLEHEmsVxqD+iXZjmPhSl9Zs9C X4NTtO+QBl14NuyzgmQA8UsH+gH1X5wQYLAf3FXZKTeyvEPp0+elQU2SkeodFYCjdovB ysBE8X5IS0SgQ//W60SreWWmiW9vDVwYngh4mZrSMYfl3Fyrb4+YCbG13hJqXt0pHvOL +V9TVKIfJTFYQnMLJznlZuD8K2GlrtzuN6OSVqBb+kzYysN47o9HBP5qTRsWaaDZv4TT id/Q== X-Gm-Message-State: AHPjjUhI6yBAEgcLx+N4ufwwXFScLB0jTO+uuVDdBWV+eaELhmECDDj6 FDUMTN/BzAqJGvYCr1URb1s= X-Google-Smtp-Source: AOwi7QDSKc/EV+8pJgrNdKpxJFqo/+wjTdFzs0yXEPnyGPKXnXARRwCh+ulVcRXrXiikgYYuhkAyYw== X-Received: by 10.28.39.68 with SMTP id n65mr464977wmn.122.1505988032915; Thu, 21 Sep 2017 03:00:32 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id g37sm1606426wra.6.2017.09.21.03.00.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Sep 2017 03:00:32 -0700 (PDT) Message-ID: <1505988031.28679.2.camel@gmail.com> From: Luca Boccassi To: Shijith Thotton , dev@dpdk.org Cc: Ferruh Yigit , Thomas Monjalon , "Yang, Qiming" , "Patil, Harish" , "Zhang, Helin" , Gregory Etelson , "Tan, Jianfeng" , "Hu, Xuekun" , "Li, Xiaoyun" , "Thotton, Shijith" , stable@dpdk.org, 3chas3@gmail.com Date: Thu, 21 Sep 2017 11:00:31 +0100 In-Reply-To: <1505816653-28715-1-git-send-email-shijith.thotton@caviumnetworks.com> References: <1505816653-28715-1-git-send-email-shijith.thotton@caviumnetworks.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 10:00:33 -0000 On Tue, 2017-09-19 at 15:54 +0530, Shijith Thotton wrote: > Issuing reset during uio device open caused PMD init failure for some > NIC VFs (i40, ixgbe, qede) in host. So this initial reset is removed. > Bus master enable is kept as part of open since we disable it in uio > device release. >=20 > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of > device file") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shijith Thotton > --- > =C2=A0lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 +--- > =C2=A01 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > index 07a19a3..a6c2996 100644 > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > @@ -179,9 +179,7 @@ struct rte_uio_pci_dev { > =C2=A0 struct rte_uio_pci_dev *udev =3D info->priv; > =C2=A0 struct pci_dev *dev =3D udev->pdev; > =C2=A0 > - pci_reset_function(dev); > - > - /* set bus master, which was cleared by the reset function > */ > + /* enable bus mastering on the device */ > =C2=A0 pci_set_master(dev); > =C2=A0 > =C2=A0 return 0; Tested-by: Luca Boccassi Hi, we had the same issue, Chas applied and tested this patch on top of 17.08 and our QA department confirms that it fixes the problem. --=20 Kind regards, Luca Boccassi