From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id F3E311B1BF for ; Mon, 2 Oct 2017 12:01:19 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id f4so1353036wme.0 for ; Mon, 02 Oct 2017 03:01:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=rGQe72qBtmxgmmnZUkg2xcYIdo6TSaHWY8S/ULtTbGk=; b=O3hRLELH0whM3ZJ/xHbBk3l5TQ7zIsZrTUYG0/DAwFUVssFkV19Ly0zaRBhVJTEgV5 Na+86vm20oDm/utifyC9cFGTnMSWZXiWn9nE6NOew6qPyX+oM0w+sxblYd8p8rbFebW+ tidpsDiWZ/GQkfy5180/ipkoS0LGFu8RQ4LuWLZ/DMcJ1nw5ftB4eG56t6QuAUWmsiiF Qe2JMKZfUPD65Kx/B/8fh3zOROgYz1jp81yu3Hl/VUNwB8oPoCULPPD4YywXUnN8W2tW j4juu8jdN+N03osBDeRN2EOhKQgrGgyIx/T8YpfKvyqc/QpF9FSmYGE8Ju1KT5zDcnEW dbcg== X-Gm-Message-State: AMCzsaWSxZFGazqGZY+K2nE/aAGs6dhtGtY6Y4STNKWRf74WJvlpj8a7 uEOYtnh5xhXl0bxQ3busn71l1O6M X-Google-Smtp-Source: AOwi7QC+CzgPvXDGD225zWj7e09Idrn3j+E2LC8Jf7EKB/1SzcFBc2p98BpRxS3TRJqqTYyVcFZWwQ== X-Received: by 10.28.63.150 with SMTP id m144mr1479507wma.141.1506938479631; Mon, 02 Oct 2017 03:01:19 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id y39sm13771763wry.70.2017.10.02.03.01.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Oct 2017 03:01:18 -0700 (PDT) Message-ID: <1506938477.7585.1.camel@debian.org> From: Luca Boccassi To: Stephen Hemminger , dev@dpdk.org Date: Mon, 02 Oct 2017 11:01:17 +0100 In-Reply-To: <20170929153749.9806-1-stephen@networkplumber.org> References: <20170929153749.9806-1-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 10:01:20 -0000 On Fri, 2017-09-29 at 08:37 -0700, Stephen Hemminger wrote: > The Linux kernel style policy about strings is that strings should > be always put on one line. This makes sense since a typical use > case is for a user to type the error message into a search engine > or grep, and it won't be found if split across lines. > This patch just re-enables that check. >=20 > Yes, lots of DPDK code now splits strings, that doesn't > make it right. >=20 > Signed-off-by: Stephen Hemminger > --- > =C2=A0devtools/checkpatches.sh | 1 - > =C2=A01 file changed, 1 deletion(-) >=20 > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index a56c41a301c0..3e6081dd673e 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -44,7 +44,6 @@ options=3D"$options --show-types" > =C2=A0options=3D"$options --ignore=3DLINUX_VERSION_CODE,FILE_PATH_CHANGES= ,\ > =C2=A0VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > =C2=A0PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ > -SPLIT_STRING,LONG_LINE_STRING,\ > =C2=A0LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > =C2=A0NEW_TYPEDEFS,COMPARISON_TO_NULL" > =C2=A0 Acked-by: Luca Boccassi +1 - being able to reliably Google/grep across such a large code base is extremely useful --=20 Kind regards, Luca Boccassi