DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
To: dev@dpdk.org
Cc: kirill.rybalchenko@intel.com, andrey.chilikin@intel.com,
	beilei.xing@intel.com, jingjing.wu@intel.com
Subject: [dpdk-dev] [PATCH] app/testpmd: fix compilation with I40E disabled
Date: Mon,  9 Oct 2017 15:38:02 +0100	[thread overview]
Message-ID: <1507559882-98853-1-git-send-email-kirill.rybalchenko@intel.com> (raw)

Precompiler instructions #ifdef RTE_LIBRTE_I40E_PMD ... #endif
were not placed correctly, which caused number of
compilation errors if I40E PMD is disabled.

Fixes: 5a4806d304e0 ("app/testpmd: support updating pctype mapping")

Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
---
 app/test-pmd/cmdline.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 20e04f7..8dc5c85 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -13843,8 +13843,8 @@ cmd_ddp_info_parsed(
 
 	free(proto);
 	ret = 0;
-#endif
 no_print_return:
+#endif
 	if (ret == -ENOTSUP)
 		printf("Function not supported in PMD driver\n");
 	close_ddp_package_file(pkg);
@@ -14390,17 +14390,16 @@ cmd_pctype_mapping_update_parsed(
 #ifdef RTE_LIBRTE_I40E_PMD
 	struct rte_pmd_i40e_flow_type_mapping mapping;
 	unsigned int i;
-#endif
 	unsigned int nb_item;
 	unsigned int pctype_list[RTE_PMD_I40E_PCTYPE_MAX];
+#endif
 
 	if (port_id_is_invalid(res->port_id, ENABLED_WARN))
 		return;
 
+#ifdef RTE_LIBRTE_I40E_PMD
 	nb_item = parse_item_list(res->pctype_list, "pctypes",
 				  RTE_PMD_I40E_PCTYPE_MAX, pctype_list, 1);
-
-#ifdef RTE_LIBRTE_I40E_PMD
 	mapping.flow_type = res->flow_type;
 	for (i = 0, mapping.pctype = 0ULL; i < nb_item; i++)
 		mapping.pctype |= (1ULL << pctype_list[i]);
-- 
2.5.5

             reply	other threads:[~2017-10-09 14:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09 14:38 Kirill Rybalchenko [this message]
2017-10-09 17:45 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507559882-98853-1-git-send-email-kirill.rybalchenko@intel.com \
    --to=kirill.rybalchenko@intel.com \
    --cc=andrey.chilikin@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).