* [dpdk-dev] [PATCH 1/2] net/sfc: invert positive errno used internally on return
@ 2017-10-11 7:06 Andrew Rybchenko
2017-10-11 7:06 ` [dpdk-dev] [PATCH 2/2] test: fix broken build because of prototype mismatch Andrew Rybchenko
2017-10-11 17:53 ` [dpdk-dev] [PATCH 1/2] net/sfc: invert positive errno used internally on return Ferruh Yigit
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Rybchenko @ 2017-10-11 7:06 UTC (permalink / raw)
To: dev; +Cc: Matan Azrad, Ferruh Yigit
Fixes: a4b090d0284b ("ethdev: add return value to stats get dev op")
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 5b089dc..bd09191 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -589,7 +589,8 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
unlock:
rte_spinlock_unlock(&port->mac_stats_lock);
- return ret;
+ SFC_ASSERT(ret >= 0);
+ return -ret;
}
static void
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* [dpdk-dev] [PATCH 2/2] test: fix broken build because of prototype mismatch
2017-10-11 7:06 [dpdk-dev] [PATCH 1/2] net/sfc: invert positive errno used internally on return Andrew Rybchenko
@ 2017-10-11 7:06 ` Andrew Rybchenko
2017-10-11 17:53 ` [dpdk-dev] [PATCH 1/2] net/sfc: invert positive errno used internally on return Ferruh Yigit
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Rybchenko @ 2017-10-11 7:06 UTC (permalink / raw)
To: dev; +Cc: Matan Azrad, Ferruh Yigit
Fixes: a4b090d0284b ("ethdev: add return value to stats get dev op")
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
test/test/virtual_pmd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c
index 6568cb5..09daf6c 100644
--- a/test/test/virtual_pmd.c
+++ b/test/test/virtual_pmd.c
@@ -211,13 +211,15 @@ virtual_ethdev_link_update_fail(struct rte_eth_dev *bonded_eth_dev __rte_unused,
return -1;
}
-static void
+static int
virtual_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
{
struct virtual_ethdev_private *dev_private = dev->data->dev_private;
if (stats)
rte_memcpy(stats, &dev_private->eth_stats, sizeof(*stats));
+
+ return 0;
}
static void
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/sfc: invert positive errno used internally on return
2017-10-11 7:06 [dpdk-dev] [PATCH 1/2] net/sfc: invert positive errno used internally on return Andrew Rybchenko
2017-10-11 7:06 ` [dpdk-dev] [PATCH 2/2] test: fix broken build because of prototype mismatch Andrew Rybchenko
@ 2017-10-11 17:53 ` Ferruh Yigit
1 sibling, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-11 17:53 UTC (permalink / raw)
To: Andrew Rybchenko, dev; +Cc: Matan Azrad
On 10/11/2017 8:06 AM, Andrew Rybchenko wrote:
> Fixes: a4b090d0284b ("ethdev: add return value to stats get dev op")
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Series squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 7:06 [dpdk-dev] [PATCH 1/2] net/sfc: invert positive errno used internally on return Andrew Rybchenko
2017-10-11 7:06 ` [dpdk-dev] [PATCH 2/2] test: fix broken build because of prototype mismatch Andrew Rybchenko
2017-10-11 17:53 ` [dpdk-dev] [PATCH 1/2] net/sfc: invert positive errno used internally on return Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).