DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jacek Piasecki <jacekx.piasecki@intel.com>
To: dev@dpdk.org
Cc: maxime.coquelin@redhat.com, changpeng.liu@intel.com,
	deepak.k.jain@intel.com, michalx.k.jastrzebski@intel.com,
	Jacek Piasecki <jacekx.piasecki@intel.com>,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] examples/vhost_scsi: fix buffer not terminated
Date: Thu, 12 Oct 2017 08:44:55 +0200	[thread overview]
Message-ID: <1507790695-10449-1-git-send-email-jacekx.piasecki@intel.com> (raw)
In-Reply-To: <20170922130734.7256-1-michalx.k.jastrzebski@intel.com>

Use snprintf instead strncpy to get safe null string termination.
There was possible to get not terminated string after strncpy operation.

Coverity issue: 158631
Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app")
Cc: changpeng.liu@intel.com
Cc: stable@dpdk.org

Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com>
---
v2:
* use snprintf instead strncpy

 examples/vhost_scsi/scsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/vhost_scsi/scsi.c b/examples/vhost_scsi/scsi.c
index 54d3104..c0f3187 100644
--- a/examples/vhost_scsi/scsi.c
+++ b/examples/vhost_scsi/scsi.c
@@ -307,7 +307,8 @@
 		strncpy((char *)inqdata->t10_vendor_id, "INTEL", 8);
 
 		/* PRODUCT IDENTIFICATION */
-		strncpy((char *)inqdata->product_id, bdev->product_name, 16);
+		snprintf((char *)inqdata->product_id,
+				ARRAY_SIZE(inqdata->product_id), "%s", bdev->product_name);
 
 		/* PRODUCT REVISION LEVEL */
 		strncpy((char *)inqdata->product_rev, "0001", 4);
-- 
1.9.1

  parent reply	other threads:[~2017-10-12  6:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 13:07 [dpdk-dev] [PATCH] " Michal Jastrzebski
2017-10-02 13:50 ` Jastrzebski, MichalX K
2017-10-02 15:07   ` Maxime Coquelin
2017-10-05 12:35     ` Piasecki, JacekX
2017-10-05 12:42       ` Maxime Coquelin
2017-10-05 13:01         ` Bruce Richardson
2017-10-05 13:02           ` Maxime Coquelin
2017-10-12  6:44 ` Jacek Piasecki [this message]
2017-10-12 11:09   ` [dpdk-dev] [PATCH v2] " Maxime Coquelin
2017-10-12 11:34   ` [dpdk-dev] [PATCH v3] " Jacek Piasecki
2017-10-13  7:12     ` Maxime Coquelin
2017-10-17 13:26       ` Yuanhan Liu
2017-10-24 16:22         ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2017-10-25 10:07     ` [dpdk-dev] [PATCH v4] " Jacek Piasecki
2017-10-25 10:18       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507790695-10449-1-git-send-email-jacekx.piasecki@intel.com \
    --to=jacekx.piasecki@intel.com \
    --cc=changpeng.liu@intel.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=michalx.k.jastrzebski@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).