* [dpdk-dev] [PATCH v2 1/1] cryptodev: fix build with Ofast.
@ 2017-10-17 14:15 Ian Stokes
2017-10-17 15:13 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 4+ messages in thread
From: Ian Stokes @ 2017-10-17 14:15 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, Ian Stokes
When compiling with an application that includes rte_cryptodev.h with
Ofast, an error is reported regarding enumeration
RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function
__rte_crypto_op_reset().
Fix this by adding a case for RTE_CRYPTO_OP_TYPE_UNDEFINED.
Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
oriented")
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
---
lib/librte_cryptodev/rte_crypto.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/librte_cryptodev/rte_crypto.h b/lib/librte_cryptodev/rte_crypto.h
index 10fe080..3ef9e41 100644
--- a/lib/librte_cryptodev/rte_crypto.h
+++ b/lib/librte_cryptodev/rte_crypto.h
@@ -144,6 +144,7 @@ struct rte_crypto_op {
case RTE_CRYPTO_OP_TYPE_SYMMETRIC:
__rte_crypto_sym_op_reset(op->sym);
break;
+ case RTE_CRYPTO_OP_TYPE_UNDEFINED:
default:
break;
}
--
1.7.0.7
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/1] cryptodev: fix build with Ofast.
2017-10-17 14:15 [dpdk-dev] [PATCH v2 1/1] cryptodev: fix build with Ofast Ian Stokes
@ 2017-10-17 15:13 ` De Lara Guarch, Pablo
2017-10-17 15:16 ` Stokes, Ian
0 siblings, 1 reply; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2017-10-17 15:13 UTC (permalink / raw)
To: Stokes, Ian, dev; +Cc: stable
> -----Original Message-----
> From: Stokes, Ian
> Sent: Tuesday, October 17, 2017 3:15 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stokes, Ian
> <ian.stokes@intel.com>
> Subject: [PATCH v2 1/1] cryptodev: fix build with Ofast.
>
> When compiling with an application that includes rte_cryptodev.h with
> Ofast, an error is reported regarding enumeration
> RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function
> __rte_crypto_op_reset().
>
> Fix this by adding a case for RTE_CRYPTO_OP_TYPE_UNDEFINED.
>
> Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
> oriented")
>
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Oh, and also CC stable :) I will do it for you.
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/1] cryptodev: fix build with Ofast.
2017-10-17 15:13 ` De Lara Guarch, Pablo
@ 2017-10-17 15:16 ` Stokes, Ian
2017-10-19 19:11 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 4+ messages in thread
From: Stokes, Ian @ 2017-10-17 15:16 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev; +Cc: stable
> > -----Original Message-----
> > From: Stokes, Ian
> > Sent: Tuesday, October 17, 2017 3:15 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stokes,
> > Ian <ian.stokes@intel.com>
> > Subject: [PATCH v2 1/1] cryptodev: fix build with Ofast.
> >
> > When compiling with an application that includes rte_cryptodev.h with
> > Ofast, an error is reported regarding enumeration
> > RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function
> > __rte_crypto_op_reset().
> >
> > Fix this by adding a case for RTE_CRYPTO_OP_TYPE_UNDEFINED.
> >
> > Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
> > oriented")
> >
> > Signed-off-by: Ian Stokes <ian.stokes@intel.com>
>
> Oh, and also CC stable :) I will do it for you.
Apologies Pablo, thanks for this.
Ian
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/1] cryptodev: fix build with Ofast.
2017-10-17 15:16 ` Stokes, Ian
@ 2017-10-19 19:11 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2017-10-19 19:11 UTC (permalink / raw)
To: Stokes, Ian, dev; +Cc: stable
> -----Original Message-----
> From: Stokes, Ian
> Sent: Tuesday, October 17, 2017 4:17 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v2 1/1] cryptodev: fix build with Ofast.
>
> > > -----Original Message-----
> > > From: Stokes, Ian
> > > Sent: Tuesday, October 17, 2017 3:15 PM
> > > To: dev@dpdk.org
> > > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stokes,
> > > Ian <ian.stokes@intel.com>
> > > Subject: [PATCH v2 1/1] cryptodev: fix build with Ofast.
> > >
> > > When compiling with an application that includes rte_cryptodev.h
> > > with Ofast, an error is reported regarding enumeration
> > > RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in
> function
> > > __rte_crypto_op_reset().
> > >
> > > Fix this by adding a case for RTE_CRYPTO_OP_TYPE_UNDEFINED.
> > >
> > > Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
> > > oriented")
> > >
> > > Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> >
> > Oh, and also CC stable :) I will do it for you.
>
> Apologies Pablo, thanks for this.
>
> Ian
> >
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-19 19:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-17 14:15 [dpdk-dev] [PATCH v2 1/1] cryptodev: fix build with Ofast Ian Stokes
2017-10-17 15:13 ` De Lara Guarch, Pablo
2017-10-17 15:16 ` Stokes, Ian
2017-10-19 19:11 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).