From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com
[209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 487CD1B722
for <dev@dpdk.org>; Tue, 17 Oct 2017 20:17:11 +0200 (CEST)
Received: by mail-wr0-f193.google.com with SMTP id z99so160924wrc.12
for <dev@dpdk.org>; Tue, 17 Oct 2017 11:17:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
:references:content-transfer-encoding:mime-version;
bh=FTNbj84AgXwnWM9H3wSf2Tr7CzZ+5vZjEtQxFG63/vo=;
b=m0Ck1L/wHXkysCZzoZsYIAeRsTr7r0pGo4Z7RHPPq/sJdy3Y1qYAd1Qnijtmx6fyyO
EphSLMqb2mUJQYlbGtPnDX7UY5dUsaQkUqfO5dD2Acm3ZOWRHdpscWUqZpnggJAMHQKg
KOyXdRBTSlDPAFNmLoGp1/U795zuXQFm3cz4DMXhkFqsTXB7eumQoIRguc+h7sn5G5S9
066lY6rXJVqeuNhTlSHqPuOxRLH7IObfBXBRIz3s1msWHTR2KD22OYou2PI5XzfRlWRR
V5+QDR9lYLwAic1QPU+6v25K2QHBsFb2khqsolv5rbewlTYI3CazbhVRLoBAC/Za+ACg
SVSg==
X-Gm-Message-State: AMCzsaWOuD5emUio4svZPcwNAkONUYXefUkJaBLOSMWePTJJH8ef54sH
4h6WsUnOegRprYIwKQGW3BU=
X-Google-Smtp-Source: ABhQp+SWmS0rA3G6u/MaD3rCy0Lz6si8UHObAYBoaAzJkJIAWKMyowjJdMOG2wNAnMY4YRSJ7dC86Q==
X-Received: by 10.223.165.7 with SMTP id i7mr4274982wrb.155.1508264230882;
Tue, 17 Oct 2017 11:17:10 -0700 (PDT)
Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749])
by smtp.gmail.com with ESMTPSA id 204sm13545224wml.10.2017.10.17.11.17.09
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 17 Oct 2017 11:17:10 -0700 (PDT)
Message-ID: <1508264229.32437.3.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Date: Tue, 17 Oct 2017 19:17:09 +0100
In-Reply-To: <1508263898.32437.1.camel@debian.org>
References: <20171017161220.59941-1-bruce.richardson@intel.com>
<20171017161220.59941-2-bruce.richardson@intel.com>
<1508263898.32437.1.camel@debian.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1
Mime-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in
pkg-config file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Oct 2017 18:17:11 -0000
On Tue, 2017-10-17 at 19:11 +0100, Luca Boccassi wrote:
> On Tue, 2017-10-17 at 17:12 +0100, Bruce Richardson wrote:
> > Since a number of libraries depend on the maths lib, as well as
> > adding it
> > to the project args, we also need to add it to the pkgconfig file
> > args.
> >=20
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > =C2=A0config/meson.build | 1 +
> > =C2=A01 file changed, 1 insertion(+)
> >=20
> > diff --git a/config/meson.build b/config/meson.build
> > index db68a08d4..542fea4de 100644
> > --- a/config/meson.build
> > +++ b/config/meson.build
> > @@ -35,6 +35,7 @@ dpdk_conf.set('RTE_MACHINE', machine)
> > =C2=A0add_project_arguments('-march=3D@0@'.format(machine), language: '=
c')
> > =C2=A0# some libs depend on maths lib
> > =C2=A0add_project_link_arguments('-lm', language: 'c')
> > +dpdk_extra_ldflags +=3D '-lm'
> > =C2=A0
> > =C2=A0# add -include rte_config to cflags
> > =C2=A0add_project_arguments('-include', 'rte_config.h', language: 'c')
>=20
> This is for static builds, right? If so it should go into the
> Libs.private section of the .pc file, so that it's only used when
> calling pkg-config --static --libs
Bit of a brain fart - what I meant is, in order to have static builds
work out of the box with pkg-config --static, -lm (and any other
dependency used internally) could also be added to Libs.private in the
.pc
--=20
Kind regards,
Luca Boccassi