DPDK patches and discussions
 help / color / mirror / Atom feed
From: SebastianX Basierski <sebastianx.basierski@intel.com>
To: yliu@fridaylinux.org
Cc: dev@dpdk.org,
	SebastianX Basierski <sebastianx.basierski@intel.com>,
	jianfeng.tan@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v3] net/virtio: fix unchecked return value
Date: Tue, 24 Oct 2017 10:17:38 +0200	[thread overview]
Message-ID: <1508833058-17189-1-git-send-email-sebastianx.basierski@intel.com> (raw)
In-Reply-To: <1508821844-37372-2-git-send-email-sebastianx.basierski@intel.com>

Report an error message if the flag O_NONBLOCK setting fails,
then return from function.

Coverity issue: 143439

Fixes: ef53b6030039 ("net/virtio-user: support LSC")
Cc: jianfeng.tan@intel.com
cc: stable@dpdk.org

Signed-off-by: SebastianX Basierski <sebastianx.basierski@intel.com>
Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 drivers/net/virtio/virtio_user_ethdev.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index 57c964d..20b7292 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -86,7 +86,11 @@ virtio_user_read_dev_config(struct virtio_hw *hw, size_t offset,
 			int flags;
 
 			flags = fcntl(dev->vhostfd, F_GETFL);
-			fcntl(dev->vhostfd, F_SETFL, flags | O_NONBLOCK);
+			if (fcntl(dev->vhostfd, F_SETFL,
+					flags | O_NONBLOCK) == -1) {
+				PMD_DRV_LOG(ERR, "error setting O_NONBLOCK flag");
+				return;
+			}
 			r = recv(dev->vhostfd, buf, 128, MSG_PEEK);
 			if (r == 0 || (r < 0 && errno != EAGAIN)) {
 				dev->status &= (~VIRTIO_NET_S_LINK_UP);
-- 
2.7.4

  parent reply	other threads:[~2017-10-24  8:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 11:47 [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library SebastianX Basierski
2017-09-20  0:56 ` Tan, Jianfeng
2017-09-20  9:17   ` Basierski, SebastianX
2017-09-29  7:44   ` Basierski, SebastianX
2017-10-16  8:32     ` Basierski, SebastianX
2017-10-16 14:51       ` Tan, Jianfeng
     [not found] ` <1508821844-37372-1-git-send-email-sebastianx.basierski@intel.com>
2017-10-24  5:10   ` [dpdk-dev] [PATCH v2] Report an error message if the flag O_NONBLOCK setting fails, then return from function SebastianX Basierski
2017-10-24  7:26     ` Tan, Jianfeng
2017-10-24  8:17     ` SebastianX Basierski [this message]
2017-10-24  8:40       ` [dpdk-dev] [PATCH v3] net/virtio: fix unchecked return value Yuanhan Liu
2017-10-24  8:20     ` SebastianX Basierski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508833058-17189-1-git-send-email-sebastianx.basierski@intel.com \
    --to=sebastianx.basierski@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=stable@dpdk.org \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).