From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id D4C321B73F for ; Tue, 24 Oct 2017 14:00:30 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id r68so15797437wmr.3 for ; Tue, 24 Oct 2017 05:00:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=h4x7SCV/e3JvCbUYTSvr73NzBzOxyUgve0gTrlbZudk=; b=Pbv0xXZR0TeJrzq9wPA0Uxvraf+ZuoRiI3WU7yoAkG/LXftEJp+1RFhzYzACMgAX5v 3cP7Eb2h6fUouoFk4xWNuO/aPAtOH5aKIGpMMswcruEAT/1oP0tJwwadPptbIJ4u15t6 J9hx8v8oL9+/F3vuFixd90eH0iPPXStbIXFznprFHMwQebhj2rGVhC02A9FRRVsRmVN0 Xqdxe/3fO1cEI2hHL2zNbBP71uGa6/PEbTO/9FS3Aa2p19tjYYWL2YJsLGbinha50vzJ hA5HhIJ1R/MKtqfBfVe7SBQBp71PRTrPrNIIFD/CcMJKekGCpRjogUnWMy4QmGmuBqFj BhRg== X-Gm-Message-State: AMCzsaVrr1r4o8oUwErTNFmD6am4cMJ6Kh/t+rOWmxkbgB4/s6vje/Z+ sgSp68oiroVwm9w8/g8cGwuXWf+0 X-Google-Smtp-Source: ABhQp+TcR8rreZWp6nvDvexDWh81t4UdQbmplg8wn6SBMVSjw2dqJ21H9vfh7gOlJp8BLQ0sreMr2Q== X-Received: by 10.80.132.232 with SMTP id 95mr20142672edq.294.1508846430489; Tue, 24 Oct 2017 05:00:30 -0700 (PDT) Received: from localhost ([213.251.34.151]) by smtp.gmail.com with ESMTPSA id 3sm91966edv.50.2017.10.24.05.00.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 05:00:29 -0700 (PDT) Message-ID: <1508846428.29685.18.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon , Remy Horton Cc: dev@dpdk.org, wenzhuo.lu@intel.com, wei.dai@intel.com Date: Tue, 24 Oct 2017 13:00:28 +0100 In-Reply-To: <3757028.oCNDDIN3Jm@xps> References: <20171019134827.22740-1-luca.boccassi@gmail.com> <20171019134827.22740-2-luca.boccassi@gmail.com> <3757028.oCNDDIN3Jm@xps> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 12:00:31 -0000 On Tue, 2017-10-24 at 00:11 +0200, Thomas Monjalon wrote: > 19/10/2017 16:53, Remy Horton: > >=20 > > On 19/10/2017 14:48, luca.boccassi@gmail.com wrote: > > > Document it immediately even if it's not yet supported, so that > > > users > > > and developers can already take into account about this use case, > > > and > > > thus avoid an API-incompatible change later on. > >=20 > > I'm not sure about documenting unimplemented features, as API docs > > ought=C2=A0 > > to describe what the code currently does. Then again reason seems > > OK and=C2=A0 > > I don't think there's hard guidelines on this.. >=20 > An API does not need to be implemented to describe its behaviour. > We just have to agree about which behaviour we want to expect. >=20 > It seems this error code is reasonable. > But I am not sure you need to give the details about the cause > of the error. The most important is to advise app writer to retry > resetting later when the device is ready. Isn't it? Sure, makes sense, see v2. --=20 Kind regards, Luca Boccassi