From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0079.outbound.protection.outlook.com [104.47.32.79]) by dpdk.org (Postfix) with ESMTP id 2EF6D1B19C for ; Thu, 26 Oct 2017 04:23:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iPL9Xk4D5Wvu1M8P9LVDiRT9xRTytJYd6xJbU1LRT1Q=; b=h/O9PHXgp48HJwF83LkZeeumC0PDdKYwyRXoB+9yndnWh/lJLMRjgpaZ2WI7+pyjjgX4d/ER0T7DgtyBrDS6AAp5Ou9zvmop5fRjNb8gWzFKFmIL4ZrxLBOOdPu9pVAew447r/pWlkd1J7p7g2Otu0Gwqqj4L9DQwxE+wuuKj2o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Srisivasubramanian.Srinivasan@cavium.com; Received: from localhost.localdomain (106.51.21.182) by CO2PR07MB2551.namprd07.prod.outlook.com (10.166.201.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Thu, 26 Oct 2017 02:23:32 +0000 Message-ID: <1508984598.18159.10.camel@caviumnetworks.com> From: Srisivasubramanian Srinivasan To: ferruh.yigit@intel.com, dev@dpdk.org Date: Thu, 26 Oct 2017 07:53:18 +0530 In-Reply-To: References: <1508820170-7512-1-git-send-email-ssrinivasan@caviumnetworks.com> <1fe096ea-7a18-e7a1-2f64-3a4ce1464caf@intel.com> <1508954815.17549.22.camel@caviumnetworks.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [106.51.21.182] X-ClientProxiedBy: SG2PR0601CA0007.apcprd06.prod.outlook.com (10.170.128.17) To CO2PR07MB2551.namprd07.prod.outlook.com (10.166.201.14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 991a40de-4614-49cb-4755-08d51c188e36 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603238); SRVR:CO2PR07MB2551; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2551; 3:0n6VRm1J9/PKHpagn1G5p5D1Zq2bHNpRdSj5bYY8+0lyu+bEQrGeBE6rLZSg3Hw7VtpRHTwQWKnmLoWWUWWSjY4dgsVJ84vAvUG5NYR4/96/ZhSt/6bUk7mEY86BX1sqKimQ9SF6Mxg4Z9DYjIHii5wnA0BrArqACymr7fz+BFwegZ4aJpqB8vEaNczFwl7bKv8aS91YuL1CopsITeR6MSJbFfe++vMutqnE9g37DePuV49wowIuAuziXeii1Dua; 25:bLvfWra3MOAlTu8u4qAf5RwnafnjLm68biahbNubOcdEI9uJj64XhYSYrhSFOnuVnOqfxU3F1eTWsK/tzlls9/NJ698cH0fh83HHRIQUntqV4ZmHqGpRzrx/DizGtDkDP3oXqKw2DT5/OH4nxCCkwX6UeJjwPB0VsNAXjWjwHpozyAXkhWPBa/oYSurCcOLkmh3J212VWZPGyiZQezijLG8uto7EP77YX2nNqdNamvLyPZWFWSVcU1YyR5/0/8c55OmnOtOBUGhUhwlUbRIgoDL/LzXzuvEqHEkFphcix6fRzCT4TMNOM/KpnBp+bLB2+RjlnhwHh/XawNjFPkE+Dw==; 31:n1ltYI0G/RVc6s5TmT9ORS0tFKLpUuYL+nzlVno9Z68WoPkq2WXEzG6n2ecsLF0qXC0Pjs64O3hTmBKpuftwx9P69xPk1//fGIyXjhRhz1Mk8f0UBQKCjUD4LbgEgyWl/7OJcIsD6HRijIW3F9GT8terKS9mIbIXEdOexvPa5Qs9IyiwkiohZDH/9eMQY4NQ67x73nvkM4QkeNxACKVutVTlGaex4MnQoPH3jQkkpak= X-MS-TrafficTypeDiagnostic: CO2PR07MB2551: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2551; 20:+JrsEyYI/xAAS6kr/uCjLAVjtNTuq1GRA3ukjqstPkexhfhyelnYJfl+0IT+DE3abrCKQi2yGYF1/ynDks1LeSMMSVEiN8yeta6e6pP9ovzUonNVX2XEjWyOboQqoSBUTRzaZdIpnEg2ZWVKRpnMq6OV4l4ftGo3gaYDuVf6pL46dav+L8SNQTrwS23HlgWsTTzThNC2qm3rciJUOE+qCUYSw0JUwcfhs/GnQCBZCJlfDIrldt2OxFi1psDywIrNZ3rnrbR9ZP9o0OWvVELFCtGEAtBBUT0J54wTfVBD+uEpWGghwWr0q0bFzhw1RwLsQtXf+tGPpbFU5bVMAwcE5ZVJwb2zKkVPVf97GBXXJRXihB1Uw+wxfHhEqklyFe2D49SIM74cbn253PD2EURcZVdbgBwdS/9Y0Iv8qLart0tIF6VlrhqU3px+5Kz2tnLmMFqw4o1/trXiuqWBXEknDF3R5XgVDDPxu3nNfeRMWsvYz4SlW3lpaqvJoRSozQ68e+jJ/y5Yk00KrXT7JW2YOzz2K2Pg/sSjlPYqbPeLUq/O9hP4DzVoZFoh3tku5NGBl8qcN4486f93Nv/K0t5uW+6ev+qLAkSD/xRFMqnLJBI=; 4:aL0DgFNBsq3Lu6+UMIm+3dMtMtrmaZ4TOlv/8QP3OR4wa6NHCxQ/Ew0m7AyGiiC5XFqoMPhSZDJEYBWRy5NrGB6SXcLv/bIFnzJbGuvZwQZUK+4ecBksPyqr0aMLU71q7PpoigdDITtPdI9zSUpn2x3w1QPFcTmFhKpscryt8041bte8ymLqtS7RfJMcunXXZq03Hds9+0qZMWyV1pKWyTRUCyoBKh6oECEQ11FpE0KrdOk0xTZKeMcJQWaAWMJH X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(3231020)(93006095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR07MB2551; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR07MB2551; X-Forefront-PRVS: 04724A515E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(376002)(346002)(189002)(24454002)(199003)(377424004)(3846002)(50986999)(305945005)(5660300001)(101416001)(66066001)(47776003)(42882006)(6666003)(2950100002)(36756003)(103116003)(33646002)(93886005)(105586002)(23676002)(81156014)(229853002)(8676002)(106356001)(53546010)(6512007)(81166006)(5820100001)(575784001)(97736004)(4001150100001)(6246003)(72206003)(76176999)(50466002)(7736002)(8936002)(189998001)(53936002)(6116002)(25786009)(6506006)(16526018)(9456002)(478600001)(5009440100003)(6486002)(2906002)(230700001)(316002)(68736007)(50226002)(32040200003)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2551; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjA3TUIyNTUxOzIzOkZnaFovek1yVVZrZGxIR3F1dnZVR0R2enZq?= =?utf-8?B?ZFgwSmVFZFVHaDA3NHk3WmJjSGJCUE9BdngvZjNZNUNLTUFqeWJaV0pMbG1v?= =?utf-8?B?M2hmdXZTRVhxODVKZzIrV0lWZXZFbXpEYmx6QkE2T29ZL0xuK1BuVFRnNCtU?= =?utf-8?B?QXZFTExENFpEY1NTQ20zRE5zN1VzQUFTVlAzTnRkL3lNR3EzUC9IUmFaRk91?= =?utf-8?B?Y205K3lsV2RaUnlpNE85ODlYMjVISEViWEZIRTg2a0xDWndLNXMvTXFGaElu?= =?utf-8?B?am9FUE1vYzJDeWtVTXNldkM3ZVB0a1FGaTdKdS9JaFFBYjdjRUFRRUFGR3pF?= =?utf-8?B?VU5sV3F4R0VRSndyZ3JuencwTm1BL2RGWk4vVnJONS9UY1dubSt1WkVnL0pE?= =?utf-8?B?L016N25TclFFYzkvRmlHOUxueWNnVHVUK3l5OTlVKzlKSUM3cEdKZFpXVmNq?= =?utf-8?B?L1JhSDkzbGJ4a2F2ZHVGRXozNHVzUXNSamdOTGlqVXlHc3RuN2ZjSzB1UWJQ?= =?utf-8?B?N3k2UU9TK1hzZ2tTTktMem9rVlhIS2ZteW1XWTRXaHUzWnBQTUJBQ0FLdzRs?= =?utf-8?B?YjJLVW5HNTB2NTVQVis1aW8vendURE5TZVBpTkdzd3NyT2RjekowUWRrN082?= =?utf-8?B?Tld0ZEk1emswRVYyWDk1bmw1d2hBQmd1T1B4dlNlTEg1RlNqQmRTQ0ptTVND?= =?utf-8?B?d25JZG1nWGFlS3V5ajZyYTdhMWdxeC9GeXc2bGVkcHRtZkdvSUlyMDdQbFRV?= =?utf-8?B?RVMybzZPb3dWTXh6VytNenpzVTMxdmt6ekUzMmNHeDZTcE8wc1ZTQVJZTHF2?= =?utf-8?B?NDNQc1pVVnJ5TjkyNW00RDVOSUhzYzByZVFzc1RKNGtvTlRGV3RsczNqMlc2?= =?utf-8?B?aXJwUkx2YzkvTGt4cnQ2MUFvL2k3TVFOVUFXMEt1MWdKZyt4OHBUN3UxL1BR?= =?utf-8?B?Y290QjFqS1crczBGZm94SVN0VnEvVjhmb3ZrZ09KTWJkSjQ2a05xM1lDbHZE?= =?utf-8?B?ZU0xZEwyeGtMZVlOclBLUHh2WDRPeFUvYXlwTjBUYzZhV1NZRjk4RHlZZGZF?= =?utf-8?B?TW9GYlZqZ1ZPd0VnemY1dDdycWowVmdsKytqY2Ywc3RuNVIyVUk2UnBpV0NX?= =?utf-8?B?OEFtSmhYK0xCaS9iNFNSSiszMVVTK04veTZneXBFUzhOZ2twU3UvQ2NOQ1JI?= =?utf-8?B?eEhrSy9sUG03RUhyS0RRVWpFU1p2YlJNQ1EwNHZPSDZPS2VCck53Wm1zU1lp?= =?utf-8?B?VldFNUw4cHZCL0xBMlN4eUh0YjFLcFZ4Z0psTENHV2dzbEdTcG43bkYrOC9t?= =?utf-8?B?VnpQQlpNNlpNc2tSanBpempEdDY1SjNlUDJQblgxU3BzNUFQKysvR1dadzh3?= =?utf-8?B?dWtpRDVDS2hkTEdWNGNsNjJXWGt0UzdibGpPY2FneGs0T1BsVGJEWFVidmtv?= =?utf-8?B?VURlc2VDNk5qUWEzemlPcVhNQmIyUlUxUGVNMEwveXRZSWJYL2VBeDRlVTdt?= =?utf-8?B?azBlZDlGT0RPc0NRR205WTJkZ3BPeXFoSXRXS01MVEtHVnpjdHV3VFBjNzhR?= =?utf-8?B?bDAyMzZKSGkyM3liVzJQWmVvS3BVY1I0K3l3K1RZUVk0c2tNbGRqaUg5LzUy?= =?utf-8?B?YndMZHBVOVJTOG5OUkIybEk1TTREQ1hqUER1WnhkdklZZzRud2xkRFRpNnZP?= =?utf-8?B?cUJJdnprcFNQb2g1ZU9yTjhFSmtvVjA0ODlrbUl6cXRTS3NSc2FUVDhXSGl4?= =?utf-8?B?T3VhNmcwc0xzTDRSN1JteDU2UHZDRVNBTFM5d0ZVUlNWYjhya0RuTGhNbVhh?= =?utf-8?B?NkN1ekhIZTA0QjhhK1Avdng2V3ZTUGc0cDhZOGlZWlczbmhLbzFzcDBiL29R?= =?utf-8?Q?ckfWT8DCqno=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2551; 6:OXjh5jk+vdKUHcXYXR6Om8wx+uackKfBawh+AHEY05sV/NwFHXVPMKbuAGsWkEWNEBrocVwhf/BCHwhy2SM6EjPuWxiQczZqrzMgY3Gs2PUr+6RoNW15E53cBIUTdrI3xL9X7BDMjqsvgYodMJGxe+Ai0yo0F9viNBXdmHGTOx00TlQTBi9DNC2/vFn3SKEiNIT8H6t+RoDhDQ/z+w3gwTSSfmH8D5zxnrNF28hQq5r/UkBgqJvGZRPrjr5odmLk5KaasqS9EKRHauviDdi5WR+AtExBWMGIvwXLB0DxkZtvy+jkACNvJqszNx36wRgcdhcvuI8tjH7jLT19cDmeUg==; 5:ws50jApx86SPNG/aKTBZ+gSLzTSWWsZNjJWh6lRdlk7O1wCVXHRS0JLys2RMld3q131zSj400QO85GKqgw/cnWVgRF4YiYSbKZwxGYksOYys/23kuQD200ZEqNcOQCXvE9ETx94Q5jMvU6IiJDXsCQ==; 24:mR/7mQYhyWVAvgKPV7bh2igrjoLq4G3k4SF6velyBMZlNPcDSBTu/JRjmEl7bojKTK7OL7ds8kkuuEcT/5vZ//Ei+V+/3L5Sv3AN+EYcKh8=; 7:efqan+CtSjuWDzEfs5qdS0gGkF+q36YJTXIOZEf6ULwKHXzGvTMRYZgnOzJgZ+BmahEW2jFuK/SPo2qCV6a7o7VnstWsXvjQV95DYp/VIyOF5yzYJDQ/GA+s6hg+HTmNYeHeJXgvch9lbhvbSUgymQoqMAsI/rvp46oIqJDiuJ4Or6KYPa+7jjcwBb0NKOYU4NzvM6SNDYXXHCBPQ3uH1nZtgl4H6e+VoeSQ4miLvWc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2017 02:23:32.4601 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 991a40de-4614-49cb-4755-08d51c188e36 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2551 Subject: Re: [dpdk-dev] [PATCH] net/liquidio: add support for 10GBase-T cards X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 02:23:36 -0000 On Wed, 2017-10-25 at 11:23 -0700, Ferruh Yigit wrote: > On 10/25/2017 11:06 AM, Srisivasubramanian Srinivasan wrote: > > On Tue, 2017-10-24 at 10:49 -0700, Ferruh Yigit wrote: > >> On 10/23/2017 9:42 PM, Srisivasubramanian S wrote: > >>> Signed-off-by: Srisivasubramanian S > >>> Signed-off-by: Shijith Thotton > >>> --- > >>> doc/guides/nics/liquidio.rst | 2 ++ > >>> drivers/net/liquidio/base/lio_hw_defs.h | 12 ++++++++---- > >>> drivers/net/liquidio/lio_ethdev.c | 7 ++++++- > >>> 3 files changed, 16 insertions(+), 5 deletions(-) > >>> > >>> diff --git a/doc/guides/nics/liquidio.rst b/doc/guides/nics/liquidio.rst > >>> index 4ccde0c..7bc1604 100644 > >>> --- a/doc/guides/nics/liquidio.rst > >>> +++ b/doc/guides/nics/liquidio.rst > >>> @@ -42,7 +42,9 @@ Supported LiquidIO Adapters > >>> ----------------------------- > >>> > >>> - LiquidIO II CN2350 210SV/225SV > >>> +- LiquidIO II CN2350 210SVPT > >>> - LiquidIO II CN2360 210SV/225SV > >>> +- LiquidIO II CN2360 210SVPT > >> > >> Do you want to update release notes to announce new device support? > > > > Sure, will do. > > > >> > >>> > >>> > >>> Pre-Installation Configuration > >>> diff --git a/drivers/net/liquidio/base/lio_hw_defs.h b/drivers/net/liquidio/base/lio_hw_defs.h > >>> index c7f97f2..d4cd23c 100644 > >>> --- a/drivers/net/liquidio/base/lio_hw_defs.h > >>> +++ b/drivers/net/liquidio/base/lio_hw_defs.h > >>> @@ -43,10 +43,14 @@ > >>> #define LIO_CN23XX_VF_VID 0x9712 > >>> > >>> /* CN23xx subsystem device ids */ > >>> -#define PCI_SUBSYS_DEV_ID_CN2350_210 0x0004 > >>> -#define PCI_SUBSYS_DEV_ID_CN2360_210 0x0005 > >>> -#define PCI_SUBSYS_DEV_ID_CN2360_225 0x0006 > >>> -#define PCI_SUBSYS_DEV_ID_CN2350_225 0x0007 > >>> +#define PCI_SUBSYS_DEV_ID_CN2350_210 0x0004 > >>> +#define PCI_SUBSYS_DEV_ID_CN2360_210 0x0005 > >>> +#define PCI_SUBSYS_DEV_ID_CN2360_225 0x0006 > >>> +#define PCI_SUBSYS_DEV_ID_CN2350_225 0x0007 > >>> +#define PCI_SUBSYS_DEV_ID_CN2350_210SVPN3 0x0008 > >>> +#define PCI_SUBSYS_DEV_ID_CN2360_210SVPN3 0x0009 > >>> +#define PCI_SUBSYS_DEV_ID_CN2350_210SVPT 0x000a > >>> +#define PCI_SUBSYS_DEV_ID_CN2360_210SVPT 0x000b > >>> > >>> /* --------------------------CONFIG VALUES------------------------ */ > >>> > >>> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > >>> index 239f6af..2ffbfd2 100644 > >>> --- a/drivers/net/liquidio/lio_ethdev.c > >>> +++ b/drivers/net/liquidio/lio_ethdev.c > >>> @@ -405,6 +405,10 @@ lio_dev_info_get(struct rte_eth_dev *eth_dev, > >>> /* CN23xx 10G cards */ > >>> case PCI_SUBSYS_DEV_ID_CN2350_210: > >>> case PCI_SUBSYS_DEV_ID_CN2360_210: > >>> + case PCI_SUBSYS_DEV_ID_CN2350_210SVPN3: > >>> + case PCI_SUBSYS_DEV_ID_CN2360_210SVPN3: > >>> + case PCI_SUBSYS_DEV_ID_CN2350_210SVPT: > >>> + case PCI_SUBSYS_DEV_ID_CN2360_210SVPT: > >>> devinfo->speed_capa = ETH_LINK_SPEED_10G; > >>> break; > >>> /* CN23xx 25G cards */ > >>> @@ -413,8 +417,9 @@ lio_dev_info_get(struct rte_eth_dev *eth_dev, > >>> devinfo->speed_capa = ETH_LINK_SPEED_25G; > >>> break; > >>> default: > >>> + devinfo->speed_capa = ETH_LINK_SPEED_10G; > >>> lio_dev_err(lio_dev, > >>> - "Unknown CN23XX subsystem device id. Not setting speed capability.\n"); > >>> + "Unknown CN23XX subsystem device id. Setting 10G as default link speed.\n"); > >> > >> Instead of setting speed and default and print an error log, why not added cases > >> for new devices and set to 10G there? > > > > Our thinking was to avoid error log that come out as not setting link speed when an old > > DPDK driver is used on a LiquidIO VF compliant device that isn?t yet in the driver. > > With old driver, pci device_id also won't be there for new device, and driver > won't probe it at all, so there won't be an issue of not setting link speed, am > I missing something? LiquidIO VF compliant devices all have the same pci device id. Just the subsystem id changes, so probe will be successful. Just that for new devices we will see a log denoting unknown subsystem during dev_info_get() call. Even without this patch, 10GBase-T cards work with the log getting displayed, but we want to avoid that log and explicitly say support starts from this release. > > > This is for forward compliance. We will of course add cases for new devices as they > > come along. Is this reasonable? > > > >> > >>> } > >>> > >>> devinfo->max_rx_queues = lio_dev->max_rx_queues; > >>> > >> > > > > > > > > > > > > > > >