DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix counter set destroy order
@ 2017-10-30 12:46 Ori Kam
  2017-11-01 17:12 ` Yongseok Koh
  0 siblings, 1 reply; 3+ messages in thread
From: Ori Kam @ 2017-10-30 12:46 UTC (permalink / raw)
  To: adrien.mazarguil, nelio.laranjeiro, yskoh; +Cc: dev, orika

The counter set should be destroyed only after the flow was destroyed.

Fixes: 9a761de ("net/mlx5: flow counter support")
Cc: orika@mellanox.com

Signed-off-by: Ori Kam <orika@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 3999b84..e810a3a 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -2001,10 +2001,6 @@ struct rte_flow *
 {
 	unsigned int i;
 
-	if (flow->cs) {
-		claim_zero(ibv_destroy_counter_set(flow->cs));
-		flow->cs = NULL;
-	}
 	if (flow->drop || !flow->mark)
 		goto free;
 	for (i = 0; i != flow->queues_n; ++i) {
@@ -2053,6 +2049,10 @@ struct rte_flow *
 				rte_free(frxq->ibv_attr);
 		}
 	}
+	if (flow->cs) {
+		claim_zero(ibv_destroy_counter_set(flow->cs));
+		flow->cs = NULL;
+	}
 	TAILQ_REMOVE(list, flow, next);
 	DEBUG("Flow destroyed %p", (void *)flow);
 	rte_free(flow);
-- 
1.7.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix counter set destroy order
  2017-10-30 12:46 [dpdk-dev] [PATCH] net/mlx5: fix counter set destroy order Ori Kam
@ 2017-11-01 17:12 ` Yongseok Koh
  2017-11-01 20:26   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2017-11-01 17:12 UTC (permalink / raw)
  To: Ori Kam; +Cc: Adrien Mazarguil, Nélio Laranjeiro, dev


> On Oct 30, 2017, at 5:46 AM, Ori Kam <orika@mellanox.com> wrote:
> 
> The counter set should be destroyed only after the flow was destroyed.
> 
> Fixes: 9a761de ("net/mlx5: flow counter support")
> Cc: orika@mellanox.com
> 
> Signed-off-by: Ori Kam <orika@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix counter set destroy order
  2017-11-01 17:12 ` Yongseok Koh
@ 2017-11-01 20:26   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-11-01 20:26 UTC (permalink / raw)
  To: Yongseok Koh, Ori Kam; +Cc: Adrien Mazarguil, Nélio Laranjeiro, dev

On 11/1/2017 10:12 AM, Yongseok Koh wrote:
> 
>> On Oct 30, 2017, at 5:46 AM, Ori Kam <orika@mellanox.com> wrote:
>>
>> The counter set should be destroyed only after the flow was destroyed.
>>
>> Fixes: 9a761de ("net/mlx5: flow counter support")
>> Cc: orika@mellanox.com
>>
>> Signed-off-by: Ori Kam <orika@mellanox.com>

> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-01 20:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-30 12:46 [dpdk-dev] [PATCH] net/mlx5: fix counter set destroy order Ori Kam
2017-11-01 17:12 ` Yongseok Koh
2017-11-01 20:26   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).