From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id E167C1B3B4 for ; Thu, 2 Nov 2017 11:03:21 +0100 (CET) Received: by mail-wr0-f195.google.com with SMTP id l1so4451530wrc.3 for ; Thu, 02 Nov 2017 03:03:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=WDAQhQsJlLnd0VmofWm+l6NDZohdd+oG04PKucXE1cY=; b=X/ohepxR/S3hsyy6zjZKgrydH5wk68MpS/Y3HszxBJlbTPgkpVVFZlrRB0sO8Zd0yr Gp+O3OO3yHVuEDSKvv/lKScTiokcINnYGfugL4RQfRKe8E3aMZ+McbpB3EL9GeBCbv4O NYnn5Ac+VGAU+9U5Muq+5wzI0HRmEZH3wKm02eFRZIQtaj6SRtQLpeABVZP5sTBoXNPE FEBKJ3yCgYI/W1m7PmmBfZQnzpMw3T0J76qperYgT4KwKrwxQ6cNkVLf1k2x4w0wnjZW lLf5o6/HxNrxAnhLCHAF9s1gx1qS7S+ZTAtC/CjHs6ReRWcqm/YpoHcn6vI8yM3JRLGl sQkA== X-Gm-Message-State: AMCzsaVXMzXQPzZdFEZtMgAwdEZ/K2bPaIY9rk8g4r4hExGJGWe8/7tl cGGAaqEZQ7DO6UOKsDaEbqE= X-Google-Smtp-Source: ABhQp+RtBvfVE64/jt/UBmyLX9wIl7n12Xl1dqsuQC42DFZ0FdX4tiGjscbVd2dbAnp61b2qZhi+yQ== X-Received: by 10.223.193.70 with SMTP id w6mr2492334wre.158.1509617001379; Thu, 02 Nov 2017 03:03:21 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id p128sm2656754wmb.1.2017.11.02.03.03.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 03:03:20 -0700 (PDT) Message-ID: <1509616999.17108.3.camel@debian.org> From: Luca Boccassi To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org Cc: skhare@vmware.com Date: Thu, 02 Nov 2017 10:03:19 +0000 In-Reply-To: <20171101203820.8021-1-3chas3@gmail.com> References: <20171101203820.8021-1-3chas3@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: fix memory leak when releasing queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 10:03:22 -0000 On Wed, 2017-11-01 at 16:38 -0400, Chas Williams wrote: > From: Chas Williams >=20 > At the end of the queue release, we can free the containers for the > queue objects. >=20 > Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver > implementation") >=20 > Signed-off-by: > --- > =C2=A0drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 +++++ > =C2=A01 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c > b/drivers/net/vmxnet3/vmxnet3_rxtx.c > index 01c85f1..18dce72 100644 > --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c > +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c > @@ -203,6 +203,8 @@ vmxnet3_dev_tx_queue_release(void *txq) > =C2=A0 vmxnet3_cmd_ring_release(&tq->cmd_ring); > =C2=A0 /* Release the memzone */ > =C2=A0 rte_memzone_free(tq->mz); > + /* Release the queue */ > + rte_free(tq); > =C2=A0 } > =C2=A0} > =C2=A0 > @@ -223,6 +225,9 @@ vmxnet3_dev_rx_queue_release(void *rxq) > =C2=A0 > =C2=A0 /* Release the memzone */ > =C2=A0 rte_memzone_free(rq->mz); > + > + /* Release the queue */ > + rte_free(rq); > =C2=A0 } > =C2=A0} > =C2=A0 Reviewed-by: Luca Boccassi --=20 Kind regards, Luca Boccassi