From: David Hunt <david.hunt@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com,
Vipin Varghese <vipin.varghese@intel.com>,
David Hunt <david.hunt@intel.com>
Subject: [dpdk-dev] [PATCH v1] mk: allow use of toolchain cflags
Date: Fri, 3 Nov 2017 09:40:03 +0000 [thread overview]
Message-ID: <1509702003-70630-1-git-send-email-david.hunt@intel.com> (raw)
From: Vipin Varghese <vipin.varghese@intel.com>
with 'export TOOLCHAIN_CFLAGS' the values are
not inherited throuhout make system. The change
appends the user defined cflags.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
Signed-off-by: David Hunt <david.hunt@intel.com>
---
mk/toolchain/clang/rte.vars.mk | 6 +++---
mk/toolchain/gcc/rte.vars.mk | 6 +++---
mk/toolchain/icc/rte.vars.mk | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk
index dde922d..1b017db 100644
--- a/mk/toolchain/clang/rte.vars.mk
+++ b/mk/toolchain/clang/rte.vars.mk
@@ -59,9 +59,9 @@ HOSTCC = clang
endif
HOSTAS = as
-TOOLCHAIN_ASFLAGS =
-TOOLCHAIN_CFLAGS =
-TOOLCHAIN_LDFLAGS =
+TOOLCHAIN_ASFLAGS +=
+TOOLCHAIN_CFLAGS +=
+TOOLCHAIN_LDFLAGS +=
WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes
WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith
diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk
index 3b907e2..e52da4d 100644
--- a/mk/toolchain/gcc/rte.vars.mk
+++ b/mk/toolchain/gcc/rte.vars.mk
@@ -59,9 +59,9 @@ HOSTCC = gcc
endif
HOSTAS = as
-TOOLCHAIN_ASFLAGS =
-TOOLCHAIN_CFLAGS =
-TOOLCHAIN_LDFLAGS =
+TOOLCHAIN_ASFLAGS +=
+TOOLCHAIN_CFLAGS +=
+TOOLCHAIN_LDFLAGS +=
ifeq ($(CONFIG_RTE_LIBRTE_GCOV),y)
TOOLCHAIN_CFLAGS += --coverage
diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
index 33a8ba7..70984b7 100644
--- a/mk/toolchain/icc/rte.vars.mk
+++ b/mk/toolchain/icc/rte.vars.mk
@@ -59,9 +59,9 @@ HOSTCC = gcc
endif
HOSTAS = as
-TOOLCHAIN_CFLAGS =
-TOOLCHAIN_LDFLAGS =
-TOOLCHAIN_ASFLAGS =
+TOOLCHAIN_CFLAGS +=
+TOOLCHAIN_LDFLAGS +=
+TOOLCHAIN_ASFLAGS +=
# Turn off some ICC warnings -
# Remark #271 : trailing comma is nonstandard
--
2.7.4
next reply other threads:[~2017-11-03 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 9:40 David Hunt [this message]
2017-11-06 21:07 ` Thomas Monjalon
2017-11-07 0:15 ` Varghese, Vipin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509702003-70630-1-git-send-email-david.hunt@intel.com \
--to=david.hunt@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).