DPDK patches and discussions
 help / color / mirror / Atom feed
From: Radu Nicolau <radu.nicolau@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, konstantin.ananyev@intel.com,
	bruce.richardson@intel.com, ferruh.yigit@intel.com,
	wenzhuo.lu@intel.com, michael.j.glynn@intel.com,
	Radu Nicolau <radu.nicolau@intel.com>
Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix build on gcc 4.5.1
Date: Mon,  6 Nov 2017 11:36:47 +0000	[thread overview]
Message-ID: <1509968207-16465-1-git-send-email-radu.nicolau@intel.com> (raw)
In-Reply-To: <1509965661-17121-1-git-send-email-radu.nicolau@intel.com>

Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")

On SUSE11 with gcc 4.5.1 the following build error occurred,
most likely because of improper handling of annonymous unions:

DPDK/drivers/net/ixgbe/ixgbe_ipsec.c:579:4:
error: unknown field ‘ipsec’ specified in initializer
compilation terminated due to -Wfatal-errors.

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2: additional info added in the commit message.


 drivers/net/ixgbe/ixgbe_ipsec.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c
index 99c0a73..105da11 100644
--- a/drivers/net/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ixgbe/ixgbe_ipsec.c
@@ -576,48 +576,48 @@ ixgbe_crypto_capabilities_get(void *device __rte_unused)
 		{ /* IPsec Inline Crypto ESP Transport Egress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 		},
 		{ /* IPsec Inline Crypto ESP Transport Ingress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = 0
 		},
 		{ /* IPsec Inline Crypto ESP Tunnel Egress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 		},
 		{ /* IPsec Inline Crypto ESP Tunnel Ingress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = 0
 		},
-- 
2.7.5

  parent reply	other threads:[~2017-11-06 11:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 10:54 [dpdk-dev] [PATCH] " Radu Nicolau
2017-11-06 11:14 ` Thomas Monjalon
2017-11-06 11:36 ` Radu Nicolau [this message]
2017-11-07  1:24   ` [dpdk-dev] [PATCH v2] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509968207-16465-1-git-send-email-radu.nicolau@intel.com \
    --to=radu.nicolau@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=michael.j.glynn@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).