From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2ACDA034F; Tue, 6 Apr 2021 12:24:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EC1D140F24; Tue, 6 Apr 2021 12:24:29 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mails.dpdk.org (Postfix) with ESMTP id A1C44140EEB for ; Tue, 6 Apr 2021 12:24:27 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id u11so1187173wrp.4 for ; Tue, 06 Apr 2021 03:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=5IJ1dKn5AtPdAkDF6B6nRhASr85sskALdxnDYER8NGE=; b=TC97ix4ojkMjheubYLevxgWry+sajhI84BNsvN5oXu+5n/H0RhaGHQI7mWEUkDjI6a uHfetMg95+fLL0HJy4JYkW5NIxt+Ebf2ryePYirdpDFfI538yr74c8rCKLhFv2jAfe14 B+FBsT9oani9KB/QjvqJtxbZx2Et6UvhHZxTpgkeHlwtdf9aYSzYdKYKpk7a90MdpHO/ DW3Yxtf5rJNWx32rFfMhTXNr8SpDF5Y0rQ0wwC1lyUKtfiA2DD6DWc9Kia2tGjKERST2 6qbmBZx9qhghmUbkAIgxUEmKbYZM2Rdl1RYnwkyLEXr9T4njoBI6fE+Q5dKIgKsuFH4t oEww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5IJ1dKn5AtPdAkDF6B6nRhASr85sskALdxnDYER8NGE=; b=mGbzw9WlII2jbcecgWqOy8zAb1NHPu3KmBI4wuZHW0VOBy9IZTjh+sz6jrej+RvLXG aJCZSk/YRjyYP2Tb50NOliR/4RoWLKN96Hv+KguTxFVCdiO85d/Zxa00T4iJvHiP0YKx r7cebqKTMXXyj/V5d2Sz28UG3+KSSX1i7+eWwAAI/KcRufRT0Xz0AzA6SjHIxqk4/VCp CLlGpQrY0tq1ACkhUsUi4bSKlVBxn/HksKT9j6G+OYUuRk4Qzbk2Oa+Zg4GRD4nOz4gi U+ym7EGL+RHwaBUbVKxEEorbGA9m97oPVAWptOhIVyqwzrOvST8idvkIJe63l+baiuem 5uXA== X-Gm-Message-State: AOAM530cDoHliepVBYYNh8K+U2KzijrkbkysVWD/LOKTXURdLVlwHSuL rKNHCmJmWhhfCmxVuFIBwy7zLQ== X-Google-Smtp-Source: ABdhPJw5pvovm8GORsi8VIqj9IbeKIdn8ib4A++tmR/POQpcbllVA9HlITM1j74CoRbgvU92HC48Gw== X-Received: by 2002:adf:e907:: with SMTP id f7mr17115990wrm.225.1617704667258; Tue, 06 Apr 2021 03:24:27 -0700 (PDT) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id l9sm2168325wmq.2.2021.04.06.03.24.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Apr 2021 03:24:26 -0700 (PDT) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Dmitry Kozlyuk Cc: Bruce Richardson , Ranjit Menon , dev@dpdk.org, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, stable@dpdk.org References: <20210401122723.23082-1-nick.connolly@mayadata.io> <20210404030003.54bf9565@sovereign> Message-ID: <150aaea8-8da3-4d40-56d3-ee5baf9aa1e6@mayadata.io> Date: Tue, 6 Apr 2021 11:24:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210404030003.54bf9565@sovereign> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] build: fix symlink of drivers for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > PDB (debuginfo) files can be quite large, do we want to install them? The script copies will only copy the .pdb files if they have already been installed into lib/dpdk/pmds-*/. If they haven't, we'll just skip the step. Whether they should be installed is a different question :-) Installing them seems to be a deliberate choice by meson (https://github.com/mesonbuild/meson/issues/1442). In my opinion, it's probably best to have them there. I looked at options apart from copying (including hard links) but in the end decided to keep it as simple as possible so it will 'just work' for cross builds from Linux, WSL-1, WSL-2, Msys, Cygnus etc. > +meson.add_install_script(py3, '../buildtools/symlink-drivers-solibs.py', > + get_option('libdir'), pmd_subdir_opt, get_option('bindir')) > > # set the machine type and cflags for it > if meson.is_cross_build() > As you may have seen, build fails because find_program() result cannot be > used in meson.add_install_script() until 0.55. Since your script has > Unix-specific part anyway and Windows recommends Meson 0.56, maybe Unices > should continue using shell variant and Python script can be Windows-only. Yes, I 'd been thinking about the best way to handle this. Your suggestion of having both scripts may well be the best option in the short term. Thanks, Nick