From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4C2A45B68; Fri, 18 Oct 2024 11:11:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 962854028F; Fri, 18 Oct 2024 11:11:22 +0200 (CEST) Received: from fhigh-a1-smtp.messagingengine.com (fhigh-a1-smtp.messagingengine.com [103.168.172.152]) by mails.dpdk.org (Postfix) with ESMTP id 2497540281 for <dev@dpdk.org>; Fri, 18 Oct 2024 11:11:21 +0200 (CEST) Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id 9990811400DF; Fri, 18 Oct 2024 05:11:20 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Fri, 18 Oct 2024 05:11:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1729242680; x=1729329080; bh=0a8EGZP+P7G/++/8V7s9/QXTf7ARxgutIqXyWtA16pM=; b= WA9ndqYaeQxgcBu/TH7mRZwZJGlVewASs4mcMVPOy0544jVYeP85lduc56INgTqc 8IFhi8xkDY/WQ2BoPAHMzjwZgCruxvH170VQOEE0Mm43GWdQ1KKdt421gUU2158+ KpM9Kho7acc7PXr9c4d/xc8vVTHyMx8a9XVYsXZdAJguNykZjLxlC9KdMBGBgXu+ u3dYgWtdu1sqX4B3Poqts8HIepT9L4sYqOaj00JssfSbYA3dhtFl2/sLG9PYQ2gd QLuixkrt4TnxhHA5OpGzWWQl5pJFr2I81wCnRDjba5B/xLvDE4ncRe0fjiECa5n/ URoB1klie53Gy7J+7j73GQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1729242680; x= 1729329080; bh=0a8EGZP+P7G/++/8V7s9/QXTf7ARxgutIqXyWtA16pM=; b=M RrmzcJPHlZU5KnP+8uDSXtjzDeuxgHg+3afZK6sDIBRlGKt+vEH8oXbneCqvN+KP YiOuteO8tzE70R1G+Vbi9YUKrKmtz+mlSnfxrvzr9fy81YXX6Nf89Jb5tjAw1zMV Xq38hq/9xwgumKmQb4L0qekt+fvJaSIOxuAMDqIiovqu+7AQEitH/iR82PHfMKeP ynbgMa/fb+R0i2Tz6zzs0GYohO8zVhVbmSJ+mdx78mGDy4A6Qc3ImSzfiqZQWLqG 1BXDLLUa0VsEiA5wLLQnFcLspxWr90hcZcdHBP1ZvVXZbZEdXr0oqqO4nb1YnZeM 5IEtFB1w8ui17c6tP6HPg== X-ME-Sender: <xms:OCYSZyp0b0yTaGjbU4YmzjTilqpZIsL1NFdEytsJS81HPg3kCsuAUQ> <xme:OCYSZwpOgHgDFe04LtC-TwEmMj5vic3mWqrEvt4R5jnt6gHuzqs0oRrA91kcc6ev4 BxhyPylEYt8Ifr08g> X-ME-Received: <xmr:OCYSZ3OOVinEH6sFKR8jlkwHwEpsmNZd_T4uuJd9E-UDpyk97-S_gc_1JrmyFqC_hJK5LE__4xiO3wH56oVYu9leWg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehfedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedt heevtdekiedvueeuvdeiuddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehmsgessh hmrghrthhshhgrrhgvshihshhtvghmshdrtghomhdprhgtphhtthhopeguvghvseguphgu khdrohhrgh X-ME-Proxy: <xmx:OCYSZx5lva5u1nlnnm3GfVVRFj0cusl2sSGQQUXcpsLLopaZ4Og2Rw> <xmx:OCYSZx7GaAdrhA2cKE8XRo0NI1xhbP92O5hu6I6Era6kgGxZVbRXUQ> <xmx:OCYSZxjrKXKIUdKTWJltFHivITvFEWceupuLCXrY8d6vaHp_re5gHw> <xmx:OCYSZ746zkHkSblPkAO4kmK7Mo1FMUuxYhgcGwaZ8TKfULM8nvXpMw> <xmx:OCYSZxE5rwiQWQgUVTv80JDiz2entODLL0RqKCKSyckjOBq0IGKOnLSj> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Oct 2024 05:11:19 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Morten =?UTF-8?B?QnLDuHJ1cA==?= <mb@smartsharesystems.com> Cc: dev@dpdk.org Subject: Re: [PATCH] net: improve vlan header type alignment Date: Fri, 18 Oct 2024 11:11:18 +0200 Message-ID: <15105967.O6BkTfRZtg@thomas> In-Reply-To: <20241013083554.97489-1-mb@smartsharesystems.com> References: <20241013083554.97489-1-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 13/10/2024 10:35, Morten Br=C3=B8rup: > Ethernet packets can be VLAN tagged, i.e. an Ethernet header can have a > VLAN tag (a.k.a. VLAN header) embedded. > Since the Ethernet header is 2 byte aligned, and the VLAN tag is directly > related to the Ethernet header, the VLAN tag is also 2 byte aligned, so > packing the VLAN tag structure is not necessary. >=20 > Furthermore, the Ethernet header type is implictly 2 byte aligned, so > removed the superfluous explicit 2 byte alignment. >=20 > Added static_asserts to verify the size and alignment of the various > Ethernet types. >=20 > Signed-off-by: Morten Br=C3=B8rup <mb@smartsharesystems.com> Applied, thanks.