From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from netronome.com (host-79-78-33-110.static.as9105.net [79.78.33.110]) by dpdk.org (Postfix) with ESMTP id 00B8E1B27F; Fri, 17 Nov 2017 19:23:35 +0100 (CET) Received: from netronome.com (localhost [127.0.0.1]) by netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id vAHINYNQ008805; Fri, 17 Nov 2017 18:23:34 GMT Received: (from alucero@localhost) by netronome.com (8.14.4/8.14.4/Submit) id vAHINYUA008804; Fri, 17 Nov 2017 18:23:34 GMT From: Alejandro Lucero To: dev@dpdk.org Cc: stable@dpdk.org Date: Fri, 17 Nov 2017 18:23:34 +0000 Message-Id: <1510943014-8767-1-git-send-email-alejandro.lucero@netronome.com> X-Mailer: git-send-email 1.9.1 Subject: [dpdk-dev] [PATCH] net/nfp: fix check when jumbos and strip CRC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 18:23:36 -0000 We have two problems here. First the jumbo frame check should not be there at all. Then, the configuration should not fail in any case related to CRC striping. Fixes: defb9a5dd156 ("nfp: introduce driver initialization") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 0501156..99401c5 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -488,13 +488,8 @@ enum nfp_qcp_ptr { return -EINVAL; } - if (rxmode->jumbo_frame) - /* this is handled in rte_eth_dev_configure */ - - if (rxmode->hw_strip_crc) { - PMD_INIT_LOG(INFO, "strip CRC not supported"); - return -EINVAL; - } + if (!rxmode->hw_strip_crc) + PMD_INIT_LOG(INFO, "avoid CRC strip is not supported by HW"); if (rxmode->enable_scatter) { PMD_INIT_LOG(INFO, "Scatter not supported"); -- 1.9.1