From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 81B5B9E7 for ; Fri, 10 Jul 2015 12:36:13 +0200 (CEST) Received: by wgxm20 with SMTP id m20so62422071wgx.3 for ; Fri, 10 Jul 2015 03:36:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=KQwc9KyKsoV3HFzzDzrBgx1BpABkBTdoilVsoSNW320=; b=JpQe5CY8cR0/jWdNSQJIvjRh6BxpCy78Q46xQd/vKLa/SCh6W8rX4lPg74CgjpMvmA DfMTMMqnQOgq+Ue5pBEJeKsO1FISJIfmA5pDieQjgm7WfPO42Hb+vINxyOfngNAguEpp saxRhMcO8pg6hZQEZlvvnXFcVmB25QPAGoGqiM07xWRilleJxj+vqLjRLRdQa9XthkKc +qxXFcUApUETmRj8ILKl4zcKTzEsak9Mrm6IGnfvq45oI0gfRontRQ9v/T5LsxvFmIYf txc/tVHzyIRXhim+9ZvurY7lMWUe0/fj204rZEn5jDOuLS9IVAH8Ohcj4Pxuk5o74ixL AyVA== X-Gm-Message-State: ALoCoQmtDX4QNwZuKPRJzx2JlmkD2LhF3NivBJvA32vofdWcOGlqw/rn0f+UidmT3/5G7reAbeO7 X-Received: by 10.180.37.133 with SMTP id y5mr4881382wij.7.1436524573415; Fri, 10 Jul 2015 03:36:13 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id o6sm2280400wiz.16.2015.07.10.03.36.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Jul 2015 03:36:12 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Date: Fri, 10 Jul 2015 12:35:05 +0200 Message-ID: <1511524.5JONc7566D@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150710091159.GA10556@bricha3-MOBL3> References: <1436444378-29106-2-git-send-email-pablo.de.lara.guarch@intel.com> <1436460870-30022-2-git-send-email-pablo.de.lara.guarch@intel.com> <20150710091159.GA10556@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4] test/hash: improve hash unit tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 10:36:13 -0000 2015-07-10 10:11, Bruce Richardson: > On Thu, Jul 09, 2015 at 05:54:30PM +0100, Pablo de Lara wrote: > > Add new unit test for calculating the average table utilization, > > using random keys, based on number of entries that can be added > > until we encounter one that cannot be added (bucket if full). > > > > Also, replace current hash_perf unit test to see performance more clear. > s/clear/clearly/ > > > The current hash_perf unit test takes too long and add keys that > > may or may not fit in the table and look up/delete that may not be > > in the table. This new unit test gets a set of keys that we know > > that fits in the table, and then measure the time to add/look up/delete > > them. > > > > Mind that performance numbers include time to take a random key > s/Mind/Note/ > > > from a pre-made array of keys, plus a quick check of return value. > > Also, as stated above, expect higher numbers, as all operations > > in the new unit tests will be successful, which means that > > it will take more time, than mixing both successful and unsuccesful > > operations. > > > > Signed-off-by: Pablo de Lara > > Looks good, Pablo. > Thomas, perhaps you could make the above minor changes to > the commit log when applying the patch. > > Acked-by: Bruce Richardson Applied with above comments, thanks