* [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst
@ 2017-11-25 22:11 Billy O'Mahony
2017-11-27 10:35 ` Trahe, Fiona
0 siblings, 1 reply; 6+ messages in thread
From: Billy O'Mahony @ 2017-11-25 22:11 UTC (permalink / raw)
To: declan.doherty, dev; +Cc: Billy O'Mahony
Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
---
doc/guides/cryptodevs/qat.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index cb17b6b..c8ef378 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -166,7 +166,7 @@ Next, you need to expose the Virtual Functions (VFs) using the sysfs file system
First find the BDFs (Bus-Device-Function) of the physical functions (PFs) of
your device, e.g.::
- lspci -d : 37c8
+ lspci -d:37c8
You should see output similar to::
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst
2017-11-25 22:11 [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst Billy O'Mahony
@ 2017-11-27 10:35 ` Trahe, Fiona
0 siblings, 0 replies; 6+ messages in thread
From: Trahe, Fiona @ 2017-11-27 10:35 UTC (permalink / raw)
To: O Mahony, Billy, Doherty, Declan, dev; +Cc: O Mahony, Billy
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Billy O'Mahony
> Sent: Saturday, November 25, 2017 10:11 PM
> To: Doherty, Declan <declan.doherty@intel.com>; dev@dpdk.org
> Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> Subject: [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst
>
> Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst
@ 2017-11-27 11:13 Billy O'Mahony
2017-11-27 11:20 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 6+ messages in thread
From: Billy O'Mahony @ 2017-11-27 11:13 UTC (permalink / raw)
To: pablo.de.lara.guarch, dev; +Cc: Billy O'Mahony
Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
---
doc/guides/cryptodevs/qat.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index cb17b6b..c8ef378 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -166,7 +166,7 @@ Next, you need to expose the Virtual Functions (VFs) using the sysfs file system
First find the BDFs (Bus-Device-Function) of the physical functions (PFs) of
your device, e.g.::
- lspci -d : 37c8
+ lspci -d:37c8
You should see output similar to::
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst
2017-11-27 11:13 Billy O'Mahony
@ 2017-11-27 11:20 ` De Lara Guarch, Pablo
2017-11-27 15:33 ` O Mahony, Billy
2017-12-11 10:40 ` De Lara Guarch, Pablo
0 siblings, 2 replies; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2017-11-27 11:20 UTC (permalink / raw)
To: O Mahony, Billy, dev
> -----Original Message-----
> From: O Mahony, Billy
> Sent: Monday, November 27, 2017 11:14 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> Subject: [PATCH] cryptodev: Fix typo in qat.rst
>
> Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
> ---
> doc/guides/cryptodevs/qat.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index cb17b6b..c8ef378 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -166,7 +166,7 @@ Next, you need to expose the Virtual Functions
> (VFs) using the sysfs file system First find the BDFs (Bus-Device-Function) of
> the physical functions (PFs) of your device, e.g.::
>
> - lspci -d : 37c8
> + lspci -d:37c8
>
> You should see output similar to::
>
> --
> 2.7.4
Hi Billy,
Since this is a patch for documentation, the title should start with "doc:",
as "cryptodev: ..." suggests that the patch is fixing something in the library code.
I will fix it for you, since the rest of the patch looks ok to me.
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst
2017-11-27 11:20 ` De Lara Guarch, Pablo
@ 2017-11-27 15:33 ` O Mahony, Billy
2017-12-11 10:40 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 6+ messages in thread
From: O Mahony, Billy @ 2017-11-27 15:33 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev
Thanks, Pablo. Will remember for future ref.
Cheers,
Billy
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday, November 27, 2017 11:20 AM
> To: O Mahony, Billy <billy.o.mahony@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] cryptodev: Fix typo in qat.rst
>
>
>
> > -----Original Message-----
> > From: O Mahony, Billy
> > Sent: Monday, November 27, 2017 11:14 AM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> > dev@dpdk.org
> > Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> > Subject: [PATCH] cryptodev: Fix typo in qat.rst
> >
> > Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
> > ---
> > doc/guides/cryptodevs/qat.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/doc/guides/cryptodevs/qat.rst
> > b/doc/guides/cryptodevs/qat.rst index cb17b6b..c8ef378 100644
> > --- a/doc/guides/cryptodevs/qat.rst
> > +++ b/doc/guides/cryptodevs/qat.rst
> > @@ -166,7 +166,7 @@ Next, you need to expose the Virtual Functions
> > (VFs) using the sysfs file system First find the BDFs
> > (Bus-Device-Function) of the physical functions (PFs) of your device, e.g.::
> >
> > - lspci -d : 37c8
> > + lspci -d:37c8
> >
> > You should see output similar to::
> >
> > --
> > 2.7.4
>
> Hi Billy,
>
> Since this is a patch for documentation, the title should start with "doc:", as
> "cryptodev: ..." suggests that the patch is fixing something in the library code.
>
> I will fix it for you, since the rest of the patch looks ok to me.
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst
2017-11-27 11:20 ` De Lara Guarch, Pablo
2017-11-27 15:33 ` O Mahony, Billy
@ 2017-12-11 10:40 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2017-12-11 10:40 UTC (permalink / raw)
To: De Lara Guarch, Pablo, O Mahony, Billy, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Monday, November 27, 2017 11:20 AM
> To: O Mahony, Billy <billy.o.mahony@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst
>
>
>
> > -----Original Message-----
> > From: O Mahony, Billy
> > Sent: Monday, November 27, 2017 11:14 AM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> > dev@dpdk.org
> > Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> > Subject: [PATCH] cryptodev: Fix typo in qat.rst
> >
> > Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
> > ---
> > doc/guides/cryptodevs/qat.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/doc/guides/cryptodevs/qat.rst
> > b/doc/guides/cryptodevs/qat.rst index cb17b6b..c8ef378 100644
> > --- a/doc/guides/cryptodevs/qat.rst
> > +++ b/doc/guides/cryptodevs/qat.rst
> > @@ -166,7 +166,7 @@ Next, you need to expose the Virtual Functions
> > (VFs) using the sysfs file system First find the BDFs
> > (Bus-Device-Function) of the physical functions (PFs) of your device, e.g.::
> >
> > - lspci -d : 37c8
> > + lspci -d:37c8
> >
> > You should see output similar to::
> >
> > --
> > 2.7.4
>
> Hi Billy,
>
> Since this is a patch for documentation, the title should start with "doc:", as
> "cryptodev: ..." suggests that the patch is fixing something in the library
> code.
>
> I will fix it for you, since the rest of the patch looks ok to me.
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-11 10:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-25 22:11 [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst Billy O'Mahony
2017-11-27 10:35 ` Trahe, Fiona
2017-11-27 11:13 Billy O'Mahony
2017-11-27 11:20 ` De Lara Guarch, Pablo
2017-11-27 15:33 ` O Mahony, Billy
2017-12-11 10:40 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).