* [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue
@ 2017-11-30 6:36 Beilei Xing
2017-12-22 1:26 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Beilei Xing @ 2017-11-30 6:36 UTC (permalink / raw)
To: jingjing.wu; +Cc: dev, stable
Failed to create two FDIR rules with different vlan id for
the same PCTYPE. Root cause is that wrong hash key length
is used.
Fixes: 4149825bbdb9 ("net/i40e: finish integration FDIR with generic flow API")
Cc: stable@dpdk.org
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 811cc9f..583f100 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -1006,7 +1006,7 @@ i40e_init_fdir_filter_list(struct rte_eth_dev *dev)
struct rte_hash_parameters fdir_hash_params = {
.name = fdir_hash_name,
.entries = I40E_MAX_FDIR_FILTER_NUM,
- .key_len = sizeof(struct rte_eth_fdir_input),
+ .key_len = sizeof(struct i40e_fdir_input),
.hash_func = rte_hash_crc,
.hash_func_init_val = 0,
.socket_id = rte_socket_id(),
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue
2017-11-30 6:36 [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue Beilei Xing
@ 2017-12-22 1:26 ` Zhang, Qi Z
2018-01-09 7:34 ` Zhang, Helin
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Qi Z @ 2017-12-22 1:26 UTC (permalink / raw)
To: Xing, Beilei, Wu, Jingjing; +Cc: dev, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> Sent: Thursday, November 30, 2017 2:36 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue
>
> Failed to create two FDIR rules with different vlan id for the same PCTYPE.
> Root cause is that wrong hash key length is used.
>
> Fixes: 4149825bbdb9 ("net/i40e: finish integration FDIR with generic flow
> API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 811cc9f..583f100 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -1006,7 +1006,7 @@ i40e_init_fdir_filter_list(struct rte_eth_dev *dev)
> struct rte_hash_parameters fdir_hash_params = {
> .name = fdir_hash_name,
> .entries = I40E_MAX_FDIR_FILTER_NUM,
> - .key_len = sizeof(struct rte_eth_fdir_input),
> + .key_len = sizeof(struct i40e_fdir_input),
> .hash_func = rte_hash_crc,
> .hash_func_init_val = 0,
> .socket_id = rte_socket_id(),
> --
> 2.5.5
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue
2017-12-22 1:26 ` Zhang, Qi Z
@ 2018-01-09 7:34 ` Zhang, Helin
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Helin @ 2018-01-09 7:34 UTC (permalink / raw)
To: Zhang, Qi Z, Xing, Beilei, Wu, Jingjing; +Cc: dev, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Friday, December 22, 2017 9:27 AM
> To: Xing, Beilei; Wu, Jingjing
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> > Sent: Thursday, November 30, 2017 2:36 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue
> >
> > Failed to create two FDIR rules with different vlan id for the same PCTYPE.
> > Root cause is that wrong hash key length is used.
> >
> > Fixes: 4149825bbdb9 ("net/i40e: finish integration FDIR with generic
> > flow
> > API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 811cc9f..583f100 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -1006,7 +1006,7 @@ i40e_init_fdir_filter_list(struct rte_eth_dev *dev)
> > struct rte_hash_parameters fdir_hash_params = {
> > .name = fdir_hash_name,
> > .entries = I40E_MAX_FDIR_FILTER_NUM,
> > - .key_len = sizeof(struct rte_eth_fdir_input),
> > + .key_len = sizeof(struct i40e_fdir_input),
> > .hash_func = rte_hash_crc,
> > .hash_func_init_val = 0,
> > .socket_id = rte_socket_id(),
> > --
> > 2.5.5
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-09 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-30 6:36 [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue Beilei Xing
2017-12-22 1:26 ` Zhang, Qi Z
2018-01-09 7:34 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).