DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <bruce.richardson@intel.com>,
	<nhorman@tuxdriver.com>,
	Michal Kobylinski <michalx.kobylinski@intel.com>,
	<stable@dpdk.org>
Subject: [dpdk-dev] [PATCH v3 2/5] lpm: fix compilation on ARM BE
Date: Mon, 18 Dec 2017 13:26:46 +0530	[thread overview]
Message-ID: <1513583809-3926-2-git-send-email-hemant.agrawal@nxp.com> (raw)
In-Reply-To: <1513583809-3926-1-git-send-email-hemant.agrawal@nxp.com>

Compiling on ARM BE using Linaro toolchain caused following
error/warnings.

rte_lpm.c: In function ‘add_depth_big_v20’:
rte_lpm.c:911:4: error: braces around scalar initializer [-Werror]
    { .group_idx = (uint8_t)tbl8_group_index, },
    ^
rte_lpm.c:911:4: note: (near initialization for
	‘new_tbl24_entry.depth’)
rte_lpm.c:911:6:error: field name not in record or union initializer
    { .group_idx = (uint8_t)tbl8_group_index, },
      ^
rte_lpm.c:911:6: note: (near initialization for
	‘new_tbl24_entry.depth’)
rte_lpm.c:914:13: error: initialized field overwritten
	[-Werror=override-init]
    .depth = 0,

Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field")
Cc: Michal Kobylinski <michalx.kobylinski@intel.com>
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v3: reverting ifdef
v2: adding ifdef

 lib/librte_lpm/rte_lpm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c
index e1f1fad..dda74a9 100644
--- a/lib/librte_lpm/rte_lpm.c
+++ b/lib/librte_lpm/rte_lpm.c
@@ -912,7 +912,7 @@ add_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth,
 		 */
 
 		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-			{ .group_idx = (uint8_t)tbl8_group_index, },
+			.group_idx = (uint8_t)tbl8_group_index,
 			.valid = VALID,
 			.valid_group = 1,
 			.depth = 0,
@@ -958,7 +958,7 @@ add_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth,
 		 */
 
 		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-				{ .group_idx = (uint8_t)tbl8_group_index, },
+				.group_idx = (uint8_t)tbl8_group_index,
 				.valid = VALID,
 				.valid_group = 1,
 				.depth = 0,
@@ -1365,7 +1365,7 @@ delete_depth_small_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked,
 		 */
 
 		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-			{.next_hop = lpm->rules_tbl[sub_rule_index].next_hop,},
+			.next_hop = lpm->rules_tbl[sub_rule_index].next_hop,
 			.valid = VALID,
 			.valid_group = 0,
 			.depth = sub_rule_depth,
@@ -1668,7 +1668,7 @@ delete_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked,
 	} else if (tbl8_recycle_index > -1) {
 		/* Update tbl24 entry. */
 		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-			{ .next_hop = lpm->tbl8[tbl8_recycle_index].next_hop, },
+			.next_hop = lpm->tbl8[tbl8_recycle_index].next_hop,
 			.valid = VALID,
 			.valid_group = 0,
 			.depth = lpm->tbl8[tbl8_recycle_index].depth,
-- 
2.7.4

  reply	other threads:[~2017-12-18  7:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 10:08 [dpdk-dev] [PATCH 1/5] pmdinfogen: fix cross compilation for " Hemant Agrawal
2017-11-02 10:08 ` [dpdk-dev] [PATCH 2/5] lpm: fix compilation on " Hemant Agrawal
2017-12-11 12:41   ` Bruce Richardson
2017-12-13 12:23     ` Hemant Agrawal
2017-11-02 10:08 ` [dpdk-dev] [PATCH 3/5] bus/dpaa: " Hemant Agrawal
2017-11-02 10:08 ` [dpdk-dev] [PATCH 4/5] net/i40e: " Hemant Agrawal
2017-11-03  3:03   ` Xing, Beilei
2017-11-02 10:08 ` [dpdk-dev] [PATCH 5/5] net/ixgbe: " Hemant Agrawal
2017-12-11 12:42   ` Bruce Richardson
2017-12-11 12:40 ` [dpdk-dev] [PATCH 1/5] pmdinfogen: fix cross compilation for " Bruce Richardson
2017-12-11 18:58   ` Neil Horman
2017-12-13 11:52     ` Hemant Agrawal
2017-12-13 12:19       ` Neil Horman
2017-12-13 12:52 ` [dpdk-dev] [PATCH v2 " Hemant Agrawal
2017-12-13 12:52   ` [dpdk-dev] [PATCH v2 2/5] lpm: fix compilation on " Hemant Agrawal
2017-12-13 13:22     ` Bruce Richardson
2017-12-18  7:50       ` Hemant Agrawal
2017-12-13 12:52   ` [dpdk-dev] [PATCH v2 3/5] bus/dpaa: " Hemant Agrawal
2017-12-13 12:52   ` [dpdk-dev] [PATCH v2 4/5] net/i40e: " Hemant Agrawal
2017-12-13 12:52   ` [dpdk-dev] [PATCH v2 5/5] net/ixgbe: " Hemant Agrawal
2017-12-18  7:56   ` [dpdk-dev] [PATCH v3 1/5] pmdinfogen: fix cross compilation for " Hemant Agrawal
2017-12-18  7:56     ` Hemant Agrawal [this message]
2017-12-18  7:56     ` [dpdk-dev] [PATCH v3 3/5] bus/dpaa: fix compilation on " Hemant Agrawal
2017-12-18  7:56     ` [dpdk-dev] [PATCH v3 4/5] net/i40e: " Hemant Agrawal
2017-12-18  7:56     ` [dpdk-dev] [PATCH v3 5/5] net/ixgbe: " Hemant Agrawal
2018-01-12 16:27     ` [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] pmdinfogen: fix cross compilation for " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513583809-3926-2-git-send-email-hemant.agrawal@nxp.com \
    --to=hemant.agrawal@nxp.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=michalx.kobylinski@intel.com \
    --cc=nhorman@tuxdriver.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).