From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr60050.outbound.protection.outlook.com [40.107.6.50]) by dpdk.org (Postfix) with ESMTP id B9F301B01B for ; Tue, 19 Dec 2017 18:14:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ypn/+DCQmnD5N0oRrAbStbr/VDK6GjqvqZQHAQJmRy4=; b=EanzhHm2UdF7l+yxS6fbjGQ3GMm+wcoL8C3DtWeJ7F8sv7V9QR9bTePcpDEDLJ7DuBdkGY5X2aBY79Foy/bT0jfpfrE8VHtR/CZZYYidLm0Kp7NeK6T2aGYnWmylsX4fNoHPVvd/BPvwVeCDmjs/2pyH6dQE/yGk8LozBr0JQlU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0502MB3659.eurprd05.prod.outlook.com (2603:10a6:7:85::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Tue, 19 Dec 2017 17:14:52 +0000 From: Matan Azrad To: Gaetan Rivet Cc: dev@dpdk.org Date: Tue, 19 Dec 2017 17:14:28 +0000 Message-Id: <1513703669-29363-3-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1513703669-29363-1-git-send-email-matan@mellanox.com> References: <1513703669-29363-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0102CA0086.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::27) To HE1PR0502MB3659.eurprd05.prod.outlook.com (2603:10a6:7:85::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de6158e8-2539-4cf4-db8f-08d547040514 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307); SRVR:HE1PR0502MB3659; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 3:GaKfw5W6SYazZu1NuSOjKX7DRBrW5oUsm70EdTDR5juhQORblxiurngibp7VhYXzzl+nZP+7vRJullNLlogR64D7Ffv6LuAlPflfXnoBNeUBfOLCw6DghQqtQIxhpoGbyrwSBHKoW83Eh6CQky87tV6Ok4b8Nl9+y4/BK6lSnwcawwhZ6ugwBhFsuZublfH4ROKClaMR/q8eNmlT0lcuGJ4WnHpDHZBgpRz3gFlng/MznRJEWmQfJRh4cg8gVNVi; 25:RtWe50O3y/RH4X5+8Ngvgj8At0H9Y7Hltznejdv75YzpwfgDyOoPdOedXJoYBMJgO+uhwxFMJ7FmL4V/7B4fQBP7A3nXLY8yAPN1GlbOAnts19xbmfMuz+Yi36LpR0MMZn2h4pH8Et9Kv3Ufz9FaTj3KORyQzScGyVwqufbRC3LnWeS15Y+f8b6U6nc4bt/4G1KGHVjNabD4zwdwxj/Wnffv47hFjE2kGJ3po9rgRXImOKk6sXsgf2DQWfeI2jCHujNnK501+4zNkjGDz34EkMq4CETKb2b3AoNqivw6TIchfqz9mb+3JbBA6yQozw+dzVX6xM9/g7KD/z9cVpcIZw==; 31:re1VlNUzzqGLwhTAZe/WuUt1udyp5T7Z6JHTEQ8clsaAV4K0mk/vMVfhKFyPmj61HC8Wc1oGXlql9SZZP72BsO9nlUFH+zwgetPreK/tvye6YJGHQ8k9J0rmG2s0rxcRZECE0O6EQfsxknJuW/Wc2tRPdTjXyQdlmpj7fiMpP2A1xjFAUZsrxzWk/PhO1N75oueSyUenX8RzXkz6GQ5Y3or6Szjz+Tg6Z9O2C/CYR5Q= X-MS-TrafficTypeDiagnostic: HE1PR0502MB3659: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 20:SoJwan7faTGjiZOctKYSCSL8x+IOr0g6/b/tEXJ5tsKMa01PMl8aBKtprMPMh0DfsF9VMvqrojV15snHQPseqCZjNS+8Ft7lGhubHS02Y0B3aqEMz3VKnyI2BD7XLakZBw8TwRyRqeGinzLIBKnzIumBUaeLXqCVVQewnShFaZUG6mO2zgnXZviBjZ3/AAQpJXANt67fLD6Xwjy7jGZL2OThnUtyNWnDMOvg5IjGBbddwTBgFREoOh+9+VdRVH109MAn+kFdJAVb4EJcnwJ8icv6BmlJ2+1QaUMEnJLh4IJK6JavzufICFQ5Z63iK3wtaVXV5qFoOPpT6k4qBtX+MEcou0f2QQoYQNkRaRyGj91cnC64o+PZxQM8biRQ/a7xUqrTMnAVYgK6/6Z1ey079h0NDqToDSBBzlrDS1RmcSMd5guL/k+pt6OM/Z8hiUCn3LzlxfTo5RU0MitTPBU0hyIFG48gSwFNceDgL12NuxnePQGs1/NqDuSIarFj8qgz; 4:J9DNxUj3A7mpFkbOyDdJCtha71aIHxou5U7zv98rkvB61mIBdJhXZnGAqwvvIVjRdM9AlmD0p+o2ioSjBkOEbNneZEYGdz71tom2FUQiaXhVTXChFo9XUCp2Ml5tcbfqUaxidgS1Djc0Ms9Ubd0tkf1k4UCFja3OQL0z4W/QuPsDYakj3oee9zDXwU6vyh8aTiZg2silkpdM1XQ/OgWpBPlkiq5XPun3aXMmhi4177Np+duAyCBuDTKUkic4uH23BFvZbr+cArOjEa+ciNO1Jx8c1wGEMMssE91eJslygBQCTLWicEtp33hB62Ugji3P X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231023)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(20161123558100)(6072148)(201708071742011); SRVR:HE1PR0502MB3659; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR0502MB3659; X-Forefront-PRVS: 052670E5A4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39860400002)(396003)(189003)(199004)(478600001)(36756003)(16586007)(316002)(3846002)(7736002)(6116002)(97736004)(50226002)(25786009)(386003)(16526018)(59450400001)(33026002)(69596002)(68736007)(8936002)(2906002)(86362001)(81166006)(8676002)(81156014)(105586002)(50466002)(48376002)(106356001)(53936002)(51416003)(7696005)(52116002)(76176011)(6666003)(4720700003)(6916009)(4326008)(5660300001)(21086003)(305945005)(2950100002)(66066001)(47776003)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3659; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0502MB3659; 23://THtH53t4BCC+BlHvK5VSzt3iiBC3XL9LOjwve?= =?us-ascii?Q?C+PHBkAOspN+sJr/NM+XS8nX6cBjngkvREDeZeRmRRmkzwaLA3lo058jXPwi?= =?us-ascii?Q?iRRjZuvOe9DIg/oonk9Ft995i+v08/qjlgRBuQsMD0U8MEluBjzj8x96BS9S?= =?us-ascii?Q?AXcR72k/o5spGRdqzOkN4QS4h5wwhP6YuVwk1mK344RawcZEj3THKgOYm3Nh?= =?us-ascii?Q?X+I91kWkFK2qQGVDufmuQIQXtEYD1hDgQr1vN52somv+GN2HzSZSEDvX1+g4?= =?us-ascii?Q?/YTw1kTHI1kADOwb5Ky/LtMLBAttk2wZCbO5ed3yWMWIYbMTmxwerVf70XUE?= =?us-ascii?Q?/5esJSdPUFjnlJWvo5N+ZLeZhIIuasDb/se0WJdri7QJGkBRb7o9hdjOl2s9?= =?us-ascii?Q?dyuU3Sp5HykWhZwn8VGcpgAOxD9Ai6SSSVHw6PiERuub7Dxcm/sqqpMt84WQ?= =?us-ascii?Q?MgGquLb/nHmg9peo4ACkyqOYlGVokXGMmDaDeuV8aJqTHKlcYCUfNbyyWmHQ?= =?us-ascii?Q?d+XkhDpcrbDUktUNBWmiikPY2353MmoFDwjDypyM1eTfYJqOaubq8xwDHKXi?= =?us-ascii?Q?42qPI+LHU8YqubElj5OCNJNH5Aqh/t+7cgYmgayge39og7TUbzf1lF/9GvpT?= =?us-ascii?Q?0BMRio4wkOhpts0li2fvuDpM0aKw563HP5SRvcSVwaXhyl9XsjikxlHIu5bE?= =?us-ascii?Q?x9d729dSn452YPSsIOG+1rR8w4W0oQFU3PmjkT8FpzpqNr/+/YLpg/EOApYM?= =?us-ascii?Q?n/FvJxO6+WaFxn618qaY/qilSd079MB5JFUYVt89kcfoa10eTiXKdqCc+png?= =?us-ascii?Q?akqvaBoBO1r9nBx/6gb+ksO5NXRdqFGv1XLrcSdqgRTFruHBxin25QWoXouh?= =?us-ascii?Q?tkMMaXo/LDqPtXgxFj54zpyVqOHooIt47iq/XuS1XW1ROMGCIFN1JSGvKJ/W?= =?us-ascii?Q?U00tLTaC6yqWO6WMz4GRI7FzsnOxbxCUUZUhOrLUEl6wV3NU/qs++ZBy1rK5?= =?us-ascii?Q?tPsVQmoRX4Rh7wphF9N57i6tGiAE01dLEKbwtjSOoQxlffHighEjFZXCK7Hc?= =?us-ascii?Q?/C1kvd5Yv69WBh5DztnepBpAxVBbSoDLl0nIW9lP+Ne2Gv1Ofzll9LUuM09g?= =?us-ascii?Q?xTvH/mrb/g7RxyWnxherqKQhSKsrZPbHc?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 6:x/LdbOucUSA/L6RGQonp7eHmMKTCMDVPPMVyKfzJmuANC04XFWXu4y+UJGeeyH7+h6NEc6maUsKvH+5P5CQnR5Pjviy209e9bjar5g2JiVmZSxQSROvWDR8IK1pS25ZojUeSbmiSu9lr9UknXtgW9l/PUzBjrQb2qa9S1BVieJOVeLYEPjlbNtvQUvwkrsfWDX5rX9goQQMRa8o4sPT99npgcKfbWK0yYkoF5ntuD39rPIMjzMjwRr2v+bdn2Lx/9aCcfrqzTG8eStCM12RgwvU3vJdaU7frUsNQUlDWmXKCJWYXEtdIGbtusi4XfcvcwJt40++Kv0tYDsUzU2hDyiaErihfw2WBUzLlH143VT4=; 5:x1cCgQEAvtZExRc9QXq+C7BvtGuzSA7H1upi6MnM2pLK+zRiS+kpJ49wQ9wKUhdaeA7LgNcjhYp1D7bxQ3kHkN5vf/SU3R4XN36dUO0H7mDFF/YN8a3nUHhoGl8G5aIwbSwhIpD+I5rnpQ+o8dAdxjXh/wEOykrARzQsgUl166Y=; 24:kpC8feSt5QOFY52tSOvjZqyDDf2z8T7pA8nkvDC/RErLGnXo1kwi6wB1miaxDA+znDSAjFV/199qLoznrnl/cFbs03TUmDgA74p8uzg5cbU=; 7:+dbz2zYSecsUxlZKJZe5w9wYpu900LCfRVmVhIfUGRQanZ+FUjHFjDRCMd92OhrU64i0mK0kejs3vLaIdz8vevLrklouNasmaAcQxlaPl46Losf469ph8ae8S8eyd43F5mIkbwFLqDbF6Cj7exrQ+e1vG5viuS8YJNSf0UzxNjIq6j7HXzP8YgPXNypkiBjuvnnPmHCedPanr0S0MggnS9xdt7MZLtcI9kPnqHMZZv++2bY+VWJJxTfW+g5bxVR0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 17:14:52.7393 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de6158e8-2539-4cf4-db8f-08d547040514 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3659 Subject: [dpdk-dev] [PATCH v3 2/3] net/failsafe: mitigate data plan atomic operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 17:14:55 -0000 Fail-safe uses atomic operations to protect sub-device close operation calling by host thread in removal time while the removed sub-device burst functions are still in process by application threads. Using "set" atomic operations is a liitle bit more efficient than "add" or "sub" atomic operations because "set" shouldn't read the value and in fact, it does not need a special atomic mechanism in x86 platforms. Replace "add 1" and "sub 1" atomic operations by "set 1" and "set 0" atomic operations. Signed-off-by: Matan Azrad --- drivers/net/failsafe/failsafe_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h index d81cc3c..4196ece 100644 --- a/drivers/net/failsafe/failsafe_private.h +++ b/drivers/net/failsafe/failsafe_private.h @@ -269,13 +269,13 @@ int failsafe_eth_lsc_event_callback(uint16_t port_id, * a: (rte_atomic64_t) */ #define FS_ATOMIC_P(a) \ - rte_atomic64_add(&(a), 1) + rte_atomic64_set(&(a), 1) /** * a: (rte_atomic64_t) */ #define FS_ATOMIC_V(a) \ - rte_atomic64_sub(&(a), 1) + rte_atomic64_set(&(a), 0) /** * s: (struct sub_device *) -- 1.8.3.1