From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 5E57A5323 for ; Thu, 27 Nov 2014 21:26:01 +0100 (CET) Received: by mail-wi0-f173.google.com with SMTP id r20so16754128wiv.6 for ; Thu, 27 Nov 2014 12:26:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=fZqyfuM4ojg4W44vCFf6X1Y0PN96yS1tGqHrDCZ2XUk=; b=VgIiSF8uP0cgvg9+/aiP1nMzPuOlHIIB6QBknQo+umTtMzEfoD+h1FyK+sqbAgjhlC Qt/30mDcLBi6FRITHDXcYZ9414w6Q90q+/ZFVb8TCL62AKA7w4Ke+nRuD9L6eWeggreE u7vEsNFd9upOUhs/FG4sz4hgSkylkhv/ZeZ6I6F3FXU/XstZJtPYP3QQ1qb9S+ZO0kpc bJrH0C1dAgyREvZwHTZIUmhYWWi4bHFjOAFgWb0nP/1j0oXolE/j2G6NlcTE9IXanVT5 Oey28lPF/l6hDqZ5Itsc5qQBJGpo2EQBaLviftGYw3DERE5Yh/7nm294tx+qQJwuEOYN bZjg== X-Gm-Message-State: ALoCoQkSdWVzjB7Bm95zht4PCuuWHO4EPuCMg3r4AVjBH6WTj/8kjW8l36qTbhIS6B+Fsmxk2+Ou X-Received: by 10.194.174.40 with SMTP id bp8mr60971833wjc.104.1417119961228; Thu, 27 Nov 2014 12:26:01 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id bf6sm12148702wjb.13.2014.11.27.12.26.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Nov 2014 12:26:00 -0800 (PST) From: Thomas Monjalon To: "Jastrzebski, MichalX K" Date: Thu, 27 Nov 2014 21:25:37 +0100 Message-ID: <1513892.bByYk3r42F@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB1582138BD7D1@IRSMSX109.ger.corp.intel.com> References: <1417111270-12792-1-git-send-email-michalx.k.jastrzebski@intel.com> <1503684.yXJvT1DJi7@xps13> <60ABE07DBB3A454EB7FAD707B4BB1582138BD7D1@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 1/1] bond: add mode 4 support v7 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 20:26:01 -0000 > > 2014-11-27 18:01, Michal Jastrzebski: > > > From: Pawel Wodkowski > > > > > > This patch set add support for dynamic link aggregation (mode 4) to the > > > librte_pmd_bond library. This mode provides auto > > negotiation/configuration > > > of peers and well as link status changes monitoring using out of band > > > LACP (link aggregation control protocol) messages. For further details of > > > LACP specification see the IEEE 802.3ad/802.1AX standards. It is also > > > described here > > > https://www.kernel.org/doc/Documentation/networking/bonding.txt. > > > > > > In this implementation we have an array of mode 4 settings for each slave. > > > There is also assumption that for every port is one aggregator (it might > > > be unused if better is found). > > > > > > Difference in this implementation vs Linux implementation: > > > - this implementation it is not directly based on state machines but current > > > state is calculated from actor and partner states (and other things too). > > > > > > Some implementation details: > > > - during rx burst every packet Is checked if this is LACP or marker packet. > > > If it is LACP frame it is passed to mode 4 logic using slaves rx ring and > > > removed from rx buffer before it is returned > > > - in tx burst, packets from mode 4 (if any) are injected into each slave. > > > - there is a timer running in background to process/produce mode 4 > > > frames form rx/to tx functions. > > > > > > Some requirements for this mode: > > > - for LACP mode to work rx and tx burst functions must be invoked > > > at least in 100ms intervals (testpmd modified to satisfy this requirement) > > > - provided buffer to rx burst should be at least 2x slave count size. This is > > > not needed but might increase performance especially during initial > > > handshake. > > > > > > Signed-off-by: Pawel Wodkowski > > > > I guess it is acked by Declan? > > Hi Thomas, > I sent this patch to Declan before, and he had no objections. Applied Thanks -- Thomas